[INFO] cloning repository https://github.com/ModPhoenix/ray_tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ModPhoenix/ray_tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModPhoenix%2Fray_tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModPhoenix%2Fray_tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fe960dfd3606651ee617d63d1f6b81bfa9d24db7 [INFO] checking ModPhoenix/ray_tracer/fe960dfd3606651ee617d63d1f6b81bfa9d24db7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModPhoenix%2Fray_tracer" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ModPhoenix/ray_tracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ModPhoenix/ray_tracer [INFO] finished tweaking git repo https://github.com/ModPhoenix/ray_tracer [INFO] tweaked toml for git repo https://github.com/ModPhoenix/ray_tracer written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ModPhoenix/ray_tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec17fcce1e9abd31a781739eb371c6e139bd6f98b8124b368ab40f718262c7b8 [INFO] running `Command { std: "docker" "start" "-a" "ec17fcce1e9abd31a781739eb371c6e139bd6f98b8124b368ab40f718262c7b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec17fcce1e9abd31a781739eb371c6e139bd6f98b8124b368ab40f718262c7b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec17fcce1e9abd31a781739eb371c6e139bd6f98b8124b368ab40f718262c7b8", kill_on_drop: false }` [INFO] [stdout] ec17fcce1e9abd31a781739eb371c6e139bd6f98b8124b368ab40f718262c7b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] caf93847244bb9531c9763d2c5f85dc5752f1bef7dcde74b0a23f778de3f229c [INFO] running `Command { std: "docker" "start" "-a" "caf93847244bb9531c9763d2c5f85dc5752f1bef7dcde74b0a23f778de3f229c", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.78 [INFO] [stderr] Compiling bumpalo v3.9.1 [INFO] [stderr] Compiling serde_json v1.0.74 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling wasm-bindgen v0.2.78 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking bytemuck v1.7.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking scoped-tls-hkt v0.1.2 [INFO] [stderr] Checking uuid v1.0.0-alpha.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking ray_tracer v0.1.0 (/opt/rustwide/workdir/ray_tracer) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ray_tracer/src/camera.rs:81:33 [INFO] [stdout] | [INFO] [stdout] 80 | fn unwrap_arc_mutex(x: Arc>) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | std::mem::take(&mut x.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ray_tracer/src/intersections.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut containers: Vec> = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | self.object.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray_tracer` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ray_tracer/src/camera.rs:81:33 [INFO] [stdout] | [INFO] [stdout] 80 | fn unwrap_arc_mutex(x: Arc>) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | std::mem::take(&mut x.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ray_tracer/src/intersections.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut containers: Vec> = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | self.object.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&dyn Shape` instead of cloning the inner type [INFO] [stdout] --> ray_tracer/src/world.rs:290:28 [INFO] [stdout] | [INFO] [stdout] 290 | assert_eq!(c, inner.clone().get_material().get_color()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray_tracer` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "caf93847244bb9531c9763d2c5f85dc5752f1bef7dcde74b0a23f778de3f229c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "caf93847244bb9531c9763d2c5f85dc5752f1bef7dcde74b0a23f778de3f229c", kill_on_drop: false }` [INFO] [stdout] caf93847244bb9531c9763d2c5f85dc5752f1bef7dcde74b0a23f778de3f229c