[INFO] cloning repository https://github.com/MnO2/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MnO2/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMnO2%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMnO2%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e09c1999dd44b2172fc761dcee99f50b8f73ae40 [INFO] checking MnO2/kvs/e09c1999dd44b2172fc761dcee99f50b8f73ae40 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMnO2%2Fkvs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MnO2/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MnO2/kvs [INFO] finished tweaking git repo https://github.com/MnO2/kvs [INFO] tweaked toml for git repo https://github.com/MnO2/kvs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MnO2/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6c7f4767c7a0b5277e18d7448d1c6ba2af272451ea7b23401d1ce26ac7fa163 [INFO] running `Command { std: "docker" "start" "-a" "a6c7f4767c7a0b5277e18d7448d1c6ba2af272451ea7b23401d1ce26ac7fa163", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6c7f4767c7a0b5277e18d7448d1c6ba2af272451ea7b23401d1ce26ac7fa163", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6c7f4767c7a0b5277e18d7448d1c6ba2af272451ea7b23401d1ce26ac7fa163", kill_on_drop: false }` [INFO] [stdout] a6c7f4767c7a0b5277e18d7448d1c6ba2af272451ea7b23401d1ce26ac7fa163 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] adcce6c69a063b05fc83776d7849d22cebb0554b7651142f3f023c922f5c3348 [INFO] running `Command { std: "docker" "start" "-a" "adcce6c69a063b05fc83776d7849d22cebb0554b7651142f3f023c922f5c3348", kill_on_drop: false }` [INFO] [stderr] Compiling syn v0.15.36 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking walkdir v2.2.8 [INFO] [stderr] Checking tempfile v3.0.8 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling backtrace-sys v0.1.30 [INFO] [stderr] Checking backtrace v0.3.32 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.92 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Serializer` [INFO] [stdout] --> src/reader.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | use rmp_serde::{Deserializer, Serializer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/reader.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufRead` [INFO] [stdout] --> src/reader.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::BufRead; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserializer` [INFO] [stdout] --> src/writer.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use rmp_serde::{Deserializer, Serializer}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/writer.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BigEndian` and `WriteBytesExt` [INFO] [stdout] --> src/lib.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use byteorder::{BigEndian, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserializer` and `Serializer` [INFO] [stdout] --> src/lib.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use rmp_serde::{Deserializer, Serializer}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/lib.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:172:14 [INFO] [stdout] | [INFO] [stdout] 172 | let (mut file_id, mut file_to_write) = if self.should_write_to_new_file(self.file_names.last().unwrap())? { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_offset` [INFO] [stdout] --> src/lib.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | let file_offset = file_to_write.seek(io::SeekFrom::End(0))?; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_offset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `curr_offset` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:303:21 [INFO] [stdout] | [INFO] [stdout] 303 | let mut curr_offset = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_curr_offset` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `curr_offset` is never read [INFO] [stdout] --> src/lib.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | curr_offset = next_offset; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `curr_idx` is never read [INFO] [stdout] --> src/lib.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 342 | curr_idx += 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | reader.read_record(io::SeekFrom::Start(keyinfo.record_pos), &mut record, &mut next_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 157 | let _ = reader.read_record(io::SeekFrom::Start(keyinfo.record_pos), &mut record, &mut next_offset); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | writer.write_record(&new_record); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 204 | let _ = writer.write_record(&new_record); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | writer.write_record(&new_record); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 259 | let _ = writer.write_record(&new_record); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | rdr.seek(io::SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 297 | let _ = rdr.seek(io::SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 383 | f.1.sync_data(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 383 | let _ = f.1.sync_data(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(rdr: R) -> Reader { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Reader { [INFO] [stdout] 18 | rdr: io::BufReader::with_capacity(100, rdr), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 2 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "adcce6c69a063b05fc83776d7849d22cebb0554b7651142f3f023c922f5c3348", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adcce6c69a063b05fc83776d7849d22cebb0554b7651142f3f023c922f5c3348", kill_on_drop: false }` [INFO] [stdout] adcce6c69a063b05fc83776d7849d22cebb0554b7651142f3f023c922f5c3348