[INFO] cloning repository https://github.com/MichaelLeith/ArgParsnip [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MichaelLeith/ArgParsnip" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2FArgParsnip", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2FArgParsnip'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3bca1e7fa060e0cecd3ccfd5bba48ae7091f0db7 [INFO] checking MichaelLeith/ArgParsnip/3bca1e7fa060e0cecd3ccfd5bba48ae7091f0db7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2FArgParsnip" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MichaelLeith/ArgParsnip on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MichaelLeith/ArgParsnip [INFO] finished tweaking git repo https://github.com/MichaelLeith/ArgParsnip [INFO] tweaked toml for git repo https://github.com/MichaelLeith/ArgParsnip written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MichaelLeith/ArgParsnip already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c80f1adc0659fc7d1674d859e04ae3bd6ff2d7c9de6d87ad9f34cec9dbb333f [INFO] running `Command { std: "docker" "start" "-a" "1c80f1adc0659fc7d1674d859e04ae3bd6ff2d7c9de6d87ad9f34cec9dbb333f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c80f1adc0659fc7d1674d859e04ae3bd6ff2d7c9de6d87ad9f34cec9dbb333f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c80f1adc0659fc7d1674d859e04ae3bd6ff2d7c9de6d87ad9f34cec9dbb333f", kill_on_drop: false }` [INFO] [stdout] 1c80f1adc0659fc7d1674d859e04ae3bd6ff2d7c9de6d87ad9f34cec9dbb333f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8208f5393d4eddc2bec00bafa02d28d527229137a00828e321f4c95897d25b63 [INFO] running `Command { std: "docker" "start" "-a" "8208f5393d4eddc2bec00bafa02d28d527229137a00828e321f4c95897d25b63", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling cast v0.2.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling cpp_demangle v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling ahash v0.6.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking debugid v0.7.2 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking bytemuck v1.5.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling symbolic-demangle v8.0.5 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rgb v0.8.27 [INFO] [stderr] Checking plotters v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking num-format v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking symbolic-common v8.0.5 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking quick-xml v0.20.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking lock_api v0.4.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling pprof v0.4.3 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking object v0.23.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking inferno v0.10.3 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking pretty_assertions v0.7.2 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Checking addr2line v0.14.1 [INFO] [stderr] Checking backtrace v0.3.56 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking argparsnip v0.1.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:50 [INFO] [stdout] | [INFO] [stdout] 55 | #[cfg_attr(feature = "derive", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:132:39 [INFO] [stdout] | [INFO] [stdout] 132 | #[cfg_attr(feature = "derive", derive(Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:543:12 [INFO] [stdout] | [INFO] [stdout] 476 | fn apply(&'a self, args: T) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | let mut args = args.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | Ok((self.handler)(Results { [INFO] [stdout] | ____________^ [INFO] [stdout] 544 | | path: self.path.unwrap_or(self.name), [INFO] [stdout] 545 | | flags: builder.flags, [INFO] [stdout] 546 | | args: builder.args, [INFO] [stdout] 547 | | unknown_args, [INFO] [stdout] 548 | | positional, [INFO] [stdout] 549 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg_attr(feature = "derive", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:30:50 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg_attr(feature = "derive", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/value.rs:218:52 [INFO] [stdout] | [INFO] [stdout] 218 | Type::Any | Type::String => Value::from(val.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `argparsnip` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8208f5393d4eddc2bec00bafa02d28d527229137a00828e321f4c95897d25b63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8208f5393d4eddc2bec00bafa02d28d527229137a00828e321f4c95897d25b63", kill_on_drop: false }` [INFO] [stdout] 8208f5393d4eddc2bec00bafa02d28d527229137a00828e321f4c95897d25b63