[INFO] cloning repository https://github.com/MichaelBurge/nes-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MichaelBurge/nes-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelBurge%2Fnes-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelBurge%2Fnes-emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4ae4af6e8a9b126c5440385411c3f8917846c00 [INFO] checking MichaelBurge/nes-emulator/c4ae4af6e8a9b126c5440385411c3f8917846c00 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelBurge%2Fnes-emulator" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MichaelBurge/nes-emulator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config [INFO] started tweaking git repo https://github.com/MichaelBurge/nes-emulator [INFO] finished tweaking git repo https://github.com/MichaelBurge/nes-emulator [INFO] tweaked toml for git repo https://github.com/MichaelBurge/nes-emulator written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MichaelBurge/nes-emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: file `/workspace/builds/worker-3-tc2/source/examples/headless.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `headless` [INFO] [stderr] * `example` target `headless` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5316e4de52a9d168ef80f8e2b64b2c08cba0e61b926b54b73396b41295aabf34 [INFO] running `Command { std: "docker" "start" "-a" "5316e4de52a9d168ef80f8e2b64b2c08cba0e61b926b54b73396b41295aabf34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5316e4de52a9d168ef80f8e2b64b2c08cba0e61b926b54b73396b41295aabf34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5316e4de52a9d168ef80f8e2b64b2c08cba0e61b926b54b73396b41295aabf34", kill_on_drop: false }` [INFO] [stdout] 5316e4de52a9d168ef80f8e2b64b2c08cba0e61b926b54b73396b41295aabf34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd70b10dcc8e8f41f56d7f557887a336979514bce1ea11f95f540c59fe1af95a [INFO] running `Command { std: "docker" "start" "-a" "bd70b10dcc8e8f41f56d7f557887a336979514bce1ea11f95f540c59fe1af95a", kill_on_drop: false }` [INFO] [stderr] warning: file `/opt/rustwide/workdir/examples/headless.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `headless` [INFO] [stderr] * `example` target `headless` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking os_str_bytes v4.2.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Compiling serde_json v1.0.56 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Checking tokio v0.2.21 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.5 [INFO] [stderr] Checking clap v3.0.0-beta.5 [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stderr] Checking nes-emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/headless_protocol.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{debug, error, trace}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ffi::OsStr` [INFO] [stdout] --> src/headless_protocol.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | ffi::OsStr, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/headless_protocol.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut fh = &mut BufWriter::new(fh); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/headless_protocol.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | SocketHeadlessClient(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ppu.rs:691:21 [INFO] [stdout] | [INFO] [stdout] 687 | let mapper = Mapper::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 691 | mapper: Box::new(mapper), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nes-emulator` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "bd70b10dcc8e8f41f56d7f557887a336979514bce1ea11f95f540c59fe1af95a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd70b10dcc8e8f41f56d7f557887a336979514bce1ea11f95f540c59fe1af95a", kill_on_drop: false }` [INFO] [stdout] bd70b10dcc8e8f41f56d7f557887a336979514bce1ea11f95f540c59fe1af95a