[INFO] cloning repository https://github.com/Melesar/eye [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Melesar/eye" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMelesar%2Feye", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMelesar%2Feye'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bff243e26a96ccaad8474c8fe8b6b869377e5938 [INFO] checking Melesar/eye/bff243e26a96ccaad8474c8fe8b6b869377e5938 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMelesar%2Feye" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Melesar/eye on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Melesar/eye [INFO] finished tweaking git repo https://github.com/Melesar/eye [INFO] tweaked toml for git repo https://github.com/Melesar/eye written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Melesar/eye already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a36d54c466cada4308927eb12eceb2f50d8a3a98fb55c9e23cc6d7597064a30d [INFO] running `Command { std: "docker" "start" "-a" "a36d54c466cada4308927eb12eceb2f50d8a3a98fb55c9e23cc6d7597064a30d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a36d54c466cada4308927eb12eceb2f50d8a3a98fb55c9e23cc6d7597064a30d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a36d54c466cada4308927eb12eceb2f50d8a3a98fb55c9e23cc6d7597064a30d", kill_on_drop: false }` [INFO] [stdout] a36d54c466cada4308927eb12eceb2f50d8a3a98fb55c9e23cc6d7597064a30d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f86a2e77ce6159226a8786177746048256698d61e76400e5a9e2afcece22c8c [INFO] running `Command { std: "docker" "start" "-a" "7f86a2e77ce6159226a8786177746048256698d61e76400e5a9e2afcece22c8c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Checking pnet_base v0.29.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling openssl-src v111.22.0+1.1.1q [INFO] [stderr] Compiling fixedbitset v0.4.1 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking pnet_macros_support v0.29.0 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking pnet_sys v0.29.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling petgraph v0.6.2 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling which v4.2.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking tracing-subscriber v0.3.15 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking owo-colors v3.4.0 [INFO] [stderr] Compiling pnet v0.29.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking libmath v0.2.1 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Compiling regex v1.5.5 [INFO] [stderr] Checking ipnetwork v0.18.0 [INFO] [stderr] Checking pnet_datalink v0.29.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling prost-derive v0.11.0 [INFO] [stderr] Compiling pnet_macros v0.29.0 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking pnet_packet v0.29.0 [INFO] [stderr] Compiling prost v0.11.0 [INFO] [stderr] Compiling prost-types v0.11.1 [INFO] [stderr] Compiling prost-build v0.11.1 [INFO] [stderr] Compiling eye v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `ErrorKind` and `Error` [INFO] [stdout] --> build.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io::{Result, Error, ErrorKind}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> build.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking pnet_transport v0.29.0 [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/client.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | Err(e) => eprintln!("Failed to encode message"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/client.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | Err(e) => eprintln!("Failed to encode message"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | cursor.seek(SeekFrom::Current(8)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 38 | let _ = cursor.seek(SeekFrom::Current(8)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eye` (bin "client") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | cursor.seek(SeekFrom::Current(8)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 38 | let _ = cursor.seek(SeekFrom::Current(8)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eye` (bin "client" test) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | let mut features = features::CAMERA; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | let mut features = features::CAMERA; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVO` is never used [INFO] [stdout] --> src/server.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 35 | pub const SERVO: u32 = 1 << 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVO_ROTATION_INTERVAL` is never used [INFO] [stdout] --> src/servo.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const SERVO_ROTATION_INTERVAL: u64 = 500; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVO` is never used [INFO] [stdout] --> src/server.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 35 | pub const SERVO: u32 = 1 << 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `DeviceNotAvailable` and `CommunicationFailure` are never constructed [INFO] [stdout] --> src/servo.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Error { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 15 | ServoNotEnabled, [INFO] [stdout] 16 | DeviceNotAvailable, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | CommunicationFailure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ServoImpl` is never used [INFO] [stdout] --> src/servo.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | trait ServoImpl { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVO_ROTATION_INTERVAL` is never used [INFO] [stdout] --> src/servo.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const SERVO_ROTATION_INTERVAL: u64 = 500; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dx` and `dy` are never read [INFO] [stdout] --> src/servo.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | struct ServoControl { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 25 | pub dx: i8, [INFO] [stdout] | ^^ [INFO] [stdout] 26 | pub dy: i8, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `DeviceNotAvailable` and `CommunicationFailure` are never constructed [INFO] [stdout] --> src/servo.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Error { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 15 | ServoNotEnabled, [INFO] [stdout] 16 | DeviceNotAvailable, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | CommunicationFailure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/servo.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 45 | impl Servo { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 46 | fn new(servo_impl: T) -> Result where T: ServoImpl + Send + 'static { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ServoImpl` is never used [INFO] [stdout] --> src/servo.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | trait ServoImpl { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `servo_control_routine` is never used [INFO] [stdout] --> src/servo.rs:64:10 [INFO] [stdout] | [INFO] [stdout] 64 | async fn servo_control_routine(mut servo_impl: T, mut receiver: Receiver) -> Result<(), Error> where T: ServoImpl + Send{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dx` and `dy` are never read [INFO] [stdout] --> src/servo.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | struct ServoControl { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 25 | pub dx: i8, [INFO] [stdout] | ^^ [INFO] [stdout] 26 | pub dy: i8, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `should_stop` is never used [INFO] [stdout] --> src/servo.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 78 | impl ServoControl { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] 79 | fn should_stop(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/servo.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 45 | impl Servo { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 46 | fn new(servo_impl: T) -> Result where T: ServoImpl + Send + 'static { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestServo` is never constructed [INFO] [stdout] --> src/servo/test_servo.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TestServo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `servo_control_routine` is never used [INFO] [stdout] --> src/servo.rs:64:10 [INFO] [stdout] | [INFO] [stdout] 64 | async fn servo_control_routine(mut servo_impl: T, mut receiver: Receiver) -> Result<(), Error> where T: ServoImpl + Send{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `should_stop` is never used [INFO] [stdout] --> src/servo.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 78 | impl ServoControl { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] 79 | fn should_stop(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestServo` is never constructed [INFO] [stdout] --> src/servo/test_servo.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TestServo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | if let Err(e) = server.start().await { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________________________________________| [INFO] [stdout] 31 | || eprintln!("Server failed: {}", e); [INFO] [stdout] 32 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | if let Err(e) = server.start().await { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________________________________________| [INFO] [stdout] 31 | || eprintln!("Server failed: {}", e); [INFO] [stdout] 32 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 31 | let file = std::fs::File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let reader = std::io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Err(Error::new(ErrorKind::NotFound, "Failed to find camera port setting in config file")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / Command::new("motion") [INFO] [stdout] 58 | | .arg("-c").arg(config_file.into_os_string()) [INFO] [stdout] 59 | | .arg("-p").arg(pid_file.into_os_string()) [INFO] [stdout] 60 | | .stdout(Stdio::null()) [INFO] [stdout] 61 | | .stderr(Stdio::null()) [INFO] [stdout] 62 | | .spawn() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 31 | let file = std::fs::File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let reader = std::io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Err(Error::new(ErrorKind::NotFound, "Failed to find camera port setting in config file")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / Command::new("kill") [INFO] [stdout] 71 | | .arg("-INT") [INFO] [stdout] 72 | | .arg(pid.trim()) [INFO] [stdout] 73 | | .spawn() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / Command::new("motion") [INFO] [stdout] 58 | | .arg("-c").arg(config_file.into_os_string()) [INFO] [stdout] 59 | | .arg("-p").arg(pid_file.into_os_string()) [INFO] [stdout] 60 | | .stdout(Stdio::null()) [INFO] [stdout] 61 | | .stderr(Stdio::null()) [INFO] [stdout] 62 | | .spawn() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera/motion_camera.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / Command::new("kill") [INFO] [stdout] 71 | | .arg("-INT") [INFO] [stdout] 72 | | .arg(pid.trim()) [INFO] [stdout] 73 | | .spawn() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/camera/motion_camera.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.stop(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 84 | let _ = self.stop(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:67:53 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(camera: Box, servo: Option) -> Self { [INFO] [stdout] | ------------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Server { camera, servo, client_connections: HashMap::new() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/camera/motion_camera.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.stop(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 84 | let _ = self.stop(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:84:107 [INFO] [stdout] | [INFO] [stdout] 80 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | tokio::spawn(async move { handle_client_connection(reader, sender, current_client_id).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:67:53 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(camera: Box, servo: Option) -> Self { [INFO] [stdout] | ------------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Server { camera, servo, client_connections: HashMap::new() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:84:107 [INFO] [stdout] | [INFO] [stdout] 80 | let (reader, writer) = stream.into_split(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | tokio::spawn(async move { handle_client_connection(reader, sender, current_client_id).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 46 | fn new(servo_impl: T) -> Result where T: ServoImpl + Send + 'static { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let (sender, receiver) = mpsc::channel(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(Servo { sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 46 | fn new(servo_impl: T) -> Result where T: ServoImpl + Send + 'static { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let (sender, receiver) = mpsc::channel(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(Servo { sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eye` (bin "server") due to 8 previous errors; 11 warnings emitted [INFO] [stderr] error: could not compile `eye` (bin "server" test) due to 8 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7f86a2e77ce6159226a8786177746048256698d61e76400e5a9e2afcece22c8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f86a2e77ce6159226a8786177746048256698d61e76400e5a9e2afcece22c8c", kill_on_drop: false }` [INFO] [stdout] 7f86a2e77ce6159226a8786177746048256698d61e76400e5a9e2afcece22c8c