[INFO] cloning repository https://github.com/Measter/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Measter/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMeaster%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMeaster%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a8f8a88ea94b7db2c184164fefde3e7fefcb6e62 [INFO] checking Measter/rlox/a8f8a88ea94b7db2c184164fefde3e7fefcb6e62 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMeaster%2Frlox" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Measter/rlox on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Measter/rlox [INFO] finished tweaking git repo https://github.com/Measter/rlox [INFO] tweaked toml for git repo https://github.com/Measter/rlox written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Measter/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.12.1 [INFO] [stderr] Adding atty v0.2.14 [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding equivalent v1.0.1 [INFO] [stderr] Adding hashbrown v0.14.5 [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v2.5.0 [INFO] [stderr] Updating memchr v2.4.1 -> v2.7.4 [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Updating once_cell v1.8.0 -> v1.19.0 [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding proc-macro-error v1.0.4 [INFO] [stderr] Adding proc-macro-error-attr v1.0.4 [INFO] [stderr] Adding rlox v0.1.0 (/workspace/builds/worker-2-tc2/source/crates/rlox) [INFO] [stderr] Adding rloxum v0.1.0 (/workspace/builds/worker-2-tc2/source/crates/vm) [INFO] [stderr] Adding same-file v1.0.6 [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding structopt v0.3.26 [INFO] [stderr] Adding structopt-derive v0.4.18 [INFO] [stderr] Adding tester v0.1.0 (/workspace/builds/worker-2-tc2/source/crates/tester) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding toml_datetime v0.6.8 [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding unicode-segmentation v1.11.0 [INFO] [stderr] Adding vec_map v0.8.2 [INFO] [stderr] Adding walkdir v2.5.0 [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 333661c3ba60ce00045df600292fa0b55905f504d8bd5cc1716ed10ebfc9be96 [INFO] running `Command { std: "docker" "start" "-a" "333661c3ba60ce00045df600292fa0b55905f504d8bd5cc1716ed10ebfc9be96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "333661c3ba60ce00045df600292fa0b55905f504d8bd5cc1716ed10ebfc9be96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "333661c3ba60ce00045df600292fa0b55905f504d8bd5cc1716ed10ebfc9be96", kill_on_drop: false }` [INFO] [stdout] 333661c3ba60ce00045df600292fa0b55905f504d8bd5cc1716ed10ebfc9be96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9ea791f13101937fba554f2c118d76cb1b521d263ec0fe4110b80151c00a8ca [INFO] running `Command { std: "docker" "start" "-a" "f9ea791f13101937fba554f2c118d76cb1b521d263ec0fe4110b80151c00a8ca", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Checking gimli v0.25.0 [INFO] [stderr] Compiling eyre v0.6.5 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking tracing-core v0.1.19 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking tracing-subscriber v0.2.20 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling backtrace v0.3.61 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking lasso v0.6.0 [INFO] [stderr] Checking addr2line v0.16.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking rlox v0.1.0 (/opt/rustwide/workdir/crates/rlox) [INFO] [stderr] Checking tester v0.1.0 (/opt/rustwide/workdir/crates/tester) [INFO] [stderr] Checking rloxum v0.1.0 (/opt/rustwide/workdir/crates/vm) [INFO] [stderr] Checking rloxr v0.1.0 (/opt/rustwide/workdir/crates/interpreter) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> crates/vm/src/value.rs:49:43 [INFO] [stdout] | [INFO] [stdout] 49 | StringObject::Runtime(val) => (&**val), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - StringObject::Runtime(val) => (&**val), [INFO] [stdout] 49 + StringObject::Runtime(val) => &**val, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> crates/vm/src/value.rs:49:43 [INFO] [stdout] | [INFO] [stdout] 49 | StringObject::Runtime(val) => (&**val), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - StringObject::Runtime(val) => (&**val), [INFO] [stdout] 49 + StringObject::Runtime(val) => &**val, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:179:28 [INFO] [stdout] | [INFO] [stdout] 178 | func: |_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Ok(Object::Number( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 180 | | SystemTime::now() [INFO] [stdout] 181 | | .duration_since(SystemTime::UNIX_EPOCH) [INFO] [stdout] 182 | | .unwrap_or(Duration::ZERO) [INFO] [stdout] 183 | | .as_secs_f64(), [INFO] [stdout] 184 | | )) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn with_parent(parent: Rc>) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Self { [INFO] [stdout] 197 | stored_variables: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn with_parent(parent: Rc>) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | parent: Some(parent), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 61 | let globals = Rc::new(RefCell::new(Environment::new_global(interner))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | environment: globals.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:263:43 [INFO] [stdout] | [INFO] [stdout] 257 | let mut env = self.environment.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | env.define(super_token, None, Object::LoxClassSuper(def.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 477 | let env = self.environment.borrow(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | let (super_class, _) = env.get_at(keyword, distance, interner)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | [INFO] [stdout] 480 | let super_class = if let Object::LoxClassSuper(sc) = super_class { [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let (class_instance, _) = env.get_at(this_token, distance - 1, interner)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | [INFO] [stdout] 500 | let class_instance = if let Object::LoxClassInstance(instance) = class_instance { [INFO] [stdout] | -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(Object::Callable(Rc::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 526 | | method.bind(class_instance, program), [INFO] [stdout] 527 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:651:15 [INFO] [stdout] | [INFO] [stdout] 650 | let right = self.evaluate_expression(right_expr, emitter, interner, program)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 651 | match (&operator.kind, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/lox_callable.rs:96:22 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn bind(&self, instance: Rc>, program: &Program) -> LoxCallable { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut closure = Environment::with_parent(self.closure.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | closure: Rc::new(RefCell::new(closure)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/lox_callable.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 210 | args: Vec, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | ) -> EvaluateResult { [INFO] [stdout] 212 | let instance = LoxClassInstance { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let instance = Rc::new(RefCell::new(instance)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(Object::LoxClassInstance(instance)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `emitter` [INFO] [stdout] --> crates/vm/src/token_compiler.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | emitter: &mut DiagnosticEmitter<'_>, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_emitter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `emitter` [INFO] [stdout] --> crates/vm/src/token_compiler.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | emitter: &mut DiagnosticEmitter<'_>, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_emitter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rloxr` (bin "rloxr" test) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:179:28 [INFO] [stdout] | [INFO] [stdout] 178 | func: |_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Ok(Object::Number( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 180 | | SystemTime::now() [INFO] [stdout] 181 | | .duration_since(SystemTime::UNIX_EPOCH) [INFO] [stdout] 182 | | .unwrap_or(Duration::ZERO) [INFO] [stdout] 183 | | .as_secs_f64(), [INFO] [stdout] 184 | | )) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn with_parent(parent: Rc>) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Self { [INFO] [stdout] 197 | stored_variables: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/environment.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn with_parent(parent: Rc>) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | parent: Some(parent), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 61 | let globals = Rc::new(RefCell::new(Environment::new_global(interner))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | environment: globals.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:263:43 [INFO] [stdout] | [INFO] [stdout] 257 | let mut env = self.environment.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | env.define(super_token, None, Object::LoxClassSuper(def.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 477 | let env = self.environment.borrow(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | let (super_class, _) = env.get_at(keyword, distance, interner)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | [INFO] [stdout] 480 | let super_class = if let Object::LoxClassSuper(sc) = super_class { [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let (class_instance, _) = env.get_at(this_token, distance - 1, interner)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | [INFO] [stdout] 500 | let class_instance = if let Object::LoxClassInstance(instance) = class_instance { [INFO] [stdout] | -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(Object::Callable(Rc::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 526 | | method.bind(class_instance, program), [INFO] [stdout] 527 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/interpreter.rs:651:15 [INFO] [stdout] | [INFO] [stdout] 650 | let right = self.evaluate_expression(right_expr, emitter, interner, program)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 651 | match (&operator.kind, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/lox_callable.rs:96:22 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn bind(&self, instance: Rc>, program: &Program) -> LoxCallable { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut closure = Environment::with_parent(self.closure.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | closure: Rc::new(RefCell::new(closure)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/interpreter/src/lox_callable.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 210 | args: Vec, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | ) -> EvaluateResult { [INFO] [stdout] 212 | let instance = LoxClassInstance { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let instance = Rc::new(RefCell::new(instance)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(Object::LoxClassInstance(instance)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rloxr` (bin "rloxr") due to 10 previous errors [INFO] [stdout] warning: field `interner` is never read [INFO] [stdout] --> crates/vm/src/ast_compiler.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct AstCompiler<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 19 | interner: &'a Rodeo, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `kind` and `as_any` are never used [INFO] [stdout] --> crates/vm/src/object.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait Obj: std::fmt::Debug + Any { [INFO] [stdout] | --- methods in this trait [INFO] [stdout] 9 | fn kind(&self) -> ObjKind; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/token_compiler.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 165 | let mut compiler = TokenCompiler::new(source, interner); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | diags.is_empty().then(|| compiler.chunk).ok_or(diags) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(trace: bool, stdout: StdoutLock<'stdout>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | value_stack: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(trace: bool, stdout: StdoutLock<'stdout>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | globals: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 71 | let (right, left) = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match (right.value, &left.value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `interner` is never read [INFO] [stdout] --> crates/vm/src/ast_compiler.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct AstCompiler<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 19 | interner: &'a Rodeo, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `kind` and `as_any` are never used [INFO] [stdout] --> crates/vm/src/object.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait Obj: std::fmt::Debug + Any { [INFO] [stdout] | --- methods in this trait [INFO] [stdout] 9 | fn kind(&self) -> ObjKind; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/token_compiler.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 165 | let mut compiler = TokenCompiler::new(source, interner); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | diags.is_empty().then(|| compiler.chunk).ok_or(diags) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(trace: bool, stdout: StdoutLock<'stdout>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | value_stack: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(trace: bool, stdout: StdoutLock<'stdout>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | globals: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vm/src/vm.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 71 | let (right, left) = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match (right.value, &left.value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rloxum` (bin "rloxum" test) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] error: could not compile `rloxum` (bin "rloxum") due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f9ea791f13101937fba554f2c118d76cb1b521d263ec0fe4110b80151c00a8ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9ea791f13101937fba554f2c118d76cb1b521d263ec0fe4110b80151c00a8ca", kill_on_drop: false }` [INFO] [stdout] f9ea791f13101937fba554f2c118d76cb1b521d263ec0fe4110b80151c00a8ca