[INFO] cloning repository https://github.com/MaxLuchs/warp_test_4 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MaxLuchs/warp_test_4" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxLuchs%2Fwarp_test_4", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxLuchs%2Fwarp_test_4'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9aae174d36692691c81a4274ec3c63fed959cd59 [INFO] checking MaxLuchs/warp_test_4/9aae174d36692691c81a4274ec3c63fed959cd59 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxLuchs%2Fwarp_test_4" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MaxLuchs/warp_test_4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MaxLuchs/warp_test_4 [INFO] finished tweaking git repo https://github.com/MaxLuchs/warp_test_4 [INFO] tweaked toml for git repo https://github.com/MaxLuchs/warp_test_4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MaxLuchs/warp_test_4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22e069e22e671e65d4a33c97f6b2fe74c7b8e6cc85b979e116010bcdfe530e13 [INFO] running `Command { std: "docker" "start" "-a" "22e069e22e671e65d4a33c97f6b2fe74c7b8e6cc85b979e116010bcdfe530e13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22e069e22e671e65d4a33c97f6b2fe74c7b8e6cc85b979e116010bcdfe530e13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22e069e22e671e65d4a33c97f6b2fe74c7b8e6cc85b979e116010bcdfe530e13", kill_on_drop: false }` [INFO] [stdout] 22e069e22e671e65d4a33c97f6b2fe74c7b8e6cc85b979e116010bcdfe530e13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8253d2a576f7f87b4a6638e7b42deea3ca58eebd539f80fdead70b6b7dadef9 [INFO] running `Command { std: "docker" "start" "-a" "b8253d2a576f7f87b4a6638e7b42deea3ca58eebd539f80fdead70b6b7dadef9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.62 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Checking http v0.2.3 [INFO] [stderr] Compiling tokio v1.2.0 [INFO] [stderr] Compiling serde_derive v1.0.124 [INFO] [stderr] Checking futures-sink v0.3.13 [INFO] [stderr] Compiling serde v1.0.124 [INFO] [stderr] Compiling httparse v1.3.5 [INFO] [stderr] Checking tinyvec v1.1.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-task v0.3.13 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking futures-util v0.3.13 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Checking futures-channel v0.3.13 [INFO] [stderr] Checking input_buffer v0.4.0 [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Checking tracing v0.1.25 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling eyre v0.6.5 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking mio v0.7.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking scheduled-thread-pool v0.2.5 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking r2d2 v0.8.9 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking http-body v0.4.0 [INFO] [stderr] Checking sha-1 v0.9.4 [INFO] [stderr] Checking idna v0.2.2 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking headers v0.3.4 [INFO] [stderr] Checking multipart v0.17.1 [INFO] [stderr] Checking url v2.2.1 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking tungstenite v0.12.0 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling pin-project-internal v1.0.5 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking pin-project v1.0.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-util v0.6.3 [INFO] [stderr] Checking tokio-tungstenite v0.13.0 [INFO] [stderr] Checking tokio-stream v0.1.3 [INFO] [stderr] Checking h2 v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking diesel v1.4.6 [INFO] [stderr] Checking hyper v0.14.4 [INFO] [stderr] Checking warp v0.3.0 [INFO] [stderr] Checking warp_test_picard v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Timelike` and `Utc` [INFO] [stdout] --> src/db_models.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | use chrono::{Timelike, Utc}; [INFO] [stdout] | ^^^^^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::result::DatabaseErrorKind::UnableToSendCommand` [INFO] [stdout] --> src/db_models.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use diesel::result::DatabaseErrorKind::UnableToSendCommand; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/db_models.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `uuid::Uuid` [INFO] [stdout] --> src/db_models.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use uuid::Uuid; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Timelike` and `Utc` [INFO] [stdout] --> src/db_models.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | use chrono::{Timelike, Utc}; [INFO] [stdout] | ^^^^^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::result::DatabaseErrorKind::UnableToSendCommand` [INFO] [stdout] --> src/db_models.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use diesel::result::DatabaseErrorKind::UnableToSendCommand; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/db_models.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `uuid::Uuid` [INFO] [stdout] --> src/db_models.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use uuid::Uuid; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_models.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 40 | let con = diesel::sqlite::SqliteConnection::establish(db_url).expect("DB not connected"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | DB { con: Box::new(con) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: where clauses on type aliases are not enforced [INFO] [stdout] --> src/services.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | / where [INFO] [stdout] 16 | | S: Serialize, [INFO] [stdout] | |_____^^^^^^^^^^^^- help: remove this where clause [INFO] [stdout] | | [INFO] [stdout] | will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn get_all_ships(db: SharableDB, filter: ListShipsFilter) -> Result, ServiceError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / db.lock() [INFO] [stdout] 23 | | .map_err(|_| ServiceError::Unknown) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 24 | .and_then(|db| db.list_ships(filter).map_err(|_| ServiceError::DBError)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn add_ship(db: SharableDB, new_ship: NewShip) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | db.lock().map_err(|_| ServiceError::Unknown).and_then(|db| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | db.lock().map_err(|_| ServiceError::Unknown).and_then(|db| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | db.insert_new_ship(new_ship) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn remove_ship(db: SharableDB, ship_id: i32) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | db.lock().map_err(|_| ServiceError::DBError).and_then(|db| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | .and_then(|ship| db.delete(ship).map_err(|_| ServiceError::DBError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_models.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 40 | let con = diesel::sqlite::SqliteConnection::establish(db_url).expect("DB not connected"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | DB { con: Box::new(con) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: where clauses on type aliases are not enforced [INFO] [stdout] --> src/services.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | / where [INFO] [stdout] 16 | | S: Serialize, [INFO] [stdout] | |_____^^^^^^^^^^^^- help: remove this where clause [INFO] [stdout] | | [INFO] [stdout] | will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn get_all_ships(db: SharableDB, filter: ListShipsFilter) -> Result, ServiceError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / db.lock() [INFO] [stdout] 23 | | .map_err(|_| ServiceError::Unknown) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 24 | .and_then(|db| db.list_ships(filter).map_err(|_| ServiceError::DBError)) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn add_ship(db: SharableDB, new_ship: NewShip) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | db.lock().map_err(|_| ServiceError::Unknown).and_then(|db| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | db.lock().map_err(|_| ServiceError::Unknown).and_then(|db| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | db.insert_new_ship(new_ship) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn remove_ship(db: SharableDB, ship_id: i32) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | db.lock().map_err(|_| ServiceError::DBError).and_then(|db| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | .and_then(|ship| db.delete(ship).map_err(|_| ServiceError::DBError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warp_test_picard` (lib) due to 8 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `warp_test_picard` (lib test) due to 8 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b8253d2a576f7f87b4a6638e7b42deea3ca58eebd539f80fdead70b6b7dadef9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8253d2a576f7f87b4a6638e7b42deea3ca58eebd539f80fdead70b6b7dadef9", kill_on_drop: false }` [INFO] [stdout] b8253d2a576f7f87b4a6638e7b42deea3ca58eebd539f80fdead70b6b7dadef9