[INFO] updating cached repository https://github.com/Maurdekye/codecrafters-bittorrent-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ac37d37b7f75da4840e6c141d1fcf8bcf04955f [INFO] checking Maurdekye/codecrafters-bittorrent-rust/9ac37d37b7f75da4840e6c141d1fcf8bcf04955f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaurdekye%2Fcodecrafters-bittorrent-rust" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Maurdekye/codecrafters-bittorrent-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Maurdekye/codecrafters-bittorrent-rust [INFO] finished tweaking git repo https://github.com/Maurdekye/codecrafters-bittorrent-rust [INFO] tweaked toml for git repo https://github.com/Maurdekye/codecrafters-bittorrent-rust written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Maurdekye/codecrafters-bittorrent-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2ead5d78421f573f1acc8306f3589fe0ec67f0d608d074092b238e5434ecb6b [INFO] running `Command { std: "docker" "start" "-a" "d2ead5d78421f573f1acc8306f3589fe0ec67f0d608d074092b238e5434ecb6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2ead5d78421f573f1acc8306f3589fe0ec67f0d608d074092b238e5434ecb6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2ead5d78421f573f1acc8306f3589fe0ec67f0d608d074092b238e5434ecb6b", kill_on_drop: false }` [INFO] [stdout] d2ead5d78421f573f1acc8306f3589fe0ec67f0d608d074092b238e5434ecb6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e5ab0b0186661a81319128d98df91eb76921b9df97e9c70f3e1fd9ba929f874 [INFO] running `Command { std: "docker" "start" "-a" "6e5ab0b0186661a81319128d98df91eb76921b9df97e9c70f3e1fd9ba929f874", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling crossbeam-utils v0.8.17 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Checking crossbeam-epoch v0.9.16 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Checking clap_builder v4.3.22 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking crossbeam-queue v0.3.9 [INFO] [stderr] Checking crossbeam-channel v0.5.9 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tempfile v3.7.1 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking multihash v0.19.1 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking serde_bencode v0.2.3 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking clap v4.3.22 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking bittorrent-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `ip_bits` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(ip_bits)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `ip_bits` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(ip_bits)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `xpe` is never read [INFO] [stdout] --> src/magnet.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Magnet { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub xpe: Vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Magnet` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `torrent_source`, `peer_id`, `connection_id`, `seq_nr`, and `ack_nr` are never read [INFO] [stdout] --> src/peer/utp.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct UtpPeer { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 30 | pub address: SocketAddr, [INFO] [stdout] 31 | pub torrent_source: TorrentSource, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 32 | pub peer_id: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub connection_id: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 36 | pub seq_nr: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 37 | pub ack_nr: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UtpPeer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `pool_map` is never used [INFO] [stdout] --> src/pool.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub trait PoolMapExt<'a, 'b, 'c, I, T, F, V> { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 17 | fn pool_map(self, scope: &'a Scope<'b, 'c>, workers: usize, f: F) -> PoolMap [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bencode.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 277 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Self::Dict(value.into_iter().map(|(k, v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bencode.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 283 | fn from(l: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | Self::List(l.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:173:15 [INFO] [stdout] | [INFO] [stdout] 172 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Bytes(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 49 | active_connection: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | uses: usize, [INFO] [stdout] 51 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / corkboard [INFO] [stdout] 58 | | .write() [INFO] [stdout] 59 | | .map(|mut board| { [INFO] [stdout] 60 | | // If all pieces have been acquired, exit [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 49 | active_connection: Option, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | .map(|mut board| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match active_connection.map(|connection| (connection.address().clone(), connection)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 164 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / corkboard [INFO] [stdout] 171 | | .write() [INFO] [stdout] 172 | | .map(|mut board| { [INFO] [stdout] 173 | | // once there are no unfetched pieces left to acquire, [INFO] [stdout] ... | [INFO] [stdout] 215 | | next_piece [INFO] [stdout] 216 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:239:5 [INFO] [stdout] | [INFO] [stdout] 227 | download_result: Result, T::Error>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | / corkboard [INFO] [stdout] 240 | | .write() [INFO] [stdout] 241 | | .map(|mut board| { [INFO] [stdout] 242 | | match download_result { [INFO] [stdout] ... | [INFO] [stdout] 329 | | } [INFO] [stdout] 330 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker/multimodal.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 208 | let connection = UdpSocket::bind("0.0.0.0:0") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(UdpTrackerConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | connection: connection, [INFO] [stdout] 218 | | last_connection: None, [INFO] [stdout] 219 | | connection_id: None, [INFO] [stdout] 220 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:258:19 [INFO] [stdout] | [INFO] [stdout] 255 | fn unique(self) -> UniqueIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `xpe` is never read [INFO] [stdout] --> src/magnet.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Magnet { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub xpe: Vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Magnet` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `torrent_source`, `peer_id`, `connection_id`, `seq_nr`, and `ack_nr` are never read [INFO] [stdout] --> src/peer/utp.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct UtpPeer { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 30 | pub address: SocketAddr, [INFO] [stdout] 31 | pub torrent_source: TorrentSource, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 32 | pub peer_id: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub connection_id: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 36 | pub seq_nr: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 37 | pub ack_nr: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UtpPeer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `pool_map` is never used [INFO] [stdout] --> src/pool.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub trait PoolMapExt<'a, 'b, 'c, I, T, F, V> { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 17 | fn pool_map(self, scope: &'a Scope<'b, 'c>, workers: usize, f: F) -> PoolMap [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bittorrent-starter-rust` (bin "bittorrent-starter-rust") due to 10 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bencode.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 277 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Self::Dict(value.into_iter().map(|(k, v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bencode.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 283 | fn from(l: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | Self::List(l.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:173:15 [INFO] [stdout] | [INFO] [stdout] 172 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Bytes(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 49 | active_connection: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | uses: usize, [INFO] [stdout] 51 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / corkboard [INFO] [stdout] 58 | | .write() [INFO] [stdout] 59 | | .map(|mut board| { [INFO] [stdout] 60 | | // If all pieces have been acquired, exit [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 49 | active_connection: Option, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | .map(|mut board| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match active_connection.map(|connection| (connection.address().clone(), connection)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 164 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / corkboard [INFO] [stdout] 171 | | .write() [INFO] [stdout] 172 | | .map(|mut board| { [INFO] [stdout] 173 | | // once there are no unfetched pieces left to acquire, [INFO] [stdout] ... | [INFO] [stdout] 215 | | next_piece [INFO] [stdout] 216 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download/corkboard/worker.rs:239:5 [INFO] [stdout] | [INFO] [stdout] 227 | download_result: Result, T::Error>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | log: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | / corkboard [INFO] [stdout] 240 | | .write() [INFO] [stdout] 241 | | .map(|mut board| { [INFO] [stdout] 242 | | match download_result { [INFO] [stdout] ... | [INFO] [stdout] 329 | | } [INFO] [stdout] 330 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker/multimodal.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 208 | let connection = UdpSocket::bind("0.0.0.0:0") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(UdpTrackerConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | connection: connection, [INFO] [stdout] 218 | | last_connection: None, [INFO] [stdout] 219 | | connection_id: None, [INFO] [stdout] 220 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:258:19 [INFO] [stdout] | [INFO] [stdout] 255 | fn unique(self) -> UniqueIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bittorrent-starter-rust` (bin "bittorrent-starter-rust" test) due to 10 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6e5ab0b0186661a81319128d98df91eb76921b9df97e9c70f3e1fd9ba929f874", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e5ab0b0186661a81319128d98df91eb76921b9df97e9c70f3e1fd9ba929f874", kill_on_drop: false }` [INFO] [stdout] 6e5ab0b0186661a81319128d98df91eb76921b9df97e9c70f3e1fd9ba929f874