[INFO] cloning repository https://github.com/MatthiasvB/concurrent_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MatthiasvB/concurrent_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatthiasvB%2Fconcurrent_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatthiasvB%2Fconcurrent_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c48d30a3929e27f6d34fceab0a9cbf2ddac18dcb [INFO] checking MatthiasvB/concurrent_rust/c48d30a3929e27f6d34fceab0a9cbf2ddac18dcb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatthiasvB%2Fconcurrent_rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MatthiasvB/concurrent_rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MatthiasvB/concurrent_rust [INFO] finished tweaking git repo https://github.com/MatthiasvB/concurrent_rust [INFO] tweaked toml for git repo https://github.com/MatthiasvB/concurrent_rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MatthiasvB/concurrent_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4fa4e72daa92b9c9e02fadb0f824a474fee3e9a632ad88194cf3827d8bf5f88 [INFO] running `Command { std: "docker" "start" "-a" "b4fa4e72daa92b9c9e02fadb0f824a474fee3e9a632ad88194cf3827d8bf5f88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4fa4e72daa92b9c9e02fadb0f824a474fee3e9a632ad88194cf3827d8bf5f88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4fa4e72daa92b9c9e02fadb0f824a474fee3e9a632ad88194cf3827d8bf5f88", kill_on_drop: false }` [INFO] [stdout] b4fa4e72daa92b9c9e02fadb0f824a474fee3e9a632ad88194cf3827d8bf5f88 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4502e438908d0369f06df920f827971a2af5b0355103d5405ede1e6408da30a0 [INFO] running `Command { std: "docker" "start" "-a" "4502e438908d0369f06df920f827971a2af5b0355103d5405ede1e6408da30a0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking concurrent_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:98:39 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|num| tokio::task::spawn(delay_thread_async_then_square(num, num))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:159:28 [INFO] [stdout] | [INFO] [stdout] 158 | let numbers = numbers.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | tokio::task::spawn(cb(num, num, numbers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:346:23 [INFO] [stdout] | [INFO] [stdout] 346 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 393 | let numbers = numbers.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | threads.push(std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 395 | | let vec = numbers.lock().unwrap(); [INFO] [stdout] 396 | | let operand = vec[num]; [INFO] [stdout] 397 | | drop(vec); // to release the lock [INFO] [stdout] ... | [INFO] [stdout] 400 | | vec[num] = res; [INFO] [stdout] 401 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concurrent_rust` (bin "concurrent_rust") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:98:39 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|num| tokio::task::spawn(delay_thread_async_then_square(num, num))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:159:28 [INFO] [stdout] | [INFO] [stdout] 158 | let numbers = numbers.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | tokio::task::spawn(cb(num, num, numbers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:346:23 [INFO] [stdout] | [INFO] [stdout] 346 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 393 | let numbers = numbers.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | threads.push(std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 395 | | let vec = numbers.lock().unwrap(); [INFO] [stdout] 396 | | let operand = vec[num]; [INFO] [stdout] 397 | | drop(vec); // to release the lock [INFO] [stdout] ... | [INFO] [stdout] 400 | | vec[num] = res; [INFO] [stdout] 401 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concurrent_rust` (bin "concurrent_rust" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4502e438908d0369f06df920f827971a2af5b0355103d5405ede1e6408da30a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4502e438908d0369f06df920f827971a2af5b0355103d5405ede1e6408da30a0", kill_on_drop: false }` [INFO] [stdout] 4502e438908d0369f06df920f827971a2af5b0355103d5405ede1e6408da30a0