[INFO] cloning repository https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMathisPeyronne%2FMulti-threaded-chat-server-in-Rust-with-Tokio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMathisPeyronne%2FMulti-threaded-chat-server-in-Rust-with-Tokio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cc5bff61c32307dbf81e53b957802829abea4eac [INFO] checking MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio/cc5bff61c32307dbf81e53b957802829abea4eac against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMathisPeyronne%2FMulti-threaded-chat-server-in-Rust-with-Tokio" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio [INFO] finished tweaking git repo https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio [INFO] tweaked toml for git repo https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MathisPeyronne/Multi-threaded-chat-server-in-Rust-with-Tokio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd2fe9ed50d0b6f842a2a69be7a3b6a8b1277c2ab46102457a59439e6a3cc610 [INFO] running `Command { std: "docker" "start" "-a" "bd2fe9ed50d0b6f842a2a69be7a3b6a8b1277c2ab46102457a59439e6a3cc610", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd2fe9ed50d0b6f842a2a69be7a3b6a8b1277c2ab46102457a59439e6a3cc610", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd2fe9ed50d0b6f842a2a69be7a3b6a8b1277c2ab46102457a59439e6a3cc610", kill_on_drop: false }` [INFO] [stdout] bd2fe9ed50d0b6f842a2a69be7a3b6a8b1277c2ab46102457a59439e6a3cc610 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c996c0b84c833a2549580031a254667cc5bfd6c80f30a4f21ef35b87c88718ba [INFO] running `Command { std: "docker" "start" "-a" "c996c0b84c833a2549580031a254667cc5bfd6c80f30a4f21ef35b87c88718ba", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling regex-syntax v0.6.28 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking pnet_sys v0.32.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling async-trait v0.1.56 [INFO] [stderr] Compiling pnet v0.32.0 [INFO] [stderr] Checking pnet_base v0.32.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking pnet_macros_support v0.32.0 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Compiling aho-corasick v0.7.20 [INFO] [stderr] Compiling regex v1.7.1 [INFO] [stderr] Checking ipnetwork v0.19.0 [INFO] [stderr] Checking pnet_datalink v0.32.0 [INFO] [stderr] Compiling pnet_macros v0.32.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking pnet_packet v0.32.0 [INFO] [stderr] Checking pnet_transport v0.32.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking server_practice v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::server` [INFO] [stdout] --> src/server.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::server; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/server.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::server` [INFO] [stdout] --> src/server.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::server; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/server.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/server.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/server.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::io::AsyncWriteExt` [INFO] [stdout] --> src/server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio::io::AsyncWriteExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::io::AsyncWriteExt` [INFO] [stdout] --> src/server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio::io::AsyncWriteExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration` and `sleep` [INFO] [stdout] --> src/server.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio::time::{sleep, Duration}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration` and `sleep` [INFO] [stdout] --> src/server.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio::time::{sleep, Duration}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncRead` [INFO] [stdout] --> src/server.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 12 | io::{AsyncRead, AsyncReadExt}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncRead` [INFO] [stdout] --> src/server.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 12 | io::{AsyncRead, AsyncReadExt}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/server.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/server.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | pub async fn run(self, mut handler: (impl Handler + Send + Clone + 'static)) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/website_handler.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ipAddr` [INFO] [stdout] --> src/website_handler.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ipAddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `queryString` [INFO] [stdout] --> src/website_handler.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | Some(queryString) => { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_queryString` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_path` [INFO] [stdout] --> src/main.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let default_path = format!("{}\\public", env!("CARGO_MANIFEST_DIR")); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(addr: String, conversationDatabase: Arc>>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 52 | let neww = neww.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let server_addr = self.conversationDatabase.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | match listener.accept().await { [INFO] [stdout] 56 | Ok((mut stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match stream.read(&mut buffer).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/website_handler.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 55 | conversationDatabase: Arc>>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] 57 | ) -> Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 58 | | match request.method() { [INFO] [stdout] 59 | | Method::GET => match request.path() { [INFO] [stdout] 60 | | "/" => Response::new(StatusCode::Ok, self.read_file("index.html")), [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ipAddr` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `ip_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `convDatabase` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let mut convDatabase = conversationDatabase.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `conv_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `queryString` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | Some(queryString) => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `query_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `server_practice` (bin "server_practice") due to 3 previous errors; 19 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | pub async fn run(self, mut handler: (impl Handler + Send + Clone + 'static)) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/website_handler.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ipAddr` [INFO] [stdout] --> src/website_handler.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ipAddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `queryString` [INFO] [stdout] --> src/website_handler.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | Some(queryString) => { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_queryString` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_path` [INFO] [stdout] --> src/main.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let default_path = format!("{}\\public", env!("CARGO_MANIFEST_DIR")); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/server.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(addr: String, conversationDatabase: Arc>>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 52 | let neww = neww.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let server_addr = self.conversationDatabase.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut handler = handler.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | match listener.accept().await { [INFO] [stdout] 56 | Ok((mut stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match stream.read(&mut buffer).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/website_handler.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 55 | conversationDatabase: Arc>>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] 57 | ) -> Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 58 | | match request.method() { [INFO] [stdout] 59 | | Method::GET => match request.path() { [INFO] [stdout] 60 | | "/" => Response::new(StatusCode::Ok, self.read_file("index.html")), [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `conversationDatabase` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | conversationDatabase: Arc>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `conversation_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ipAddr` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | ipAddr: String, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `ip_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `convDatabase` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let mut convDatabase = conversationDatabase.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `conv_database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `queryString` should have a snake case name [INFO] [stdout] --> src/website_handler.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | Some(queryString) => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `query_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `server_practice` (bin "server_practice" test) due to 3 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c996c0b84c833a2549580031a254667cc5bfd6c80f30a4f21ef35b87c88718ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c996c0b84c833a2549580031a254667cc5bfd6c80f30a4f21ef35b87c88718ba", kill_on_drop: false }` [INFO] [stdout] c996c0b84c833a2549580031a254667cc5bfd6c80f30a4f21ef35b87c88718ba