[INFO] cloning repository https://github.com/MartMcMahon/rust_networking_example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MartMcMahon/rust_networking_example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartMcMahon%2Frust_networking_example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartMcMahon%2Frust_networking_example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4ced6b2f51dc20e536f1e09cd977878ae81cee62 [INFO] checking MartMcMahon/rust_networking_example/4ced6b2f51dc20e536f1e09cd977878ae81cee62 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartMcMahon%2Frust_networking_example" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MartMcMahon/rust_networking_example on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MartMcMahon/rust_networking_example [INFO] finished tweaking git repo https://github.com/MartMcMahon/rust_networking_example [INFO] tweaked toml for git repo https://github.com/MartMcMahon/rust_networking_example written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MartMcMahon/rust_networking_example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43bdcaf361de20bf3d6826a111bf67856686ef0bae543beef52ce43755ce42dd [INFO] running `Command { std: "docker" "start" "-a" "43bdcaf361de20bf3d6826a111bf67856686ef0bae543beef52ce43755ce42dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43bdcaf361de20bf3d6826a111bf67856686ef0bae543beef52ce43755ce42dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43bdcaf361de20bf3d6826a111bf67856686ef0bae543beef52ce43755ce42dd", kill_on_drop: false }` [INFO] [stdout] 43bdcaf361de20bf3d6826a111bf67856686ef0bae543beef52ce43755ce42dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9070e4c5f9c2ac9565c508f5a5c1264426ffa24a8c4cac66cfce85420406d9f7 [INFO] running `Command { std: "docker" "start" "-a" "9070e4c5f9c2ac9565c508f5a5c1264426ffa24a8c4cac66cfce85420406d9f7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.106 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling tokio v1.13.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling tokio-macros v1.5.1 [INFO] [stderr] Checking rust_networking_example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufReader` and `sync::broadcast` [INFO] [stdout] --> src/client/main.rs:2:56 [INFO] [stdout] | [INFO] [stdout] 2 | io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 3 | net::TcpStream, [INFO] [stdout] 4 | sync::broadcast, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncBufReadExt` [INFO] [stdout] --> src/client/main.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `sync::broadcast` [INFO] [stdout] --> src/client/main.rs:2:56 [INFO] [stdout] | [INFO] [stdout] 2 | io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 3 | net::TcpStream, [INFO] [stdout] 4 | sync::broadcast, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncBufReadExt` [INFO] [stdout] --> src/client/main.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 15 | || let mut input_buf = [0_u8; 10]; [INFO] [stdout] 16 | || let mut stdin = tokio::io::stdin(); [INFO] [stdout] 17 | || let n = stdin.read(&mut input_buf).await.unwrap(); [INFO] [stdout] ... || [INFO] [stdout] 24 | || println!("{:?} {:?}", line, len); [INFO] [stdout] 25 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 15 | || let mut input_buf = [0_u8; 10]; [INFO] [stdout] 16 | || let mut stdin = tokio::io::stdin(); [INFO] [stdout] 17 | || let n = stdin.read(&mut input_buf).await.unwrap(); [INFO] [stdout] ... || [INFO] [stdout] 24 | || println!("{:?} {:?}", line, len); [INFO] [stdout] 25 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_networking_example` (bin "client" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust_networking_example` (bin "client") due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: unused variable: `other_addr` [INFO] [stdout] --> src/server/main.rs:35:39 [INFO] [stdout] | [INFO] [stdout] 35 | let (mut msg, other_addr) = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_other_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other_addr` [INFO] [stdout] --> src/server/main.rs:35:39 [INFO] [stdout] | [INFO] [stdout] 35 | let (mut msg, other_addr) = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_other_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/main.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | let (mut msg, other_addr) = result.unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 14 | || let (mut socket, addr) = listener.accept().await.unwrap(); [INFO] [stdout] 15 | || [INFO] [stdout] 16 | || let tx = tx.clone(); [INFO] [stdout] ... || [INFO] [stdout] 45 | || }); [INFO] [stdout] 46 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/main.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | let (mut msg, other_addr) = result.unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_networking_example` (bin "server" test) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | loop { [INFO] [stdout] | _____^ - [INFO] [stdout] | |__________| [INFO] [stdout] 14 | || let (mut socket, addr) = listener.accept().await.unwrap(); [INFO] [stdout] 15 | || [INFO] [stdout] 16 | || let tx = tx.clone(); [INFO] [stdout] ... || [INFO] [stdout] 45 | || }); [INFO] [stdout] 46 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_networking_example` (bin "server") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9070e4c5f9c2ac9565c508f5a5c1264426ffa24a8c4cac66cfce85420406d9f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9070e4c5f9c2ac9565c508f5a5c1264426ffa24a8c4cac66cfce85420406d9f7", kill_on_drop: false }` [INFO] [stdout] 9070e4c5f9c2ac9565c508f5a5c1264426ffa24a8c4cac66cfce85420406d9f7