[INFO] cloning repository https://github.com/MarshallRawson/plotmux [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MarshallRawson/plotmux" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarshallRawson%2Fplotmux", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarshallRawson%2Fplotmux'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ea77e832d8b52e344e444cf5958bc1153c1ccc7f [INFO] checking MarshallRawson/plotmux/ea77e832d8b52e344e444cf5958bc1153c1ccc7f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarshallRawson%2Fplotmux" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MarshallRawson/plotmux on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MarshallRawson/plotmux [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/MarshallRawson/plotmux [INFO] tweaked toml for git repo https://github.com/MarshallRawson/plotmux written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MarshallRawson/plotmux already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62aa993f7a5af1a0a654062a6ee7ee59019b822d5435167f5c6dbe719cb94a2f [INFO] running `Command { std: "docker" "start" "-a" "62aa993f7a5af1a0a654062a6ee7ee59019b822d5435167f5c6dbe719cb94a2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62aa993f7a5af1a0a654062a6ee7ee59019b822d5435167f5c6dbe719cb94a2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62aa993f7a5af1a0a654062a6ee7ee59019b822d5435167f5c6dbe719cb94a2f", kill_on_drop: false }` [INFO] [stdout] 62aa993f7a5af1a0a654062a6ee7ee59019b822d5435167f5c6dbe719cb94a2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c10152f9d5e08a138388580f60c32be19cc9e55f74c53310c0a416a9b8a618ee [INFO] running `Command { std: "docker" "start" "-a" "c10152f9d5e08a138388580f60c32be19cc9e55f74c53310c0a416a9b8a618ee", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling built v0.7.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking bitstream-io v2.2.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking zune-jpeg v0.4.11 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Compiling tinyfiledialogs v3.9.1 [INFO] [stderr] Checking defer v0.2.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking image-webp v0.1.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ravif v0.11.5 [INFO] [stderr] Checking image v0.25.1 [INFO] [stderr] Checking plotmux v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotmux.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 239 | let client = make_client(png_path, &self.mode); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | println!("make ready!"); [INFO] [stdout] 241 | let join_handle = thread::Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | defer(|| join_handle.join().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotmux.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 241 | let join_handle = thread::Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | defer(|| join_handle.join().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotsink.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 41 | let pipe = bounded(100); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (port, tcp_thread) = make_tcp_sender(idx, name.clone(), addr, pipe.1.clone(), ports); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ( [INFO] [stdout] 44 | / Self { [INFO] [stdout] 45 | | name: (color, name), [INFO] [stdout] 46 | | pipe: pipe, [INFO] [stdout] 47 | | start: start, [INFO] [stdout] ... | [INFO] [stdout] 52 | | image_plots: HashMap::new(), [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotsink.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 240 | fn make_tcp_sender(idx: usize, name: String, addr: String, recv: PlotReceiver, ports: &Option<(u16, u16)>) -> (u16, JoinHandle<()>) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let listener = if let Some(ports) = ports { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let mut listener = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | / thread::Builder::new() [INFO] [stdout] 260 | | .name(thread_name) [INFO] [stdout] 261 | | .spawn(move || { [INFO] [stdout] 262 | | if let Ok((mut stream, _)) = listener.accept() { [INFO] [stdout] ... | [INFO] [stdout] 275 | | }) [INFO] [stdout] 276 | | .expect(&exp) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotmux.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 239 | let client = make_client(png_path, &self.mode); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | println!("make ready!"); [INFO] [stdout] 241 | let join_handle = thread::Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | defer(|| join_handle.join().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotmux.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 241 | let join_handle = thread::Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | defer(|| join_handle.join().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotsink.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 41 | let pipe = bounded(100); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let (port, tcp_thread) = make_tcp_sender(idx, name.clone(), addr, pipe.1.clone(), ports); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ( [INFO] [stdout] 44 | / Self { [INFO] [stdout] 45 | | name: (color, name), [INFO] [stdout] 46 | | pipe: pipe, [INFO] [stdout] 47 | | start: start, [INFO] [stdout] ... | [INFO] [stdout] 52 | | image_plots: HashMap::new(), [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plotsink.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 240 | fn make_tcp_sender(idx: usize, name: String, addr: String, recv: PlotReceiver, ports: &Option<(u16, u16)>) -> (u16, JoinHandle<()>) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let listener = if let Some(ports) = ports { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let mut listener = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | / thread::Builder::new() [INFO] [stdout] 260 | | .name(thread_name) [INFO] [stdout] 261 | | .spawn(move || { [INFO] [stdout] 262 | | if let Ok((mut stream, _)) = listener.accept() { [INFO] [stdout] ... | [INFO] [stdout] 275 | | }) [INFO] [stdout] 276 | | .expect(&exp) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plotmux` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `plotmux` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c10152f9d5e08a138388580f60c32be19cc9e55f74c53310c0a416a9b8a618ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c10152f9d5e08a138388580f60c32be19cc9e55f74c53310c0a416a9b8a618ee", kill_on_drop: false }` [INFO] [stdout] c10152f9d5e08a138388580f60c32be19cc9e55f74c53310c0a416a9b8a618ee