[INFO] cloning repository https://github.com/Markaronin/space-trader [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Markaronin/space-trader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkaronin%2Fspace-trader", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkaronin%2Fspace-trader'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ae2ab942d34a0d5d6b9cdbf2462dba4ddb27fe09 [INFO] checking Markaronin/space-trader/ae2ab942d34a0d5d6b9cdbf2462dba4ddb27fe09 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkaronin%2Fspace-trader" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Markaronin/space-trader on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Markaronin/space-trader [INFO] finished tweaking git repo https://github.com/Markaronin/space-trader [INFO] tweaked toml for git repo https://github.com/Markaronin/space-trader written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Markaronin/space-trader already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 583ee18a416824bff1e2c896d7b1149a7cc0c3c46b034b9a4d5237a4d6682dea [INFO] running `Command { std: "docker" "start" "-a" "583ee18a416824bff1e2c896d7b1149a7cc0c3c46b034b9a4d5237a4d6682dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "583ee18a416824bff1e2c896d7b1149a7cc0c3c46b034b9a4d5237a4d6682dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "583ee18a416824bff1e2c896d7b1149a7cc0c3c46b034b9a4d5237a4d6682dea", kill_on_drop: false }` [INFO] [stdout] 583ee18a416824bff1e2c896d7b1149a7cc0c3c46b034b9a4d5237a4d6682dea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b9e023bb20537ca4a0e9481b9988f825339e1268a01a52a9af10cd447c29b24 [INFO] running `Command { std: "docker" "start" "-a" "4b9e023bb20537ca4a0e9481b9988f825339e1268a01a52a9af10cd447c29b24", kill_on_drop: false }` [INFO] [stderr] Checking space-trader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `trade_good` [INFO] [stdout] --> src/main.rs:68:30 [INFO] [stdout] | [INFO] [stdout] 68 | gui::Action::Buy(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trade_good` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amount` [INFO] [stdout] --> src/main.rs:68:42 [INFO] [stdout] | [INFO] [stdout] 68 | gui::Action::Buy(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `trade_good` [INFO] [stdout] --> src/main.rs:69:31 [INFO] [stdout] | [INFO] [stdout] 69 | gui::Action::Sell(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trade_good` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amount` [INFO] [stdout] --> src/main.rs:69:43 [INFO] [stdout] | [INFO] [stdout] 69 | gui::Action::Sell(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut planets = Planets::new(NUM_PLANETS); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `money` are never read [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 47 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | money: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `AVERAGE_CONNECTIONS_PER_PLANET` is never used [INFO] [stdout] --> src/consts.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | pub const AVERAGE_CONNECTIONS_PER_PLANET: usize = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | let mut lines = stdin.lock().lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | lines.next().unwrap().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `space-trader` (bin "space-trader" test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `trade_good` [INFO] [stdout] --> src/main.rs:68:30 [INFO] [stdout] | [INFO] [stdout] 68 | gui::Action::Buy(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trade_good` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amount` [INFO] [stdout] --> src/main.rs:68:42 [INFO] [stdout] | [INFO] [stdout] 68 | gui::Action::Buy(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `trade_good` [INFO] [stdout] --> src/main.rs:69:31 [INFO] [stdout] | [INFO] [stdout] 69 | gui::Action::Sell(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trade_good` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amount` [INFO] [stdout] --> src/main.rs:69:43 [INFO] [stdout] | [INFO] [stdout] 69 | gui::Action::Sell(trade_good, amount) => println!("Trading"), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut planets = Planets::new(NUM_PLANETS); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `money` are never read [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 47 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | money: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `space-trader` (bin "space-trader") due to 2 previous errors; 7 warnings emitted [INFO] [stdout] warning: constant `AVERAGE_CONNECTIONS_PER_PLANET` is never used [INFO] [stdout] --> src/consts.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | pub const AVERAGE_CONNECTIONS_PER_PLANET: usize = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | let mut lines = stdin.lock().lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | lines.next().unwrap().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4b9e023bb20537ca4a0e9481b9988f825339e1268a01a52a9af10cd447c29b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b9e023bb20537ca4a0e9481b9988f825339e1268a01a52a9af10cd447c29b24", kill_on_drop: false }` [INFO] [stdout] 4b9e023bb20537ca4a0e9481b9988f825339e1268a01a52a9af10cd447c29b24