[INFO] cloning repository https://github.com/Mandragorian/i3-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mandragorian/i3-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Fi3-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Fi3-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c184251f17ba3080b4df829ee885d94ff3064df8 [INFO] checking Mandragorian/i3-tools/c184251f17ba3080b4df829ee885d94ff3064df8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Fi3-tools" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Mandragorian/i3-tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Mandragorian/i3-tools [INFO] finished tweaking git repo https://github.com/Mandragorian/i3-tools [INFO] tweaked toml for git repo https://github.com/Mandragorian/i3-tools written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Mandragorian/i3-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16f39d8ad70dadc2b7b91b9c452c359c91b16c4e915e7d47dcf2a9a1d35800d8 [INFO] running `Command { std: "docker" "start" "-a" "16f39d8ad70dadc2b7b91b9c452c359c91b16c4e915e7d47dcf2a9a1d35800d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16f39d8ad70dadc2b7b91b9c452c359c91b16c4e915e7d47dcf2a9a1d35800d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16f39d8ad70dadc2b7b91b9c452c359c91b16c4e915e7d47dcf2a9a1d35800d8", kill_on_drop: false }` [INFO] [stdout] 16f39d8ad70dadc2b7b91b9c452c359c91b16c4e915e7d47dcf2a9a1d35800d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2dbf5aca4728675ee4397282e90bc8210928f170ab0d9486a1593f029f89454 [INFO] running `Command { std: "docker" "start" "-a" "d2dbf5aca4728675ee4397282e90bc8210928f170ab0d9486a1593f029f89454", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling libc v0.2.46 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling serde v1.0.84 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking dtoa v0.4.3 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking yaml-rust v0.4.2 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking glib v0.6.1 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking i3utils v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/gtk.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 25 | impl Header { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 26 | fn new() -> Header { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/gtk.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 25 | impl Header { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 26 | fn new() -> Header { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | fn run(&self) -> Result>, String>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | fn run(&self) -> Result>, String>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:55:40 [INFO] [stdout] | [INFO] [stdout] 55 | options: LinkedHashMap>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 55 | options: LinkedHashMap>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | type FnBuild = Fn(&serde_yaml::Value) -> Result, String>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | type FnBuild = dyn Fn(&serde_yaml::Value) -> Result, String>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:39:41 [INFO] [stdout] | [INFO] [stdout] 39 | fn run(&self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | fn run(&self) -> Result>, String> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | fn run(&self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 82 | fn run(&self) -> Result>, String> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:62:44 [INFO] [stdout] | [INFO] [stdout] 62 | options: LinkedHashMap>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | options: LinkedHashMap>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | fn run(&self) -> Result>, String>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | fn run(&self) -> Result>, String>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:55:40 [INFO] [stdout] | [INFO] [stdout] 55 | options: LinkedHashMap>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 55 | options: LinkedHashMap>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | type FnBuild = Fn(&serde_yaml::Value) -> Result, String>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | type FnBuild = dyn Fn(&serde_yaml::Value) -> Result, String>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:39:41 [INFO] [stdout] | [INFO] [stdout] 39 | fn run(&self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | fn run(&self) -> Result>, String> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | fn run(&self) -> Result>, String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 82 | fn run(&self) -> Result>, String> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rmenu.rs:62:44 [INFO] [stdout] | [INFO] [stdout] 62 | options: LinkedHashMap>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | options: LinkedHashMap>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/rmenu.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct RofiMenu { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 50 | /// The name of the `RofiMenu`. [INFO] [stdout] 51 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/rmenu.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct RofiMenu { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 50 | /// The name of the `RofiMenu`. [INFO] [stdout] 51 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_subbuilder` is never used [INFO] [stdout] --> src/rmenu.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 129 | impl Builder { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 136 | pub fn add_subbuilder(&mut self, type_str: String, subbuilder: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rmenu.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut option_map = LinkedHashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Box::new(RofiMenu::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | String::from(name), [INFO] [stdout] 172 | | String::from(prompt), [INFO] [stdout] 173 | | option_map, [INFO] [stdout] 174 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_subbuilder` is never used [INFO] [stdout] --> src/rmenu.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 129 | impl Builder { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 136 | pub fn add_subbuilder(&mut self, type_str: String, subbuilder: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rmenu.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut option_map = LinkedHashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Box::new(RofiMenu::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | String::from(name), [INFO] [stdout] 172 | | String::from(prompt), [INFO] [stdout] 173 | | option_map, [INFO] [stdout] 174 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `i3utils` (bin "rmenu" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `i3utils` (bin "rmenu") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d2dbf5aca4728675ee4397282e90bc8210928f170ab0d9486a1593f029f89454", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2dbf5aca4728675ee4397282e90bc8210928f170ab0d9486a1593f029f89454", kill_on_drop: false }` [INFO] [stdout] d2dbf5aca4728675ee4397282e90bc8210928f170ab0d9486a1593f029f89454