[INFO] cloning repository https://github.com/Majavar/map-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Majavar/map-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajavar%2Fmap-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajavar%2Fmap-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7ce4c0ea9c91a987849d1f8342472afb5624074 [INFO] checking Majavar/map-generator/a7ce4c0ea9c91a987849d1f8342472afb5624074 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajavar%2Fmap-generator" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Majavar/map-generator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Majavar/map-generator [INFO] finished tweaking git repo https://github.com/Majavar/map-generator [INFO] tweaked toml for git repo https://github.com/Majavar/map-generator written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Majavar/map-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76507e3217068777eb73e16f914831f0b004512218116018074061ce7a4182ee [INFO] running `Command { std: "docker" "start" "-a" "76507e3217068777eb73e16f914831f0b004512218116018074061ce7a4182ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76507e3217068777eb73e16f914831f0b004512218116018074061ce7a4182ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76507e3217068777eb73e16f914831f0b004512218116018074061ce7a4182ee", kill_on_drop: false }` [INFO] [stdout] 76507e3217068777eb73e16f914831f0b004512218116018074061ce7a4182ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88763c2e688bf56a4dcb2c5bba57aa874535b92508bc135fac5397a1e2944ff9 [INFO] running `Command { std: "docker" "start" "-a" "88763c2e688bf56a4dcb2c5bba57aa874535b92508bc135fac5397a1e2944ff9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking inflate v0.1.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Compiling derive_builder v0.4.7 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling derive_builder_core v0.1.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking noise2d v0.1.0 (/opt/rustwide/workdir/noise2d) [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking heightmap v0.1.0 (/opt/rustwide/workdir/heightmap) [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking serde_yaml v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking image v0.1.0 (/opt/rustwide/workdir/image) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> image/src/shade.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | (self.get(x + 1, y) - self.get(x - 1, y)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - (self.get(x + 1, y) - self.get(x - 1, y)) [INFO] [stdout] 60 + self.get(x + 1, y) - self.get(x - 1, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> image/src/shade.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | (self.get(x, y + 1) - self.get(x, y - 1)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - (self.get(x, y + 1) - self.get(x, y - 1)) [INFO] [stdout] 68 + self.get(x, y + 1) - self.get(x, y - 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color.rs:38:35 [INFO] [stdout] | [INFO] [stdout] 38 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color_ramp.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color_ramp.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color_ramp.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/color_ramp.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/shade.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/shade.rs:40:35 [INFO] [stdout] | [INFO] [stdout] 40 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> image/src/shade.rs:43:35 [INFO] [stdout] | [INFO] [stdout] 43 | .unwrap_or_else(||Err(D::Error::custom("missing value")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `image` (lib) due to 11 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "88763c2e688bf56a4dcb2c5bba57aa874535b92508bc135fac5397a1e2944ff9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88763c2e688bf56a4dcb2c5bba57aa874535b92508bc135fac5397a1e2944ff9", kill_on_drop: false }` [INFO] [stdout] 88763c2e688bf56a4dcb2c5bba57aa874535b92508bc135fac5397a1e2944ff9