[INFO] cloning repository https://github.com/MJDSys/bcache-recovery [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MJDSys/bcache-recovery" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJDSys%2Fbcache-recovery", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJDSys%2Fbcache-recovery'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ea435c2f3ac912202f15275dc2a13a43f6fb4ddd [INFO] checking MJDSys/bcache-recovery/ea435c2f3ac912202f15275dc2a13a43f6fb4ddd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJDSys%2Fbcache-recovery" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MJDSys/bcache-recovery on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MJDSys/bcache-recovery [INFO] finished tweaking git repo https://github.com/MJDSys/bcache-recovery [INFO] tweaked toml for git repo https://github.com/MJDSys/bcache-recovery written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MJDSys/bcache-recovery already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 407fc8024c4bb2c6be629100414ae44c87ce1539b5a3cc93d9520707b80a88ba [INFO] running `Command { std: "docker" "start" "-a" "407fc8024c4bb2c6be629100414ae44c87ce1539b5a3cc93d9520707b80a88ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "407fc8024c4bb2c6be629100414ae44c87ce1539b5a3cc93d9520707b80a88ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "407fc8024c4bb2c6be629100414ae44c87ce1539b5a3cc93d9520707b80a88ba", kill_on_drop: false }` [INFO] [stdout] 407fc8024c4bb2c6be629100414ae44c87ce1539b5a3cc93d9520707b80a88ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16139bcdcb1f0bed47eb8b54555672d5a85e5e6d2d7b6492f6ecbf9b904bb26f [INFO] running `Command { std: "docker" "start" "-a" "16139bcdcb1f0bed47eb8b54555672d5a85e5e6d2d7b6492f6ecbf9b904bb26f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking bcache-recovery v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:940:12 [INFO] [stdout] | [INFO] [stdout] 939 | fn new(sb: BCacheSB, backing_file: File) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 940 | Ok(BCacheBacking { [INFO] [stdout] | ____________^ [INFO] [stdout] 941 | | data_offset: 16, [INFO] [stdout] 942 | | flags: sb.flags.into(), [INFO] [stdout] 943 | | sb, [INFO] [stdout] 944 | | backing_file, [INFO] [stdout] 945 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:960:8 [INFO] [stdout] | [INFO] [stdout] 955 | let mut f = File::open(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | Ok(if sb.is_cache() { [INFO] [stdout] | ________^ [INFO] [stdout] 961 | | BCacheDev::Cache(BCacheCache::new(sb, data, f)?) [INFO] [stdout] 962 | | } else { [INFO] [stdout] 963 | | drop(f); [INFO] [stdout] 964 | | let f = OpenOptions::new().read(true).write(true).open(path)?; [INFO] [stdout] 965 | | BCacheDev::Backing(BCacheBacking::new(sb, f)?) [INFO] [stdout] 966 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcache-recovery` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:940:12 [INFO] [stdout] | [INFO] [stdout] 939 | fn new(sb: BCacheSB, backing_file: File) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 940 | Ok(BCacheBacking { [INFO] [stdout] | ____________^ [INFO] [stdout] 941 | | data_offset: 16, [INFO] [stdout] 942 | | flags: sb.flags.into(), [INFO] [stdout] 943 | | sb, [INFO] [stdout] 944 | | backing_file, [INFO] [stdout] 945 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:960:8 [INFO] [stdout] | [INFO] [stdout] 955 | let mut f = File::open(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | Ok(if sb.is_cache() { [INFO] [stdout] | ________^ [INFO] [stdout] 961 | | BCacheDev::Cache(BCacheCache::new(sb, data, f)?) [INFO] [stdout] 962 | | } else { [INFO] [stdout] 963 | | drop(f); [INFO] [stdout] 964 | | let f = OpenOptions::new().read(true).write(true).open(path)?; [INFO] [stdout] 965 | | BCacheDev::Backing(BCacheBacking::new(sb, f)?) [INFO] [stdout] 966 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcache-recovery` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "16139bcdcb1f0bed47eb8b54555672d5a85e5e6d2d7b6492f6ecbf9b904bb26f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16139bcdcb1f0bed47eb8b54555672d5a85e5e6d2d7b6492f6ecbf9b904bb26f", kill_on_drop: false }` [INFO] [stdout] 16139bcdcb1f0bed47eb8b54555672d5a85e5e6d2d7b6492f6ecbf9b904bb26f