[INFO] cloning repository https://github.com/MIDAV0/pngme [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MIDAV0/pngme" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMIDAV0%2Fpngme", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMIDAV0%2Fpngme'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b8282de0bc5162a6349626087705844dccc1876c [INFO] checking MIDAV0/pngme/b8282de0bc5162a6349626087705844dccc1876c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMIDAV0%2Fpngme" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MIDAV0/pngme on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MIDAV0/pngme [INFO] finished tweaking git repo https://github.com/MIDAV0/pngme [INFO] tweaked toml for git repo https://github.com/MIDAV0/pngme written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MIDAV0/pngme already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2010deca096bd9e9644c7f07ae01bfef1de5a3b56c6c4f42c85ba27191eede7b [INFO] running `Command { std: "docker" "start" "-a" "2010deca096bd9e9644c7f07ae01bfef1de5a3b56c6c4f42c85ba27191eede7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2010deca096bd9e9644c7f07ae01bfef1de5a3b56c6c4f42c85ba27191eede7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2010deca096bd9e9644c7f07ae01bfef1de5a3b56c6c4f42c85ba27191eede7b", kill_on_drop: false }` [INFO] [stdout] 2010deca096bd9e9644c7f07ae01bfef1de5a3b56c6c4f42c85ba27191eede7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55a349fa2f6f9da2b01ead1a69a826e0ed81d858c27d7725c8c65d33ad8370d5 [INFO] running `Command { std: "docker" "start" "-a" "55a349fa2f6f9da2b01ead1a69a826e0ed81d858c27d7725c8c65d33ad8370d5", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking pngme v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::chunk_type::ChunkType` [INFO] [stdout] --> src/args.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::chunk_type::ChunkType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::chunk_type::ChunkType` [INFO] [stdout] --> src/args.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::chunk_type::ChunkType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `str::from_utf8` [INFO] [stdout] --> src/chunk.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{convert::TryFrom, str::from_utf8}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chunk_type` [INFO] [stdout] --> src/chunk.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{chunk_type, Error, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/commands.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `str::from_utf8` [INFO] [stdout] --> src/png.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{convert::TryFrom, str::from_utf8}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chunk_type` [INFO] [stdout] --> src/png.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{chunk::Chunk, chunk_type, Error, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `str::from_utf8` [INFO] [stdout] --> src/chunk.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{convert::TryFrom, str::from_utf8}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chunk_type` [INFO] [stdout] --> src/chunk.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{chunk_type, Error, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/commands.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `str::from_utf8` [INFO] [stdout] --> src/png.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{convert::TryFrom, str::from_utf8}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chunk_type` [INFO] [stdout] --> src/png.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{chunk::Chunk, chunk_type, Error, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/png.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/png.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | File::create(path).map_err(|e| PngError::boxed(format!("Error creating file")))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/png.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | .map_err(|e| PngError::boxed(format!("Error writing to file")))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_valid`, `is_critical`, `is_public`, `is_reserved_bit_valid`, and `is_safe_to_copy` are never used [INFO] [stdout] --> src/chunk_type.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl ChunkType { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn is_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn is_critical(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | pub fn is_public(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | pub fn is_reserved_bit_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn is_safe_to_copy(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `chunks` is never used [INFO] [stdout] --> src/png.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 72 | impl Png { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn chunks(&self) -> &[Chunk] { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/chunk.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | reader.read_exact(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = reader.read_exact(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/chunk.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | reader.read_exact(&mut chunk_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 62 | let _ = reader.read_exact(&mut chunk_data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/commands.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | png.remove_chunk(&args.chunk_type); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = png.remove_chunk(&args.chunk_type); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:85:46 [INFO] [stdout] | [INFO] [stdout] 85 | .position(|c| *c.chunk_type() == ChunkType::from_str(chunk_type).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:105:56 [INFO] [stdout] | [INFO] [stdout] 105 | self.chunks.iter().find(|c| *c.chunk_type() == ChunkType::from_str(chunk_type).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pngme` (bin "pngme") due to 3 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/png.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | File::create(path).map_err(|e| PngError::boxed(format!("Error creating file")))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/png.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | .map_err(|e| PngError::boxed(format!("Error writing to file")))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/chunk.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | reader.read_exact(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = reader.read_exact(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/chunk.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | reader.read_exact(&mut chunk_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 62 | let _ = reader.read_exact(&mut chunk_data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/commands.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | png.remove_chunk(&args.chunk_type); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = png.remove_chunk(&args.chunk_type); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:85:46 [INFO] [stdout] | [INFO] [stdout] 85 | .position(|c| *c.chunk_type() == ChunkType::from_str(chunk_type).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/png.rs:105:56 [INFO] [stdout] | [INFO] [stdout] 105 | self.chunks.iter().find(|c| *c.chunk_type() == ChunkType::from_str(chunk_type).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pngme` (bin "pngme" test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "55a349fa2f6f9da2b01ead1a69a826e0ed81d858c27d7725c8c65d33ad8370d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55a349fa2f6f9da2b01ead1a69a826e0ed81d858c27d7725c8c65d33ad8370d5", kill_on_drop: false }` [INFO] [stdout] 55a349fa2f6f9da2b01ead1a69a826e0ed81d858c27d7725c8c65d33ad8370d5