[INFO] cloning repository https://github.com/MGibson1/pigeonhole [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MGibson1/pigeonhole" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMGibson1%2Fpigeonhole", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMGibson1%2Fpigeonhole'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 23e259eda1a79411f6d87eaff1a8ff4bcd42d69c [INFO] checking MGibson1/pigeonhole/23e259eda1a79411f6d87eaff1a8ff4bcd42d69c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMGibson1%2Fpigeonhole" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MGibson1/pigeonhole on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MGibson1/pigeonhole [INFO] finished tweaking git repo https://github.com/MGibson1/pigeonhole [INFO] tweaked toml for git repo https://github.com/MGibson1/pigeonhole written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MGibson1/pigeonhole already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58b04925a53ef1863c995cc64e8253b448aa3102090b3c31c348f6d33e35ea02 [INFO] running `Command { std: "docker" "start" "-a" "58b04925a53ef1863c995cc64e8253b448aa3102090b3c31c348f6d33e35ea02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58b04925a53ef1863c995cc64e8253b448aa3102090b3c31c348f6d33e35ea02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58b04925a53ef1863c995cc64e8253b448aa3102090b3c31c348f6d33e35ea02", kill_on_drop: false }` [INFO] [stdout] 58b04925a53ef1863c995cc64e8253b448aa3102090b3c31c348f6d33e35ea02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f3a49b85e5e48aac89dcab92f47f31801d1be495cbbf12f20cd83fa39e5592f [INFO] running `Command { std: "docker" "start" "-a" "7f3a49b85e5e48aac89dcab92f47f31801d1be495cbbf12f20cd83fa39e5592f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking derivation-path v0.2.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking sha256 v1.5.0 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ed25519-dalek-bip32 v0.3.0 [INFO] [stderr] Checking pigeonhole v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `EncryptedChunk` is more private than the item `ChunkKey::encrypt` [INFO] [stdout] --> src/crypto/aead/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | fn encrypt(&self, data: &[u8]) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ChunkKey::encrypt` is reachable at visibility `pub(crypto)` [INFO] [stdout] | [INFO] [stdout] note: but type `EncryptedChunk` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/crypto/aead/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | struct EncryptedChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EncryptedChunk` is more private than the item `ChunkKey::decrypt` [INFO] [stdout] --> src/crypto/aead/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | fn decrypt(&self, data: &EncryptedChunk) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ChunkKey::decrypt` is reachable at visibility `pub(crypto)` [INFO] [stdout] | [INFO] [stdout] note: but type `EncryptedChunk` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/crypto/aead/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | struct EncryptedChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_prk` is never used [INFO] [stdout] --> src/crypto/mod.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn generate_prk(ikm: String) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SymmetricEncryptionKey` is never used [INFO] [stdout] --> src/crypto/aead/mod.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | enum SymmetricEncryptionKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `generate_for`, `key_for`, `encrypt`, and `decrypt` are never used [INFO] [stdout] --> src/crypto/aead/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub trait ChunkKey { [INFO] [stdout] | -------- associated items in this trait [INFO] [stdout] ... [INFO] [stdout] 49 | fn generate_for( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | fn key_for(self, chunk_id: u64) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 58 | fn encrypt(&self, data: &[u8]) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 59 | fn decrypt(&self, data: &EncryptedChunk) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/crypto/aead/mod.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl EncryptedChunk { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 70 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FileDecryptor` is never constructed [INFO] [stdout] --> src/crypto/aead/mod.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | struct FileDecryptor { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/crypto/aead/mod.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 133 | impl FileDecryptor { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 134 | fn new(prk: Zeroing<[u8; 32]>, data: &[u8]) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `aad` is never used [INFO] [stdout] --> src/crypto/aead/aes_gcm.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | impl AesGcmKey { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 42 | fn aad(file_id: Uuid) -> Vec { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsymmetricCryptoKey` is never used [INFO] [stdout] --> src/crypto/asym/mod.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | trait AsymmetricCryptoKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `ClassicalSigningKeyPair` is never used [INFO] [stdout] --> src/crypto/asym/ed25519.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) type ClassicalSigningKeyPair = ExtendedSigningKey; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate` is never used [INFO] [stdout] --> src/crypto/asym/ed25519.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn generate(prk: Zeroing<[u8; 32]>) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidChunkId`, `InvalidFileId`, and `WrongEncryptionType` are never constructed [INFO] [stdout] --> src/error.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub enum SymmetricKeyError { [INFO] [stdout] | ----------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 54 | InvalidChunkId, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 55 | #[error("Invalid file id")] [INFO] [stdout] 56 | InvalidFileId, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | WrongEncryptionType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SymmetricKeyError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_reader.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let file = File::open(path).map_err(Error::from)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { reader, buf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/aead/mod.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 134 | fn new(prk: Zeroing<[u8; 32]>, data: &[u8]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let encrypted_chunk = EncryptedChunk::parse(data)?; [INFO] [stdout] 136 | let key = match encrypted_chunk.encryption_type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | key, [INFO] [stdout] 145 | | encrypted_chunk, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/aead/aes_gcm.rs:109:24 [INFO] [stdout] | [INFO] [stdout] 108 | fn key_for(self, chunk_id: u64) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | super::key_for(Box::pin(self), chunk_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/asym/ed25519.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn generate(prk: Zeroing<[u8; 32]>) -> Result> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok(Box::pin( [INFO] [stdout] | ________^ [INFO] [stdout] 13 | | ExtendedSigningKey::from_seed(&*prk).map_err(Error::from)?, [INFO] [stdout] 14 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pigeonhole` (lib) due to 5 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: type `EncryptedChunk` is more private than the item `ChunkKey::encrypt` [INFO] [stdout] --> src/crypto/aead/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | fn encrypt(&self, data: &[u8]) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ChunkKey::encrypt` is reachable at visibility `pub(crypto)` [INFO] [stdout] | [INFO] [stdout] note: but type `EncryptedChunk` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/crypto/aead/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | struct EncryptedChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EncryptedChunk` is more private than the item `ChunkKey::decrypt` [INFO] [stdout] --> src/crypto/aead/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | fn decrypt(&self, data: &EncryptedChunk) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ChunkKey::decrypt` is reachable at visibility `pub(crypto)` [INFO] [stdout] | [INFO] [stdout] note: but type `EncryptedChunk` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/crypto/aead/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | struct EncryptedChunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SymmetricEncryptionKey` is never used [INFO] [stdout] --> src/crypto/aead/mod.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | enum SymmetricEncryptionKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `generate_for`, `key_for`, `encrypt`, and `decrypt` are never used [INFO] [stdout] --> src/crypto/aead/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub trait ChunkKey { [INFO] [stdout] | -------- associated items in this trait [INFO] [stdout] ... [INFO] [stdout] 49 | fn generate_for( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | fn key_for(self, chunk_id: u64) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 58 | fn encrypt(&self, data: &[u8]) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 59 | fn decrypt(&self, data: &EncryptedChunk) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/crypto/aead/mod.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl EncryptedChunk { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 70 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub fn to_bytes(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FileDecryptor` is never constructed [INFO] [stdout] --> src/crypto/aead/mod.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | struct FileDecryptor { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/crypto/aead/mod.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 133 | impl FileDecryptor { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 134 | fn new(prk: Zeroing<[u8; 32]>, data: &[u8]) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `aad` is never used [INFO] [stdout] --> src/crypto/aead/aes_gcm.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | impl AesGcmKey { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 42 | fn aad(file_id: Uuid) -> Vec { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsymmetricCryptoKey` is never used [INFO] [stdout] --> src/crypto/asym/mod.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | trait AsymmetricCryptoKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidChunkId`, `InvalidFileId`, and `WrongEncryptionType` are never constructed [INFO] [stdout] --> src/error.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub enum SymmetricKeyError { [INFO] [stdout] | ----------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 54 | InvalidChunkId, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 55 | #[error("Invalid file id")] [INFO] [stdout] 56 | InvalidFileId, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | WrongEncryptionType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SymmetricKeyError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buf_reader.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let file = File::open(path).map_err(Error::from)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { reader, buf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/aead/mod.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 134 | fn new(prk: Zeroing<[u8; 32]>, data: &[u8]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let encrypted_chunk = EncryptedChunk::parse(data)?; [INFO] [stdout] 136 | let key = match encrypted_chunk.encryption_type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | key, [INFO] [stdout] 145 | | encrypted_chunk, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/aead/aes_gcm.rs:109:24 [INFO] [stdout] | [INFO] [stdout] 108 | fn key_for(self, chunk_id: u64) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | super::key_for(Box::pin(self), chunk_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/asym/ed25519.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn generate(prk: Zeroing<[u8; 32]>) -> Result> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok(Box::pin( [INFO] [stdout] | ________^ [INFO] [stdout] 13 | | ExtendedSigningKey::from_seed(&*prk).map_err(Error::from)?, [INFO] [stdout] 14 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:145:26 [INFO] [stdout] | [INFO] [stdout] 145 | .map(|c| c.to_string().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pigeonhole` (lib test) due to 6 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7f3a49b85e5e48aac89dcab92f47f31801d1be495cbbf12f20cd83fa39e5592f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f3a49b85e5e48aac89dcab92f47f31801d1be495cbbf12f20cd83fa39e5592f", kill_on_drop: false }` [INFO] [stdout] 7f3a49b85e5e48aac89dcab92f47f31801d1be495cbbf12f20cd83fa39e5592f