[INFO] cloning repository https://github.com/M-Mafeni/raytracer-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/M-Mafeni/raytracer-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FM-Mafeni%2Fraytracer-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FM-Mafeni%2Fraytracer-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd49a32ba85432cc7f66b2b76a939727c1120ef6 [INFO] checking M-Mafeni/raytracer-rust/dd49a32ba85432cc7f66b2b76a939727c1120ef6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FM-Mafeni%2Fraytracer-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/M-Mafeni/raytracer-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/M-Mafeni/raytracer-rust [INFO] finished tweaking git repo https://github.com/M-Mafeni/raytracer-rust [INFO] tweaked toml for git repo https://github.com/M-Mafeni/raytracer-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/M-Mafeni/raytracer-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab30f92c3e61a25e2bf84c3d47ae31287229f6bcfa4f4be87bb47c8147c3b0b4 [INFO] running `Command { std: "docker" "start" "-a" "ab30f92c3e61a25e2bf84c3d47ae31287229f6bcfa4f4be87bb47c8147c3b0b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab30f92c3e61a25e2bf84c3d47ae31287229f6bcfa4f4be87bb47c8147c3b0b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab30f92c3e61a25e2bf84c3d47ae31287229f6bcfa4f4be87bb47c8147c3b0b4", kill_on_drop: false }` [INFO] [stdout] ab30f92c3e61a25e2bf84c3d47ae31287229f6bcfa4f4be87bb47c8147c3b0b4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8dd15826f85b9b7b9f84a02651f78008b6ae56da18754e97868c8ead1a85267e [INFO] running `Command { std: "docker" "start" "-a" "8dd15826f85b9b7b9f84a02651f78008b6ae56da18754e97868c8ead1a85267e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking raytracer-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ray::ray` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use ray::ray; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/vector/random.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/vector/random.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ray::ray` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use ray::ray; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/vector/random.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/vector/random.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/world/material.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | Material::DiffuseLight { value } => None [INFO] [stdout] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/world/material.rs:29:81 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn scatter(&self, r: &Ray, p: Point3, normal: Point3, front_face: bool, t: f64) -> Option { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_scene` is never used [INFO] [stdout] --> src/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn random_scene() -> HittableList { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random` is never used [INFO] [stdout] --> src/vector/random.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn random() -> Vec3 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_in_hemisphere` is never used [INFO] [stdout] --> src/vector/random.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn random_in_hemisphere(normal: Vec3) -> Vec3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `metal` is never used [INFO] [stdout] --> src/world/material.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn metal(albedo: Color, f: f64) -> Material { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position` and `colour` are never read [INFO] [stdout] --> src/world/light.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Light { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 4 | pub position: Point3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 5 | pub colour: Color [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn add_new_hittable(&mut self, x: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.objects.push(Box::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/world/material.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | Material::DiffuseLight { value } => None [INFO] [stdout] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/world/material.rs:29:81 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn scatter(&self, r: &Ray, p: Point3, normal: Point3, front_face: bool, t: f64) -> Option { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer-rust` (bin "raytracer-rust" test) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `random_scene` is never used [INFO] [stdout] --> src/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn random_scene() -> HittableList { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random` is never used [INFO] [stdout] --> src/vector/random.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn random() -> Vec3 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_in_hemisphere` is never used [INFO] [stdout] --> src/vector/random.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn random_in_hemisphere(normal: Vec3) -> Vec3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `metal` is never used [INFO] [stdout] --> src/world/material.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn metal(albedo: Color, f: f64) -> Material { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position` and `colour` are never read [INFO] [stdout] --> src/world/light.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Light { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 4 | pub position: Point3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 5 | pub colour: Color [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn add_new_hittable(&mut self, x: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.objects.push(Box::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer-rust` (bin "raytracer-rust") due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8dd15826f85b9b7b9f84a02651f78008b6ae56da18754e97868c8ead1a85267e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8dd15826f85b9b7b9f84a02651f78008b6ae56da18754e97868c8ead1a85267e", kill_on_drop: false }` [INFO] [stdout] 8dd15826f85b9b7b9f84a02651f78008b6ae56da18754e97868c8ead1a85267e