[INFO] cloning repository https://github.com/LucasPickering/goldfinger [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LucasPickering/goldfinger" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLucasPickering%2Fgoldfinger", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLucasPickering%2Fgoldfinger'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2ea0e929c28ce97f9672d0888bdb9c969efcc8ec [INFO] checking LucasPickering/goldfinger/2ea0e929c28ce97f9672d0888bdb9c969efcc8ec against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLucasPickering%2Fgoldfinger" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LucasPickering/goldfinger on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/LucasPickering/goldfinger [INFO] finished tweaking git repo https://github.com/LucasPickering/goldfinger [INFO] tweaked toml for git repo https://github.com/LucasPickering/goldfinger written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LucasPickering/goldfinger already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed02dd3bb2c7771dbd0a8ad719d8b33cbfac3e716cf0b6eae68c175015457eaf [INFO] running `Command { std: "docker" "start" "-a" "ed02dd3bb2c7771dbd0a8ad719d8b33cbfac3e716cf0b6eae68c175015457eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed02dd3bb2c7771dbd0a8ad719d8b33cbfac3e716cf0b6eae68c175015457eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed02dd3bb2c7771dbd0a8ad719d8b33cbfac3e716cf0b6eae68c175015457eaf", kill_on_drop: false }` [INFO] [stdout] ed02dd3bb2c7771dbd0a8ad719d8b33cbfac3e716cf0b6eae68c175015457eaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e7c6412e99f22e7b4e5d87ba1a4646b2079483566d23fbb99ca4ea6b904cd1a [INFO] running `Command { std: "docker" "start" "-a" "8e7c6412e99f22e7b4e5d87ba1a4646b2079483566d23fbb99ca4ea6b904cd1a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling rustls v0.22.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rustix v0.38.30 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking embedded-graphics v0.6.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking ssd1680 v0.1.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking ureq v2.9.6 [INFO] [stderr] Checking goldfinger v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `display_port`, `forecast_office`, and `forecast_gridpoint` are never read [INFO] [stdout] --> src/config.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Config { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 8 | pub display_port: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | pub forecast_office: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | pub forecast_gridpoint: (u32, u32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mode` and `weather_period` are never read [INFO] [stdout] --> src/state.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct UserState { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 4 | pub mode: Mode, [INFO] [stdout] | ^^^^ [INFO] [stdout] 5 | pub weather_period: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UserState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Weather` is never constructed [INFO] [stdout] --> src/weather.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Weather { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Weather` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/weather.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 19 | impl Weather { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 20 | const FORECAST_TTL: Duration = Duration::from_secs(600); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 21 | const API_HOST: &'static str = "https://api.weather.gov"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | const DAY_START: Option = NaiveTime::from_hms_opt(4, 30, 0); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | const DAY_END: Option = NaiveTime::from_hms_opt(22, 30, 0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 26 | /// Number of weather periods to join together in [Forecase::future_periods] [INFO] [stdout] 27 | const JOINED_PERIODS: usize = 3; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 28 | [INFO] [stdout] 29 | pub fn new(config: &Config) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn forecast(&self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | fn fetch_latest(&self) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `properties` is never read [INFO] [stdout] --> src/weather.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub struct Forecast { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 101 | properties: ForecastProperties, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Forecast` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `periods` is never read [INFO] [stdout] --> src/weather.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 106 | pub struct ForecastProperties { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 107 | periods: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ForecastProperties` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `now` and `future_periods` are never used [INFO] [stdout] --> src/weather.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 125 | impl Forecast { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 126 | /// Get the current forecast period [INFO] [stdout] 127 | pub fn now(&self) -> &ForecastPeriod { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | pub fn future_periods(&self) -> impl '_ + Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `join`, `start_time`, `end_time`, `temperature`, and `prob_of_precip` are never used [INFO] [stdout] --> src/weather.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 149 | impl ForecastPeriod { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 150 | /// Join the given periods by averaging their values [INFO] [stdout] 151 | pub fn join(periods: &[Self]) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 174 | pub fn start_time(&self) -> DateTime { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | pub fn end_time(&self) -> DateTime { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn temperature(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 189 | pub fn prob_of_precip(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | let file = File::open(Self::PATH)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | serde_json::from_reader(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldfinger` (bin "goldfinger") due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `display_port`, `forecast_office`, and `forecast_gridpoint` are never read [INFO] [stdout] --> src/config.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Config { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 8 | pub display_port: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | pub forecast_office: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | pub forecast_gridpoint: (u32, u32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mode` and `weather_period` are never read [INFO] [stdout] --> src/state.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct UserState { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 4 | pub mode: Mode, [INFO] [stdout] | ^^^^ [INFO] [stdout] 5 | pub weather_period: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UserState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `url` and `forecast` are never read [INFO] [stdout] --> src/weather.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Weather { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 15 | url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | forecast: Arc>>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Weather` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `FORECAST_TTL`, `API_HOST`, `new`, `forecast`, and `fetch_latest` are never used [INFO] [stdout] --> src/weather.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 19 | impl Weather { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 20 | const FORECAST_TTL: Duration = Duration::from_secs(600); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 21 | const API_HOST: &'static str = "https://api.weather.gov"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn new(config: &Config) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn forecast(&self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | fn fetch_latest(&self) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `temperature` and `prob_of_precip` are never used [INFO] [stdout] --> src/weather.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 149 | impl ForecastPeriod { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn temperature(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 189 | pub fn prob_of_precip(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | let file = File::open(Self::PATH)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | serde_json::from_reader(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldfinger` (bin "goldfinger" test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8e7c6412e99f22e7b4e5d87ba1a4646b2079483566d23fbb99ca4ea6b904cd1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e7c6412e99f22e7b4e5d87ba1a4646b2079483566d23fbb99ca4ea6b904cd1a", kill_on_drop: false }` [INFO] [stdout] 8e7c6412e99f22e7b4e5d87ba1a4646b2079483566d23fbb99ca4ea6b904cd1a