[INFO] cloning repository https://github.com/Louis-Vincent/toy-payment-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Louis-Vincent/toy-payment-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLouis-Vincent%2Ftoy-payment-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLouis-Vincent%2Ftoy-payment-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1ac2160dfdd020edde69b8c94da8064d645af5cb [INFO] checking Louis-Vincent/toy-payment-engine/1ac2160dfdd020edde69b8c94da8064d645af5cb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLouis-Vincent%2Ftoy-payment-engine" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Louis-Vincent/toy-payment-engine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Louis-Vincent/toy-payment-engine [INFO] finished tweaking git repo https://github.com/Louis-Vincent/toy-payment-engine [INFO] tweaked toml for git repo https://github.com/Louis-Vincent/toy-payment-engine written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Louis-Vincent/toy-payment-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b87125333d67c2640c33762cc29f4b63e8f3a931426b5731d72594c466a0c7c [INFO] running `Command { std: "docker" "start" "-a" "9b87125333d67c2640c33762cc29f4b63e8f3a931426b5731d72594c466a0c7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b87125333d67c2640c33762cc29f4b63e8f3a931426b5731d72594c466a0c7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b87125333d67c2640c33762cc29f4b63e8f3a931426b5731d72594c466a0c7c", kill_on_drop: false }` [INFO] [stdout] 9b87125333d67c2640c33762cc29f4b63e8f3a931426b5731d72594c466a0c7c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e1147b147e94b5d2fd4ad1f33a4ba53c0fc197fa4c7fb16e8f31663d370d310 [INFO] running `Command { std: "docker" "start" "-a" "2e1147b147e94b5d2fd4ad1f33a4ba53c0fc197fa4c7fb16e8f31663d370d310", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling rust_decimal v1.23.1 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling arrayvec v0.7.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling rust_decimal_macros v1.23.1 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking payment-engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:25 [INFO] [stdout] | [INFO] [stdout] 116 | let local_shared_writer = shared_writer.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | local_shared_writer.lock().unwrap().serialize(csv_account).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 88 | fn insert_batch(&mut self, client_id: ClientId, tx_batch: I) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / tx_batch [INFO] [stdout] 102 | | .into_iter() [INFO] [stdout] 103 | | .inspect(|tx| { [INFO] [stdout] 104 | | match tx.tx_type { [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn new(transaction_log: TxLog) -> PaymentEngine { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | PaymentEngine::from_shared(Arc::new(Mutex::new(transaction_log))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn accept_tx_stream_with_chunk_size(&mut self, source: Source, batch_size: usize) -> impl Future [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | where Source: Stream { [INFO] [stdout] 239 | let local_tx_log = self.transaction_log.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | / source [INFO] [stdout] 241 | | .enumerate() [INFO] [stdout] 242 | | .chunks(batch_size) [INFO] [stdout] 243 | | // Sorting allow us to partition transaction by client id and reduce cache miss since we are [INFO] [stdout] ... | [INFO] [stdout] 259 | | ) [INFO] [stdout] 260 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn accept_tx_stream_with_chunk_size(&mut self, source: Source, batch_size: usize) -> impl Future [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | where Source: Stream { [INFO] [stdout] 239 | let local_tx_log = self.transaction_log.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | .for_each(move |(client_id, transactions)| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 262 | | let local_tx_log = local_tx_log.clone(); [INFO] [stdout] 263 | | async move { [INFO] [stdout] 264 | | local_tx_log.lock().unwrap().insert_batch(client_id, transactions); [INFO] [stdout] 265 | | } [INFO] [stdout] 266 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `payment-engine` (bin "payment-engine") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:25 [INFO] [stdout] | [INFO] [stdout] 116 | let local_shared_writer = shared_writer.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | local_shared_writer.lock().unwrap().serialize(csv_account).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 88 | fn insert_batch(&mut self, client_id: ClientId, tx_batch: I) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / tx_batch [INFO] [stdout] 102 | | .into_iter() [INFO] [stdout] 103 | | .inspect(|tx| { [INFO] [stdout] 104 | | match tx.tx_type { [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn new(transaction_log: TxLog) -> PaymentEngine { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | PaymentEngine::from_shared(Arc::new(Mutex::new(transaction_log))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn accept_tx_stream_with_chunk_size(&mut self, source: Source, batch_size: usize) -> impl Future [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | where Source: Stream { [INFO] [stdout] 239 | let local_tx_log = self.transaction_log.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | / source [INFO] [stdout] 241 | | .enumerate() [INFO] [stdout] 242 | | .chunks(batch_size) [INFO] [stdout] 243 | | // Sorting allow us to partition transaction by client id and reduce cache miss since we are [INFO] [stdout] ... | [INFO] [stdout] 259 | | ) [INFO] [stdout] 260 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payment_engine/mod.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn accept_tx_stream_with_chunk_size(&mut self, source: Source, batch_size: usize) -> impl Future [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | where Source: Stream { [INFO] [stdout] 239 | let local_tx_log = self.transaction_log.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | .for_each(move |(client_id, transactions)| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 262 | | let local_tx_log = local_tx_log.clone(); [INFO] [stdout] 263 | | async move { [INFO] [stdout] 264 | | local_tx_log.lock().unwrap().insert_batch(client_id, transactions); [INFO] [stdout] 265 | | } [INFO] [stdout] 266 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `payment-engine` (bin "payment-engine" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "2e1147b147e94b5d2fd4ad1f33a4ba53c0fc197fa4c7fb16e8f31663d370d310", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e1147b147e94b5d2fd4ad1f33a4ba53c0fc197fa4c7fb16e8f31663d370d310", kill_on_drop: false }` [INFO] [stdout] 2e1147b147e94b5d2fd4ad1f33a4ba53c0fc197fa4c7fb16e8f31663d370d310