[INFO] cloning repository https://github.com/LordSentox/sascs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LordSentox/sascs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordSentox%2Fsascs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordSentox%2Fsascs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30c12a2ca5054d0828af6ea4e086bc3a5a2c715e [INFO] checking LordSentox/sascs/30c12a2ca5054d0828af6ea4e086bc3a5a2c715e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordSentox%2Fsascs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LordSentox/sascs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LordSentox/sascs [INFO] finished tweaking git repo https://github.com/LordSentox/sascs [INFO] tweaked toml for git repo https://github.com/LordSentox/sascs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LordSentox/sascs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a10a318fa05b5cb11bce39a3d5b2675410295f5de5e4977e26b842210da9997f [INFO] running `Command { std: "docker" "start" "-a" "a10a318fa05b5cb11bce39a3d5b2675410295f5de5e4977e26b842210da9997f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a10a318fa05b5cb11bce39a3d5b2675410295f5de5e4977e26b842210da9997f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a10a318fa05b5cb11bce39a3d5b2675410295f5de5e4977e26b842210da9997f", kill_on_drop: false }` [INFO] [stdout] a10a318fa05b5cb11bce39a3d5b2675410295f5de5e4977e26b842210da9997f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7b0b5442f3d25e0201076e549c0a450c950e224429e2b757983df716f5219b9 [INFO] running `Command { std: "docker" "start" "-a" "e7b0b5442f3d25e0201076e549c0a450c950e224429e2b757983df716f5219b9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking libc v0.2.33 [INFO] [stderr] Checking serde v1.0.20 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking argparse v0.2.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling serde_derive_internals v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.20 [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking sascs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::u32::MAX as ClientIdMAX` [INFO] [stdout] --> src/packets.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use std::u32::MAX as ClientIdMAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error as IOErr` [INFO] [stdout] --> src/cli/nethandler.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::Error as IOErr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::nethandler::*` [INFO] [stdout] --> src/cli/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use self::nethandler::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/machine.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StoreTrue` [INFO] [stdout] --> src/server.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::*` [INFO] [stdout] --> src/fs.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use std::fs::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/machine.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::netclient::*` [INFO] [stdout] --> src/srv/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use self::netclient::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs::walk_files` [INFO] [stdout] --> src/server.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use fs::walk_files; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StoreTrue` [INFO] [stdout] --> src/server.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::*` [INFO] [stdout] --> src/fs.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use std::fs::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::NaiveDateTime` [INFO] [stdout] --> src/fs.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | use chrono::NaiveDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::prelude::*` [INFO] [stdout] --> src/fs.rs:66:6 [INFO] [stdout] | [INFO] [stdout] 66 | use chrono::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/machine.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::netclient::*` [INFO] [stdout] --> src/srv/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use self::netclient::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs::walk_files` [INFO] [stdout] --> src/server.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use fs::walk_files; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::u32::MAX as ClientIdMAX` [INFO] [stdout] --> src/packets.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use std::u32::MAX as ClientIdMAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error as IOErr` [INFO] [stdout] --> src/cli/nethandler.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::Error as IOErr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::nethandler::*` [INFO] [stdout] --> src/cli/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use self::nethandler::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/machine.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::NaiveDateTime` [INFO] [stdout] --> src/fs.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | use chrono::NaiveDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::prelude::*` [INFO] [stdout] --> src/fs.rs:66:6 [INFO] [stdout] | [INFO] [stdout] 66 | use chrono::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/packets.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/packets.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/packets.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/packets.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/packets.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/packets.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/fs.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 103 | let file = File::create(".test_file").expect("Could not create file"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs.rs:117:7 [INFO] [stdout] | [INFO] [stdout] 117 | let mut files: Vec = vec!["./.test_dir3/one".into(), "./.test_dir3/two".into(), "./.test_dir3/three".into()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/client.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nethandler` [INFO] [stdout] --> src/client.rs:94:43 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nethandler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packets.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 53 | Err(err) => { println!("Error serialising packet: {}", err); return false; } [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match self.write(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let stream_clone = match stream.try_clone() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(stream) => stream, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(err) => return Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | read: Mutex::new(stream), [INFO] [stdout] 38 | | write: Mutex::new(stream_clone) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_modified>(f: P, time: &SystemTime) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Command::new("touch") [INFO] [stdout] 49 | | .arg("-m") [INFO] [stdout] 50 | | .arg("-t").arg(time.format("%Y%m%d%H%M.%S").to_string()) [INFO] [stdout] 51 | | .arg(f.as_ref()) [INFO] [stdout] 52 | | .status().unwrap().success() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/packets.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/packets.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sascs` (bin "client") due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `machine` [INFO] [stdout] --> src/server.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | let machine = Machine::now_with_fs(fs); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_machine` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/server.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/server.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut home_dir = Path::new("."); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_modified>(f: P, time: &SystemTime) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Command::new("touch") [INFO] [stdout] 49 | | .arg("-m") [INFO] [stdout] 50 | | .arg("-t").arg(time.format("%Y%m%d%H%M.%S").to_string()) [INFO] [stdout] 51 | | .arg(f.as_ref()) [INFO] [stdout] 52 | | .status().unwrap().success() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packets.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 53 | Err(err) => { println!("Error serialising packet: {}", err); return false; } [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match self.write(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let stream_clone = match stream.try_clone() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(stream) => stream, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(err) => return Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | read: Mutex::new(stream), [INFO] [stdout] 38 | | write: Mutex::new(stream_clone) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/netclient.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(id: ClientId, remote: Remote) -> NetClient { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | remote: Arc::new(remote) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/netclient.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn start_rcv(&self, tx: Sender<(ClientId, Packet)>) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let remote_clone = self.remote.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | let mut running = true; [INFO] [stdout] 31 | | while running { [INFO] [stdout] 32 | | // Read the latest packet from the remote. [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/nethandler.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | clients: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `machine` [INFO] [stdout] --> src/server.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | let machine = Machine::now_with_fs(fs); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_machine` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/server.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/server.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut home_dir = Path::new("."); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_modified>(f: P, time: &SystemTime) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Command::new("touch") [INFO] [stdout] 49 | | .arg("-m") [INFO] [stdout] 50 | | .arg("-t").arg(time.format("%Y%m%d%H%M.%S").to_string()) [INFO] [stdout] 51 | | .arg(f.as_ref()) [INFO] [stdout] 52 | | .status().unwrap().success() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packets.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 53 | Err(err) => { println!("Error serialising packet: {}", err); return false; } [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match self.write(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let stream_clone = match stream.try_clone() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(stream) => stream, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(err) => return Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | read: Mutex::new(stream), [INFO] [stdout] 38 | | write: Mutex::new(stream_clone) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/netclient.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(id: ClientId, remote: Remote) -> NetClient { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | remote: Arc::new(remote) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sascs` (bin "server" test) due to 7 previous errors; 16 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/netclient.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn start_rcv(&self, tx: Sender<(ClientId, Packet)>) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let remote_clone = self.remote.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | let mut running = true; [INFO] [stdout] 31 | | while running { [INFO] [stdout] 32 | | // Read the latest packet from the remote. [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/srv/nethandler.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 48 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | clients: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/fs.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 103 | let file = File::create(".test_file").expect("Could not create file"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs.rs:117:7 [INFO] [stdout] | [INFO] [stdout] 117 | let mut files: Vec = vec!["./.test_dir3/one".into(), "./.test_dir3/two".into(), "./.test_dir3/three".into()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/client.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nethandler` [INFO] [stdout] --> src/client.rs:94:43 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nethandler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packets.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 53 | Err(err) => { println!("Error serialising packet: {}", err); return false; } [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match self.write(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let stream_clone = match stream.try_clone() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(stream) => stream, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(err) => return Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | read: Mutex::new(stream), [INFO] [stdout] 38 | | write: Mutex::new(stream_clone) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_modified>(f: P, time: &SystemTime) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Command::new("touch") [INFO] [stdout] 49 | | .arg("-m") [INFO] [stdout] 50 | | .arg("-t").arg(time.format("%Y%m%d%H%M.%S").to_string()) [INFO] [stdout] 51 | | .arg(f.as_ref()) [INFO] [stdout] 52 | | .status().unwrap().success() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sascs` (bin "server") due to 7 previous errors; 11 warnings emitted [INFO] [stdout] error: aborting due to 3 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sascs` (bin "client" test) due to 4 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e7b0b5442f3d25e0201076e549c0a450c950e224429e2b757983df716f5219b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7b0b5442f3d25e0201076e549c0a450c950e224429e2b757983df716f5219b9", kill_on_drop: false }` [INFO] [stdout] e7b0b5442f3d25e0201076e549c0a450c950e224429e2b757983df716f5219b9