[INFO] cloning repository https://github.com/Lohikar/byhttp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lohikar/byhttp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLohikar%2Fbyhttp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLohikar%2Fbyhttp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0ba65f8118d6fb8b4e8b1a1a791d9b30a8a0aa5e [INFO] checking Lohikar/byhttp/0ba65f8118d6fb8b4e8b1a1a791d9b30a8a0aa5e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLohikar%2Fbyhttp" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Lohikar/byhttp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Lohikar/byhttp [INFO] finished tweaking git repo https://github.com/Lohikar/byhttp [INFO] tweaked toml for git repo https://github.com/Lohikar/byhttp written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Lohikar/byhttp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c32b645a969e793957949cf849390943f5e7182c97558c96297a1713fe5a92d5 [INFO] running `Command { std: "docker" "start" "-a" "c32b645a969e793957949cf849390943f5e7182c97558c96297a1713fe5a92d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c32b645a969e793957949cf849390943f5e7182c97558c96297a1713fe5a92d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c32b645a969e793957949cf849390943f5e7182c97558c96297a1713fe5a92d5", kill_on_drop: false }` [INFO] [stdout] c32b645a969e793957949cf849390943f5e7182c97558c96297a1713fe5a92d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91f57423f1e9ae8946ed690af1839dcc9f74cea043c8dd929a7a3926afcbb511 [INFO] running `Command { std: "docker" "start" "-a" "91f57423f1e9ae8946ed690af1839dcc9f74cea043c8dd929a7a3926afcbb511", kill_on_drop: false }` [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking rustls-pemfile v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Checking webpki-roots v0.22.4 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking ureq v2.5.0 [INFO] [stderr] Checking byhttp v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:2 [INFO] [stdout] | [INFO] [stdout] 53 | fn unwrap_result(err: Result<(String, u16), ByError>) -> String { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | serde_json::to_string(&retval).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byond.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn byond_return(inner: F) -> *const c_char [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | match inner() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byond.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 32 | Some(string) => RETURN_STRING.with(|cell| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cstring = CString::new(string).expect("null in returned string!"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | cell.replace(cstring); [INFO] [stdout] 35 | cell.borrow().as_ptr() as *const c_char [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:2 [INFO] [stdout] | [INFO] [stdout] 53 | fn unwrap_result(err: Result<(String, u16), ByError>) -> String { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | serde_json::to_string(&retval).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byond.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn byond_return(inner: F) -> *const c_char [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | match inner() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byond.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 32 | Some(string) => RETURN_STRING.with(|cell| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cstring = CString::new(string).expect("null in returned string!"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | cell.replace(cstring); [INFO] [stdout] 35 | cell.borrow().as_ptr() as *const c_char [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `byhttp` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `byhttp` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "91f57423f1e9ae8946ed690af1839dcc9f74cea043c8dd929a7a3926afcbb511", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91f57423f1e9ae8946ed690af1839dcc9f74cea043c8dd929a7a3926afcbb511", kill_on_drop: false }` [INFO] [stdout] 91f57423f1e9ae8946ed690af1839dcc9f74cea043c8dd929a7a3926afcbb511