[INFO] cloning repository https://github.com/Logarithmus/matrix-ops-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Logarithmus/matrix-ops-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogarithmus%2Fmatrix-ops-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogarithmus%2Fmatrix-ops-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4ada2aa2a56515bcc902efa2568b10671458fe8 [INFO] checking Logarithmus/matrix-ops-rs/e4ada2aa2a56515bcc902efa2568b10671458fe8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogarithmus%2Fmatrix-ops-rs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Logarithmus/matrix-ops-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Logarithmus/matrix-ops-rs [INFO] finished tweaking git repo https://github.com/Logarithmus/matrix-ops-rs [INFO] tweaked toml for git repo https://github.com/Logarithmus/matrix-ops-rs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Logarithmus/matrix-ops-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd5b13768dadfb332664118b20541d98ca4507de6527bb2ae0058c54b3c1ccf3 [INFO] running `Command { std: "docker" "start" "-a" "cd5b13768dadfb332664118b20541d98ca4507de6527bb2ae0058c54b3c1ccf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd5b13768dadfb332664118b20541d98ca4507de6527bb2ae0058c54b3c1ccf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd5b13768dadfb332664118b20541d98ca4507de6527bb2ae0058c54b3c1ccf3", kill_on_drop: false }` [INFO] [stdout] cd5b13768dadfb332664118b20541d98ca4507de6527bb2ae0058c54b3c1ccf3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af8032ffe26b9a0674b2ee242307b8b638c1f7601e8f092b3d74ca36411a3e0e [INFO] running `Command { std: "docker" "start" "-a" "af8032ffe26b9a0674b2ee242307b8b638c1f7601e8f092b3d74ca36411a3e0e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling getrandom v0.1.11 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking vavp_lab1 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 153 | let zeroes_iter = iter::repeat(iter::repeat(T::default()).take(new_cols - cols)).take(*rows); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let padded_iter = rows_iter.zip(zeroes_iter).map(|row| row.0.chain(row.1)).flatten(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let zeroes_iter = iter::repeat(iter::repeat(T::default()).take(new_cols)).take(new_rows - rows); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let padded_iter = padded_iter.chain(zeroes_iter.flatten()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | Matrix::with_data(padded_iter.collect(), (new_rows, new_cols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/matrix.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Matrix` does not implement `Borrow`, so calling `borrow` on `&Matrix` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 234 - let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] 234 + let (mat1, mat2) = (mat1, mat2.borrow()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Matrix`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub struct Matrix { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/matrix.rs:234:44 [INFO] [stdout] | [INFO] [stdout] 234 | let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Matrix` does not implement `Borrow`, so calling `borrow` on `&Matrix` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 234 - let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] 234 + let (mat1, mat2) = (mat1.borrow(), mat2); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Matrix`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub struct Matrix { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vavp_lab1` (bin "vavp_lab1") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 153 | let zeroes_iter = iter::repeat(iter::repeat(T::default()).take(new_cols - cols)).take(*rows); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let padded_iter = rows_iter.zip(zeroes_iter).map(|row| row.0.chain(row.1)).flatten(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let zeroes_iter = iter::repeat(iter::repeat(T::default()).take(new_cols)).take(new_rows - rows); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let padded_iter = padded_iter.chain(zeroes_iter.flatten()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | Matrix::with_data(padded_iter.collect(), (new_rows, new_cols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/matrix.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Matrix` does not implement `Borrow`, so calling `borrow` on `&Matrix` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 234 - let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] 234 + let (mat1, mat2) = (mat1, mat2.borrow()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Matrix`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub struct Matrix { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/matrix.rs:234:44 [INFO] [stdout] | [INFO] [stdout] 234 | let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Matrix` does not implement `Borrow`, so calling `borrow` on `&Matrix` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 234 - let (mat1, mat2) = (mat1.borrow(), mat2.borrow()); [INFO] [stdout] 234 + let (mat1, mat2) = (mat1.borrow(), mat2); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Matrix`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub struct Matrix { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vavp_lab1` (bin "vavp_lab1" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "af8032ffe26b9a0674b2ee242307b8b638c1f7601e8f092b3d74ca36411a3e0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af8032ffe26b9a0674b2ee242307b8b638c1f7601e8f092b3d74ca36411a3e0e", kill_on_drop: false }` [INFO] [stdout] af8032ffe26b9a0674b2ee242307b8b638c1f7601e8f092b3d74ca36411a3e0e