[INFO] cloning repository https://github.com/Lodek/keyboard [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lodek/keyboard" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLodek%2Fkeyboard", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLodek%2Fkeyboard'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d8a0301f37c4e4536387accc8bc98e2e3929e5a1 [INFO] checking Lodek/keyboard/d8a0301f37c4e4536387accc8bc98e2e3929e5a1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLodek%2Fkeyboard" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Lodek/keyboard on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Lodek/keyboard [INFO] finished tweaking git repo https://github.com/Lodek/keyboard [INFO] tweaked toml for git repo https://github.com/Lodek/keyboard written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Lodek/keyboard already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b29e2000a0fe9befb0e4a0c6e7a9b08a6190b7e3491fc4d446b8e4366310033c [INFO] running `Command { std: "docker" "start" "-a" "b29e2000a0fe9befb0e4a0c6e7a9b08a6190b7e3491fc4d446b8e4366310033c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b29e2000a0fe9befb0e4a0c6e7a9b08a6190b7e3491fc4d446b8e4366310033c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b29e2000a0fe9befb0e4a0c6e7a9b08a6190b7e3491fc4d446b8e4366310033c", kill_on_drop: false }` [INFO] [stdout] b29e2000a0fe9befb0e4a0c6e7a9b08a6190b7e3491fc4d446b8e4366310033c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b44ef4f9199a1bc2a9ece2f4d01db7f356c1ac51cdaa8f8e008ec5476896ada [INFO] running `Command { std: "docker" "start" "-a" "5b44ef4f9199a1bc2a9ece2f4d01db7f356c1ac51cdaa8f8e008ec5476896ada", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking keywerty v0.1.0 (/opt/rustwide/workdir/keywerty) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> keywerty/src/keyboard/smkb/mod.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 302 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mapper::SimpleMapper` [INFO] [stdout] --> keywerty/src/keyboard/smkb/mod.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | use crate::mapper::SimpleMapper; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> keywerty/src/keyboard/smkb/mod.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 137 | layer_mapper: Mapper, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | state_machines: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> keywerty/src/keyboard/smkb/tap_ksm.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(watched_key: KeyId, key_conf: TapKeyConf) -> Self { [INFO] [stdout] | ------------------ ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | cleanup_actions: [(&key_conf).tap.invert()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keywerty` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> keywerty/src/keyboard/smkb/eager_hold_ksm.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let mut machine = EagerHoldKSM::new(timeout, watched_key, conf); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> keywerty/src/keyboard/smkb/eager_hold_ksm.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | for i in [0..2] { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> keywerty/src/keyboard/smkb/hold_ksm.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | let mut machine = HoldKSM::new(timeout, watched_key, conf); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> keywerty/src/keyboard/smkb/hold_ksm.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | for i in [0..2] { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> keywerty/src/keyboard/smkb/mod.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 137 | layer_mapper: Mapper, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | state_machines: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `watched_key` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/eager_hold_ksm.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 122 | const watched_key: u8 = 1; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `WATCHED_KEY` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `tap_key_code` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/eager_hold_ksm.rs:123:11 [INFO] [stdout] | [INFO] [stdout] 123 | const tap_key_code: u8 = 10; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `TAP_KEY_CODE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `hold_key_code` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/eager_hold_ksm.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 124 | const hold_key_code: u8 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `HOLD_KEY_CODE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `watched_key` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/hold_ksm.rs:118:11 [INFO] [stdout] | [INFO] [stdout] 118 | const watched_key: u8 = 1; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `WATCHED_KEY` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `tap_key_code` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/hold_ksm.rs:119:11 [INFO] [stdout] | [INFO] [stdout] 119 | const tap_key_code: u8 = 10; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `TAP_KEY_CODE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `hold_key_code` should have an upper case name [INFO] [stdout] --> keywerty/src/keyboard/smkb/hold_ksm.rs:120:11 [INFO] [stdout] | [INFO] [stdout] 120 | const hold_key_code: u8 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `HOLD_KEY_CODE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> keywerty/src/keyboard/smkb/tap_ksm.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(watched_key: KeyId, key_conf: TapKeyConf) -> Self { [INFO] [stdout] | ------------------ ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | cleanup_actions: [(&key_conf).tap.invert()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keywerty` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5b44ef4f9199a1bc2a9ece2f4d01db7f356c1ac51cdaa8f8e008ec5476896ada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b44ef4f9199a1bc2a9ece2f4d01db7f356c1ac51cdaa8f8e008ec5476896ada", kill_on_drop: false }` [INFO] [stdout] 5b44ef4f9199a1bc2a9ece2f4d01db7f356c1ac51cdaa8f8e008ec5476896ada