[INFO] cloning repository https://github.com/LiptonB/nettap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LiptonB/nettap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 75cec1573fc843e3441d43a96904b809448932e7 [INFO] checking LiptonB/nettap/75cec1573fc843e3441d43a96904b809448932e7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LiptonB/nettap on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LiptonB/nettap [INFO] finished tweaking git repo https://github.com/LiptonB/nettap [INFO] tweaked toml for git repo https://github.com/LiptonB/nettap written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LiptonB/nettap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a09bf01f18936365be42c76bed0a991c0df2e224d97a2c092eaf043a0304984 [INFO] running `Command { std: "docker" "start" "-a" "6a09bf01f18936365be42c76bed0a991c0df2e224d97a2c092eaf043a0304984", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a09bf01f18936365be42c76bed0a991c0df2e224d97a2c092eaf043a0304984", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a09bf01f18936365be42c76bed0a991c0df2e224d97a2c092eaf043a0304984", kill_on_drop: false }` [INFO] [stdout] 6a09bf01f18936365be42c76bed0a991c0df2e224d97a2c092eaf043a0304984 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4b2e08d8cbf47c716223c4765a3b4467dae80660221fe0a95d9eddde6032df1 [INFO] running `Command { std: "docker" "start" "-a" "d4b2e08d8cbf47c716223c4765a3b4467dae80660221fe0a95d9eddde6032df1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.59 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling serde v1.0.121 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling tokio v1.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Checking thread_local v1.1.1 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking tokio v0.2.24 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Checking tokio-test v0.2.1 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Compiling tokio-macros v1.0.0 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling tracing-attributes v0.1.11 [INFO] [stderr] Compiling async-stream-impl v0.3.0 [INFO] [stderr] Checking async-stream v0.3.0 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking tracing v0.1.22 [INFO] [stderr] Checking tracing-subscriber v0.2.15 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking tokio-stream v0.1.2 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking tokio-util v0.6.2 [INFO] [stderr] Checking nettap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `TokioConnection` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct TokioConnection [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ConnectionData` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct ConnectionData { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `run` are never used [INFO] [stdout] --> src/connection/tokio_connection.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 116 | / impl TokioConnection [INFO] [stdout] 117 | | where [INFO] [stdout] 118 | | R: AsyncRead + Unpin, [INFO] [stdout] 119 | | W: AsyncWrite + Unpin, [INFO] [stdout] | |______________________________- associated items in this implementation [INFO] [stdout] 120 | { [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast_stream.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(mut rx: Receiver) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let stream = stream! { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Box::pin(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new_tokio_connection(read_socket: R, write_socket: W) -> NewConnection [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ______________^ [INFO] [stdout] 25 | | Box::pin(tokio_connection( [INFO] [stdout] 26 | | sender, [INFO] [stdout] 27 | | receiver, [INFO] [stdout] ... | [INFO] [stdout] 30 | | )) [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new_tokio_connection(read_socket: R, write_socket: W) -> NewConnection [INFO] [stdout] | ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ----------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Box::pin(tokio_connection( [INFO] [stdout] | __________________^ [INFO] [stdout] 26 | | sender, [INFO] [stdout] 27 | | receiver, [INFO] [stdout] 28 | | read_socket, [INFO] [stdout] 29 | | write_socket, [INFO] [stdout] 30 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new_spawner_connection(spawner: S) -> NewConnection [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ______________^ [INFO] [stdout] 40 | | Box::pin(spawner_connection(sender, receiver, spawner)) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new_spawner_connection(spawner: S) -> NewConnection [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ----------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Box::pin(spawner_connection(sender, receiver, spawner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let (connection_end, coordinator_end) = io::duplex(4096); [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | / Self { [INFO] [stdout] 126 | | reader, [INFO] [stdout] 127 | | writer, [INFO] [stdout] 128 | | stream: connection_end, [INFO] [stdout] 129 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let (connection_end, coordinator_end) = io::duplex(4096); [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / ConnectionData { [INFO] [stdout] 131 | | stream: coordinator_end, [INFO] [stdout] 132 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coordinator.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 24 | let (sender, _) = broadcast::channel(CHANNEL_CAPACITY); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Coordinator { [INFO] [stdout] 26 | incoming: StreamMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coordinator.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn filter_receiver(receiver: BroadcastStream<(Uuid, Bytes)>, id: Uuid) -> DataStream { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Box::new(receiver.filter_map(move |received| { [INFO] [stdout] | ______________^ [INFO] [stdout] 68 | | let (msg_id, data) = received.ok()?; [INFO] [stdout] 69 | | if msg_id == id { [INFO] [stdout] 70 | | None [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nettap` (bin "nettap") due to 10 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TokioConnection` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct TokioConnection [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ConnectionData` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct ConnectionData { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `run` are never used [INFO] [stdout] --> src/connection/tokio_connection.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 116 | / impl TokioConnection [INFO] [stdout] 117 | | where [INFO] [stdout] 118 | | R: AsyncRead + Unpin, [INFO] [stdout] 119 | | W: AsyncWrite + Unpin, [INFO] [stdout] | |______________________________- associated items in this implementation [INFO] [stdout] 120 | { [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast_stream.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(mut rx: Receiver) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let stream = stream! { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Box::pin(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/stream_connection.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(read_stream: R, write_sink: W) -> NewConnection [INFO] [stdout] | -------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ______________^ [INFO] [stdout] 16 | | Box::pin( [INFO] [stdout] 17 | | futures::future::join( [INFO] [stdout] 18 | | stream_to_sender(read_stream, sender), [INFO] [stdout] ... | [INFO] [stdout] 22 | | ) [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/stream_connection.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(read_stream: R, write_sink: W) -> NewConnection [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ----------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Box::pin( [INFO] [stdout] 17 | / futures::future::join( [INFO] [stdout] 18 | | stream_to_sender(read_stream, sender), [INFO] [stdout] 19 | | stream_to_sink(receiver, write_sink), [INFO] [stdout] 20 | | ) [INFO] [stdout] 21 | | .map(|_| ()), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new_tokio_connection(read_socket: R, write_socket: W) -> NewConnection [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ______________^ [INFO] [stdout] 25 | | Box::pin(tokio_connection( [INFO] [stdout] 26 | | sender, [INFO] [stdout] 27 | | receiver, [INFO] [stdout] ... | [INFO] [stdout] 30 | | )) [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new_tokio_connection(read_socket: R, write_socket: W) -> NewConnection [INFO] [stdout] | ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ----------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Box::pin(tokio_connection( [INFO] [stdout] | __________________^ [INFO] [stdout] 26 | | sender, [INFO] [stdout] 27 | | receiver, [INFO] [stdout] 28 | | read_socket, [INFO] [stdout] 29 | | write_socket, [INFO] [stdout] 30 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new_spawner_connection(spawner: S) -> NewConnection [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ______________^ [INFO] [stdout] 40 | | Box::pin(spawner_connection(sender, receiver, spawner)) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new_spawner_connection(spawner: S) -> NewConnection [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Box::new(move |sender: mpsc::Sender, receiver: DataStream| { [INFO] [stdout] | ----------------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Box::pin(spawner_connection(sender, receiver, spawner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let (connection_end, coordinator_end) = io::duplex(4096); [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | / Self { [INFO] [stdout] 126 | | reader, [INFO] [stdout] 127 | | writer, [INFO] [stdout] 128 | | stream: connection_end, [INFO] [stdout] 129 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let (connection_end, coordinator_end) = io::duplex(4096); [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / ConnectionData { [INFO] [stdout] 131 | | stream: coordinator_end, [INFO] [stdout] 132 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coordinator.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 24 | let (sender, _) = broadcast::channel(CHANNEL_CAPACITY); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Coordinator { [INFO] [stdout] 26 | incoming: StreamMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coordinator.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn filter_receiver(receiver: BroadcastStream<(Uuid, Bytes)>, id: Uuid) -> DataStream { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Box::new(receiver.filter_map(move |received| { [INFO] [stdout] | ______________^ [INFO] [stdout] 68 | | let (msg_id, data) = received.ok()?; [INFO] [stdout] 69 | | if msg_id == id { [INFO] [stdout] 70 | | None [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nettap` (bin "nettap" test) due to 12 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d4b2e08d8cbf47c716223c4765a3b4467dae80660221fe0a95d9eddde6032df1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4b2e08d8cbf47c716223c4765a3b4467dae80660221fe0a95d9eddde6032df1", kill_on_drop: false }` [INFO] [stdout] d4b2e08d8cbf47c716223c4765a3b4467dae80660221fe0a95d9eddde6032df1