[INFO] cloning repository https://github.com/Liberontissauri/Castle-Libs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Liberontissauri/Castle-Libs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiberontissauri%2FCastle-Libs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiberontissauri%2FCastle-Libs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 93bdf130c57c3ec5d0532643228c417e6bfc8135 [INFO] checking Liberontissauri/Castle-Libs/93bdf130c57c3ec5d0532643228c417e6bfc8135 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiberontissauri%2FCastle-Libs" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Liberontissauri/Castle-Libs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Liberontissauri/Castle-Libs [INFO] finished tweaking git repo https://github.com/Liberontissauri/Castle-Libs [INFO] tweaked toml for git repo https://github.com/Liberontissauri/Castle-Libs written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Liberontissauri/Castle-Libs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c46e6b7a7443ddcd98797727364e8afaae89304145adfc5fc3ccd614186a7aa2 [INFO] running `Command { std: "docker" "start" "-a" "c46e6b7a7443ddcd98797727364e8afaae89304145adfc5fc3ccd614186a7aa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c46e6b7a7443ddcd98797727364e8afaae89304145adfc5fc3ccd614186a7aa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c46e6b7a7443ddcd98797727364e8afaae89304145adfc5fc3ccd614186a7aa2", kill_on_drop: false }` [INFO] [stdout] c46e6b7a7443ddcd98797727364e8afaae89304145adfc5fc3ccd614186a7aa2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf7cf42db6600ae2f52ac5c4bd85890da360d3e15bc23698f19abb3c5b789d67 [INFO] running `Command { std: "docker" "start" "-a" "bf7cf42db6600ae2f52ac5c4bd85890da360d3e15bc23698f19abb3c5b789d67", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking mucow v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking pleco v0.5.0 [INFO] [stderr] Checking castle_libs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `BitMove` [INFO] [stdout] --> src/chess.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use pleco::{BitMove, Board}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Initial_Board` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Initial_Board, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `InitialBoard` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Start_Time` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | Start_Time, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `StartTime` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Time_Limit` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | Time_Limit, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `TimeLimit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BitMove` [INFO] [stdout] --> src/chess.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use pleco::{BitMove, Board}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Initial_Board` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Initial_Board, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `InitialBoard` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Start_Time` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | Start_Time, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `StartTime` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Time_Limit` should have an upper camel case name [INFO] [stdout] --> src/chess.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | Time_Limit, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `TimeLimit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pleco::Board` [INFO] [stdout] --> src/chess.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | use pleco::Board; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mov` [INFO] [stdout] --> src/chess.rs:192:21 [INFO] [stdout] | [INFO] [stdout] 192 | if let Some(mov) = self.moves.pop() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mov` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chess.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 281 | let mut time_since_first_move = self.compute_total_moves_pure_time(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chess.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 54 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let initial_board = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(ChessGame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 111 | | initial_board, [INFO] [stdout] 112 | | moves, [INFO] [stdout] 113 | | increment, [INFO] [stdout] 114 | | start_time, [INFO] [stdout] 115 | | time_limit, [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chess.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 118 | fn visit_seq(self, mut seq: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(ChessGame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 138 | | initial_board: Board::from_fen(&inital_board).unwrap(), [INFO] [stdout] 139 | | moves, [INFO] [stdout] 140 | | start_time, [INFO] [stdout] 141 | | time_limit, [INFO] [stdout] 142 | | increment, [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `castle_libs` (lib) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `mov` [INFO] [stdout] --> src/chess.rs:192:21 [INFO] [stdout] | [INFO] [stdout] 192 | if let Some(mov) = self.moves.pop() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mov` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chess.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 281 | let mut time_since_first_move = self.compute_total_moves_pure_time(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chess.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 54 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let initial_board = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(ChessGame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 111 | | initial_board, [INFO] [stdout] 112 | | moves, [INFO] [stdout] 113 | | increment, [INFO] [stdout] 114 | | start_time, [INFO] [stdout] 115 | | time_limit, [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chess.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 118 | fn visit_seq(self, mut seq: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(ChessGame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 138 | | initial_board: Board::from_fen(&inital_board).unwrap(), [INFO] [stdout] 139 | | moves, [INFO] [stdout] 140 | | start_time, [INFO] [stdout] 141 | | time_limit, [INFO] [stdout] 142 | | increment, [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `castle_libs` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bf7cf42db6600ae2f52ac5c4bd85890da360d3e15bc23698f19abb3c5b789d67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf7cf42db6600ae2f52ac5c4bd85890da360d3e15bc23698f19abb3c5b789d67", kill_on_drop: false }` [INFO] [stdout] bf7cf42db6600ae2f52ac5c4bd85890da360d3e15bc23698f19abb3c5b789d67