[INFO] cloning repository https://github.com/LexLimited/rusks [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LexLimited/rusks" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLexLimited%2Frusks", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLexLimited%2Frusks'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bb27074a95c2c52025b9566c525d5974d02f5153 [INFO] checking LexLimited/rusks/bb27074a95c2c52025b9566c525d5974d02f5153 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLexLimited%2Frusks" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LexLimited/rusks on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LexLimited/rusks [INFO] finished tweaking git repo https://github.com/LexLimited/rusks [INFO] tweaked toml for git repo https://github.com/LexLimited/rusks written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LexLimited/rusks already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3edc95bad89fe58669c2bc4c54f44ba9fcaf8f6ef4a2d87296407c16284712c [INFO] running `Command { std: "docker" "start" "-a" "b3edc95bad89fe58669c2bc4c54f44ba9fcaf8f6ef4a2d87296407c16284712c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3edc95bad89fe58669c2bc4c54f44ba9fcaf8f6ef4a2d87296407c16284712c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3edc95bad89fe58669c2bc4c54f44ba9fcaf8f6ef4a2d87296407c16284712c", kill_on_drop: false }` [INFO] [stdout] b3edc95bad89fe58669c2bc4c54f44ba9fcaf8f6ef4a2d87296407c16284712c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f43eefbc8eb6ea87c5d05350924fc2aab37f69631c95721a21573d4d4c25e73 [INFO] running `Command { std: "docker" "start" "-a" "4f43eefbc8eb6ea87c5d05350924fc2aab37f69631c95721a21573d4d4c25e73", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking rusks v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `matches` [INFO] [stdout] --> src/cmd/creation/list.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn create_list(matches: &ArgMatches) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/cmd/execution/add.rs:3:57 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn exec_add(storage: &RusksStorage, title: &String, options: &Vec) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pattern` [INFO] [stdout] --> src/cmd/execution/list.rs:5:42 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn exec_list(storage: &RusksStorage, pattern: &String) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matches` [INFO] [stdout] --> src/cmd/creation/list.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn create_list(matches: &ArgMatches) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/cmd/execution/add.rs:3:57 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn exec_add(storage: &RusksStorage, title: &String, options: &Vec) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pattern` [INFO] [stdout] --> src/cmd/execution/list.rs:5:42 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn exec_list(storage: &RusksStorage, pattern: &String) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `levenshtein_dist` is never used [INFO] [stdout] --> src/algorithms.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn levenshtein_dist(a: &str, b: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_temp_file` is never used [INFO] [stdout] --> src/fs.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn remove_temp_file(name: &str) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_description`, `add_note`, and `remove_note` are never used [INFO] [stdout] --> src/task.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl Task { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn set_description(&mut self, description: &str) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn add_note(&mut self, note: &str) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn remove_note(&mut self, i: usize) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/cmd/execution/list.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | temp_file.write_all(format!("(id = {}):\n", item.get_id()).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = temp_file.write_all(format!("(id = {}):\n", item.get_id()).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/cmd/execution/list.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | process::Command::new("glow").arg(path_str).status(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = process::Command::new("glow").arg(path_str).status(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 44 | let db = sled::open( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(RusksStorage{ db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_temp_file` is never used [INFO] [stdout] --> src/fs.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn remove_temp_file(name: &str) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_description`, `add_note`, and `remove_note` are never used [INFO] [stdout] --> src/task.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl Task { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn set_description(&mut self, description: &str) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn add_note(&mut self, note: &str) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn remove_note(&mut self, i: usize) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/cmd/execution/list.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | temp_file.write_all(format!("(id = {}):\n", item.get_id()).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = temp_file.write_all(format!("(id = {}):\n", item.get_id()).as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/cmd/execution/list.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | process::Command::new("glow").arg(path_str).status(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = process::Command::new("glow").arg(path_str).status(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 44 | let db = sled::open( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(RusksStorage{ db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusks` (bin "rusks") due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusks` (bin "rusks" test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4f43eefbc8eb6ea87c5d05350924fc2aab37f69631c95721a21573d4d4c25e73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f43eefbc8eb6ea87c5d05350924fc2aab37f69631c95721a21573d4d4c25e73", kill_on_drop: false }` [INFO] [stdout] 4f43eefbc8eb6ea87c5d05350924fc2aab37f69631c95721a21573d4d4c25e73