[INFO] cloning repository https://github.com/LewisDaleUK/advent-of-code-2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LewisDaleUK/advent-of-code-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLewisDaleUK%2Fadvent-of-code-2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLewisDaleUK%2Fadvent-of-code-2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c683edfdda64a1fb473d227940fd12243da7d1ad [INFO] checking LewisDaleUK/advent-of-code-2022/c683edfdda64a1fb473d227940fd12243da7d1ad against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLewisDaleUK%2Fadvent-of-code-2022" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LewisDaleUK/advent-of-code-2022 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LewisDaleUK/advent-of-code-2022 [INFO] finished tweaking git repo https://github.com/LewisDaleUK/advent-of-code-2022 [INFO] tweaked toml for git repo https://github.com/LewisDaleUK/advent-of-code-2022 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LewisDaleUK/advent-of-code-2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ae0dc128ffd19d32fb141e31877bcec840333d01b62abf20f9bcd22e98360a5 [INFO] running `Command { std: "docker" "start" "-a" "4ae0dc128ffd19d32fb141e31877bcec840333d01b62abf20f9bcd22e98360a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ae0dc128ffd19d32fb141e31877bcec840333d01b62abf20f9bcd22e98360a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ae0dc128ffd19d32fb141e31877bcec840333d01b62abf20f9bcd22e98360a5", kill_on_drop: false }` [INFO] [stdout] 4ae0dc128ffd19d32fb141e31877bcec840333d01b62abf20f9bcd22e98360a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d2e8a50ae32ba7e6e99dd709b3eda71c4193b66e7fcd91508e044ba9f48d7ae [INFO] running `Command { std: "docker" "start" "-a" "1d2e8a50ae32ba7e6e99dd709b3eda71c4193b66e7fcd91508e044ba9f48d7ae", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking grid v0.9.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking advent-of-code-2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `delimited` and `many0` [INFO] [stdout] --> src/monkeys.rs:1:38 [INFO] [stdout] | [INFO] [stdout] 1 | ...{tuple, delimited, preceded}, character::complete::{space0, i32 as cci32, space1, one_of}, bytes::complete::tag, multi::{many0, separa... [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `delimited` and `many0` [INFO] [stdout] --> src/monkeys.rs:1:38 [INFO] [stdout] | [INFO] [stdout] 1 | ...{tuple, delimited, preceded}, character::complete::{space0, i32 as cci32, space1, one_of}, bytes::complete::tag, multi::{many0, separa... [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rope.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let mut last = self.knots.get_mut(i).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rope.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | let mut head = self.knots.first_mut().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rope.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let mut last = self.knots.get_mut(i).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rope.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | let mut head = self.knots.first_mut().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_size` is never used [INFO] [stdout] --> src/directory_parser.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Sizeable { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 11 | fn get_size(&self) -> usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `has_parent` is never used [INFO] [stdout] --> src/directory_parser.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub trait HasParent { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 37 | fn has_parent(&self, other: PathBuf) -> bool; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PathRoot` is never used [INFO] [stdout] --> src/file_node.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | trait PathRoot { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `distance` is never used [INFO] [stdout] --> src/rope.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | trait Vector { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 31 | fn distance(&self, other: Self) -> usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Normalize` is never used [INFO] [stdout] --> src/trees.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | trait Normalize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Add`, `Divide`, and `Multiply` are never constructed [INFO] [stdout] --> src/monkeys.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub enum Operation { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 12 | Add(OperationTarget), [INFO] [stdout] | ^^^ [INFO] [stdout] 13 | Divide(OperationTarget), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | Multiply(OperationTarget) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Operation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Value` and `Old` are never constructed [INFO] [stdout] --> src/monkeys.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum OperationTarget { [INFO] [stdout] | --------------- variants in this enum [INFO] [stdout] 19 | Value(i32), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 20 | Old, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OperationTarget` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Divisible` is never constructed [INFO] [stdout] --> src/monkeys.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub enum If { [INFO] [stdout] | -- variant in this enum [INFO] [stdout] 25 | Divisible(i32) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `If` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_items` is never used [INFO] [stdout] --> src/monkeys.rs:31:4 [INFO] [stdout] | [INFO] [stdout] 31 | fn parse_items(i: &str) -> IResult<&str, Vec> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_target` is never used [INFO] [stdout] --> src/monkeys.rs:40:4 [INFO] [stdout] | [INFO] [stdout] 40 | fn parse_target(i: &str) -> IResult<&str, OperationTarget> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_operation` is never used [INFO] [stdout] --> src/monkeys.rs:44:4 [INFO] [stdout] | [INFO] [stdout] 44 | fn parse_operation(i: &str) -> IResult<&str, Operation> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_test` is never used [INFO] [stdout] --> src/monkeys.rs:60:4 [INFO] [stdout] | [INFO] [stdout] 60 | fn parse_test(i: &str) -> IResult<&str, Test> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_monkey` is never used [INFO] [stdout] --> src/monkeys.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | fn parse_monkey(input: &str) -> IResult<&str, Monkey> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_node.rs:45:50 [INFO] [stdout] | [INFO] [stdout] 45 | .fold(0, |acc, (_, child)| acc + child.borrow_mut().get_size()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stacks.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|c| re.captures(c).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monkeys.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 61 | let parse_test = map(cci32, If::Divisible); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let parse_true = preceded(tuple((tag("\n"), space1, tag("If true: throw to monkey "))), cci32); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let parse_false = preceded(tuple((tag("\n"), space1, tag("If false: throw to monkey "))), cci32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | / preceded( [INFO] [stdout] 66 | | tuple((space1, tag("Test: divisible by "))), [INFO] [stdout] 67 | | tuple((parse_test, parse_true, parse_false)) [INFO] [stdout] 68 | | )(i) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code-2022` (bin "advent-of-code-2022") due to 4 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get_size` is never used [INFO] [stdout] --> src/directory_parser.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Sizeable { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 11 | fn get_size(&self) -> usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PathRoot` is never used [INFO] [stdout] --> src/file_node.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | trait PathRoot { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `distance` is never used [INFO] [stdout] --> src/rope.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | trait Vector { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 31 | fn distance(&self, other: Self) -> usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Normalize` is never used [INFO] [stdout] --> src/trees.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | trait Normalize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Divide` is never constructed [INFO] [stdout] --> src/monkeys.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub enum Operation { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 12 | Add(OperationTarget), [INFO] [stdout] 13 | Divide(OperationTarget), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Operation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_node.rs:45:50 [INFO] [stdout] | [INFO] [stdout] 45 | .fold(0, |acc, (_, child)| acc + child.borrow_mut().get_size()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stacks.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|c| re.captures(c).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monkeys.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 61 | let parse_test = map(cci32, If::Divisible); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let parse_true = preceded(tuple((tag("\n"), space1, tag("If true: throw to monkey "))), cci32); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let parse_false = preceded(tuple((tag("\n"), space1, tag("If false: throw to monkey "))), cci32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | / preceded( [INFO] [stdout] 66 | | tuple((space1, tag("Test: divisible by "))), [INFO] [stdout] 67 | | tuple((parse_test, parse_true, parse_false)) [INFO] [stdout] 68 | | )(i) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code-2022` (bin "advent-of-code-2022" test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1d2e8a50ae32ba7e6e99dd709b3eda71c4193b66e7fcd91508e044ba9f48d7ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d2e8a50ae32ba7e6e99dd709b3eda71c4193b66e7fcd91508e044ba9f48d7ae", kill_on_drop: false }` [INFO] [stdout] 1d2e8a50ae32ba7e6e99dd709b3eda71c4193b66e7fcd91508e044ba9f48d7ae