[INFO] cloning repository https://github.com/Levijatan/Voxel-Render [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Levijatan/Voxel-Render" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLevijatan%2FVoxel-Render", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLevijatan%2FVoxel-Render'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2534efde5fb42dc91e4b8c88c0f7c62823e9953f [INFO] checking Levijatan/Voxel-Render/2534efde5fb42dc91e4b8c88c0f7c62823e9953f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLevijatan%2FVoxel-Render" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Levijatan/Voxel-Render on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Levijatan/Voxel-Render [INFO] finished tweaking git repo https://github.com/Levijatan/Voxel-Render [INFO] tweaked toml for git repo https://github.com/Levijatan/Voxel-Render written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Levijatan/Voxel-Render already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4a4d6837daf398c49d591c361a1362b182023801c6984c1b3bba93ae0f8bb76 [INFO] running `Command { std: "docker" "start" "-a" "d4a4d6837daf398c49d591c361a1362b182023801c6984c1b3bba93ae0f8bb76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4a4d6837daf398c49d591c361a1362b182023801c6984c1b3bba93ae0f8bb76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4a4d6837daf398c49d591c361a1362b182023801c6984c1b3bba93ae0f8bb76", kill_on_drop: false }` [INFO] [stdout] d4a4d6837daf398c49d591c361a1362b182023801c6984c1b3bba93ae0f8bb76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf4661647e001e23327f8e2e843888233fca156e97fde8e61896b7c909df047d [INFO] running `Command { std: "docker" "start" "-a" "cf4661647e001e23327f8e2e843888233fca156e97fde8e61896b7c909df047d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling proc-macro2 v1.0.23 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling syn v1.0.42 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling cc v1.0.59 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling cmake v0.1.44 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling glfw-sys v3.3.2 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking simba v0.2.0 [INFO] [stderr] Checking generic-array v0.13.2 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling thread-id v3.3.0 [INFO] [stderr] Compiling lazy_static v0.2.11 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking nalgebra v0.22.0 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking bytemuck v1.4.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking image v0.23.9 [INFO] [stderr] Checking dashmap v3.11.10 [INFO] [stderr] Checking glfw v0.40.0 (https://github.com/bjz/glfw-rs.git#69c1912e) [INFO] [stderr] Checking nalgebra-glm v0.8.0 [INFO] [stderr] Compiling flame v0.2.2 [INFO] [stderr] Compiling flamer v0.3.0 [INFO] [stderr] Checking voxel-render v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `ambient`, `diffuse`, `specular`, and `shininess` are never read [INFO] [stdout] --> src/voxel_registry.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 15 | pub ambient: Vec3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub diffuse: Vec3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub specular: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub shininess: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Material` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mat` is never read [INFO] [stdout] --> src/voxel_registry.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct VoxelAttributes { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 23 | pub transparent: bool, [INFO] [stdout] 24 | pub mat: Material, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VoxelAttributes` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `world_type` is never used [INFO] [stdout] --> src/world.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait WorldType: Send + Sync { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 12 | fn gen_chunk(&self, key: &ChunkKey, reg: &VoxelReg) -> Vec; [INFO] [stdout] 13 | fn world_type(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `active` is never read [INFO] [stdout] --> src/world.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct World { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 55 | pub active: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_gen.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 57 | #[flame("ChunkGen")] [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | fn new(rx: Receiver, shared_state: super::SharedState) -> Self { [INFO] [stdout] | --------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | in_queue: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/chunk_updater.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 225 | drop(world); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&World` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 225 - drop(world); [INFO] [stdout] 225 + let _ = world; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 96 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | / self.c [INFO] [stdout] 104 | | .get(key) [INFO] [stdout] 105 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ambient`, `diffuse`, `specular`, and `shininess` are never read [INFO] [stdout] --> src/voxel_registry.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 15 | pub ambient: Vec3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub diffuse: Vec3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub specular: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub shininess: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Material` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mat` is never read [INFO] [stdout] --> src/voxel_registry.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct VoxelAttributes { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 23 | pub transparent: bool, [INFO] [stdout] 24 | pub mat: Material, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VoxelAttributes` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `world_type` is never used [INFO] [stdout] --> src/world.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait WorldType: Send + Sync { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 12 | fn gen_chunk(&self, key: &ChunkKey, reg: &VoxelReg) -> Vec; [INFO] [stdout] 13 | fn world_type(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `active` is never read [INFO] [stdout] --> src/world.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct World { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 55 | pub active: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_gen.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 57 | #[flame("ChunkGen")] [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | fn new(rx: Receiver, shared_state: super::SharedState) -> Self { [INFO] [stdout] | --------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | in_queue: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 109 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / self.c [INFO] [stdout] 118 | | .get(key) [INFO] [stdout] 119 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 123 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | pub fn voxel_to_world_pos(&self, key: &ChunkKey, voxel_pos: &Vec3) -> Vec3 { [INFO] [stdout] 125 | self.c.get(key).unwrap().voxel_to_world_pos(voxel_pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 128 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | pub fn voxel_pos_in_chunk(&self, key: &ChunkKey, voxel_pos: &Vec3) -> bool { [INFO] [stdout] 130 | / self.c [INFO] [stdout] 131 | | .get(key) [INFO] [stdout] 132 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 136 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | pub fn chunk_render(&self, key: &ChunkKey) -> Vec { [INFO] [stdout] 138 | self.c.get(key).unwrap().get_render_date().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/chunk_render.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 69 | #[flame("ChunkRender")] [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | pub unsafe fn new(state: &SharedState, chunk_update_rx: Receiver) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | state: state.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 60 | #[flame("World")] [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | pc: PointCloud::new(chunk_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 82 | #[flame("WorldTypeRegistry")] [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | world_type_reg: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 111 | #[flame("WorldRegistry")] [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | world_reg: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/chunk_updater.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 225 | drop(world); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&World` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 225 - drop(world); [INFO] [stdout] 225 + let _ = world; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 96 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | / self.c [INFO] [stdout] 104 | | .get(key) [INFO] [stdout] 105 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 109 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / self.c [INFO] [stdout] 118 | | .get(key) [INFO] [stdout] 119 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 123 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | pub fn voxel_to_world_pos(&self, key: &ChunkKey, voxel_pos: &Vec3) -> Vec3 { [INFO] [stdout] 125 | self.c.get(key).unwrap().voxel_to_world_pos(voxel_pos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 128 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | pub fn voxel_pos_in_chunk(&self, key: &ChunkKey, voxel_pos: &Vec3) -> bool { [INFO] [stdout] 130 | / self.c [INFO] [stdout] 131 | | .get(key) [INFO] [stdout] 132 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geom/point_cloud.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 136 | #[flame("PointCloud")] [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | pub fn chunk_render(&self, key: &ChunkKey) -> Vec { [INFO] [stdout] 138 | self.c.get(key).unwrap().get_render_date().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/chunk_render.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 69 | #[flame("ChunkRender")] [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | pub unsafe fn new(state: &SharedState, chunk_update_rx: Receiver) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | state: state.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 60 | #[flame("World")] [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | pc: PointCloud::new(chunk_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 82 | #[flame("WorldTypeRegistry")] [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | world_type_reg: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 111 | #[flame("WorldRegistry")] [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | world_reg: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `voxel-render` (bin "voxel-render") due to 11 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `voxel-render` (bin "voxel-render" test) due to 11 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cf4661647e001e23327f8e2e843888233fca156e97fde8e61896b7c909df047d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf4661647e001e23327f8e2e843888233fca156e97fde8e61896b7c909df047d", kill_on_drop: false }` [INFO] [stdout] cf4661647e001e23327f8e2e843888233fca156e97fde8e61896b7c909df047d