[INFO] cloning repository https://github.com/LesleyLai/rustgit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LesleyLai/rustgit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLesleyLai%2Frustgit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLesleyLai%2Frustgit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 670bfcc1f40208e23bff3be9b086bbe9dd5ef5d2 [INFO] checking LesleyLai/rustgit/670bfcc1f40208e23bff3be9b086bbe9dd5ef5d2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLesleyLai%2Frustgit" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LesleyLai/rustgit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LesleyLai/rustgit [INFO] finished tweaking git repo https://github.com/LesleyLai/rustgit [INFO] tweaked toml for git repo https://github.com/LesleyLai/rustgit written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LesleyLai/rustgit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a862efdb6a8cfe3ea0bc610c7e71d4daa574ea332f7c088e1b09c4c6f66bb3f6 [INFO] running `Command { std: "docker" "start" "-a" "a862efdb6a8cfe3ea0bc610c7e71d4daa574ea332f7c088e1b09c4c6f66bb3f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a862efdb6a8cfe3ea0bc610c7e71d4daa574ea332f7c088e1b09c4c6f66bb3f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a862efdb6a8cfe3ea0bc610c7e71d4daa574ea332f7c088e1b09c4c6f66bb3f6", kill_on_drop: false }` [INFO] [stdout] a862efdb6a8cfe3ea0bc610c7e71d4daa574ea332f7c088e1b09c4c6f66bb3f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 519f35d76cf365de5b2abc8656c370873e8b30fe8a520ccc6cceaaa0d0efbf74 [INFO] running `Command { std: "docker" "start" "-a" "519f35d76cf365de5b2abc8656c370873e8b30fe8a520ccc6cceaaa0d0efbf74", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking test_utils v0.1.0 (/opt/rustwide/workdir/crates/test_utils) [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking flate2 v1.0.29 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking insta v1.38.0 [INFO] [stderr] Checking rustgit v0.1.0 (/opt/rustwide/workdir/crates/rustgit) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/object/tree.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | read_tree_content(reader).map_err(|err| ObjectReadError::ContentReadError(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/database.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 55 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(ObjectReader::from_file(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/lockfile.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn commit(mut self) -> Result<(), LockfileError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let path = self.path.clone(); [INFO] [stdout] 34 | let file = self.file.take().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | fs::rename(&path, &no_extension_path).map_err(|err| LockfileError::from_io(err, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/object_reader.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_file(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ObjectReader(BufReader::new(ZlibDecoder::new(file))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustgit` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/object/tree.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | read_tree_content(reader).map_err(|err| ObjectReadError::ContentReadError(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/database.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 55 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(ObjectReader::from_file(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/lockfile.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn commit(mut self) -> Result<(), LockfileError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let path = self.path.clone(); [INFO] [stdout] 34 | let file = self.file.take().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | fs::rename(&path, &no_extension_path).map_err(|err| LockfileError::from_io(err, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/rustgit/src/object_reader.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_file(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ObjectReader(BufReader::new(ZlibDecoder::new(file))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustgit` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "519f35d76cf365de5b2abc8656c370873e8b30fe8a520ccc6cceaaa0d0efbf74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "519f35d76cf365de5b2abc8656c370873e8b30fe8a520ccc6cceaaa0d0efbf74", kill_on_drop: false }` [INFO] [stdout] 519f35d76cf365de5b2abc8656c370873e8b30fe8a520ccc6cceaaa0d0efbf74