[INFO] cloning repository https://github.com/Leonqn/unblock [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Leonqn/unblock" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeonqn%2Funblock", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeonqn%2Funblock'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cf6af922592d42e305d7df49dacfdf7dae74758c [INFO] checking Leonqn/unblock/cf6af922592d42e305d7df49dacfdf7dae74758c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLeonqn%2Funblock" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Leonqn/unblock on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Leonqn/unblock [INFO] finished tweaking git repo https://github.com/Leonqn/unblock [INFO] tweaked toml for git repo https://github.com/Leonqn/unblock written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Leonqn/unblock already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49015390d1ed59b04d02837c65abdf1e06a82cf326ab471ae3e4ee8048ee8478 [INFO] running `Command { std: "docker" "start" "-a" "49015390d1ed59b04d02837c65abdf1e06a82cf326ab471ae3e4ee8048ee8478", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49015390d1ed59b04d02837c65abdf1e06a82cf326ab471ae3e4ee8048ee8478", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49015390d1ed59b04d02837c65abdf1e06a82cf326ab471ae3e4ee8048ee8478", kill_on_drop: false }` [INFO] [stdout] 49015390d1ed59b04d02837c65abdf1e06a82cf326ab471ae3e4ee8048ee8478 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c1f135cdd5f5ba30ed31569925826117d9b24e77382767dd89507fcb68544f9 [INFO] running `Command { std: "docker" "start" "-a" "0c1f135cdd5f5ba30ed31569925826117d9b24e77382767dd89507fcb68544f9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking typenum v1.15.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking slab v0.4.7 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Compiling ucd-trie v0.1.4 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking rustls-pki-types v1.5.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling protobuf v2.27.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling async-trait v0.1.56 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling prometheus v0.13.1 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking crc32fast v1.3.2 [INFO] [stderr] Checking unicase v2.6.0 [INFO] [stderr] Checking winnow v0.6.7 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking mime_guess v2.0.4 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking headers v0.3.7 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking pretty_assertions v1.2.1 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking priority-queue v2.0.2 [INFO] [stderr] Checking arc-swap v1.5.1 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking rustls-webpki v0.102.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Compiling pest v2.2.1 [INFO] [stderr] Checking tungstenite v0.14.0 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Compiling pest_meta v2.2.1 [INFO] [stderr] Compiling pest_generator v2.2.1 [INFO] [stderr] Compiling pest_derive v2.2.1 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking async-compression v0.4.9 [INFO] [stderr] Checking tokio-tungstenite v0.15.0 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking fure v0.6.0 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking warp v0.3.2 [INFO] [stderr] Checking unblock v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|addr| tokio::spawn(start_metrics_server(addr))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:52 [INFO] [stdout] | [INFO] [stdout] 35 | let metrics_service = config [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | metrics = async { metrics_service.unwrap().await }, if metrics_service.is_some() => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:64:47 [INFO] [stdout] | [INFO] [stdout] 62 | let request_handler = move |query| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let dns_pipeline = dns_pipeline.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | async move { dns_pipeline.send(query).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 177 | .map(|c| Ok(Box::new(c?) as Box)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn with_get_time(time: GT) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | cache: PriorityQueue::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 12 | socket: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | futures_util::stream::unfold((socket, buf), |(socket, mut buf)| async move { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 15 | futures_util::stream::unfold((socket, buf), |(socket, mut buf)| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let recv = async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Some((recv.await, (socket, buf))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok((sender, Bytes::copy_from_slice(&buf[0..read]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/ads_block.rs:31:60 [INFO] [stdout] | [INFO] [stdout] 31 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | | let parsed_query = query.parse()?; [INFO] [stdout] 33 | | let domains_filter = self.domains_filter.item(); [INFO] [stdout] 34 | | let match_result = parsed_query.domains().find_map(|domain| { [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(dns_client: C) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | cache: RwLock::new(Cache::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 32 | let cache = self.cache.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cached_response = cache.get(&query.bytes().slice(2..))?; [INFO] [stdout] 34 | let mut response = BytesMut::from(cached_response.as_ref()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | response[0..2].copy_from_slice(&query.bytes()[0..2]); [INFO] [stdout] 36 | Some(Response::from_bytes(response.freeze()).expect("Must be valid response")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:55:60 [INFO] [stdout] | [INFO] [stdout] 55 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | match self.get_from_cache(&query) { [INFO] [stdout] 57 | | Some(response) => { [INFO] [stdout] 58 | | METRICS.cache_hits.inc(); [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/choice.rs:35:60 [INFO] [stdout] | [INFO] [stdout] 35 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | let through_first = query [INFO] [stdout] 37 | | .parse()? [INFO] [stdout] 38 | | .domains() [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/doh.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 16 | let mut headers = HeaderMap::with_capacity(2); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let http_client = Client::builder() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | http_client, [INFO] [stdout] 32 | | server_url, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/doh.rs:39:60 [INFO] [stdout] | [INFO] [stdout] 39 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | let response = self [INFO] [stdout] 41 | | .http_client [INFO] [stdout] 42 | | .post(self.server_url.clone()) [INFO] [stdout] ... | [INFO] [stdout] 48 | | Response::from_bytes(response) [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/either.rs:14:60 [INFO] [stdout] | [INFO] [stdout] 14 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | | match self { [INFO] [stdout] 16 | | Either::Left(l) => l.send(query).await, [INFO] [stdout] 17 | | Either::Right(r) => r.send(query).await, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/retry.rs:27:60 [INFO] [stdout] | [INFO] [stdout] 27 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | | fure::retry( [INFO] [stdout] 29 | | || self.client.send(query.clone()), [INFO] [stdout] 30 | | attempts(interval(self.next_attempt_delay), self.attempts_count), [INFO] [stdout] 31 | | ) [INFO] [stdout] 32 | | .await [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/retry.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | || self.client.send(query.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/round_robin.rs:24:60 [INFO] [stdout] | [INFO] [stdout] 24 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | | let client_idx = self.counter.fetch_add(1, Ordering::SeqCst) % self.clients.len(); [INFO] [stdout] 26 | | let client = &self.clients[client_idx]; [INFO] [stdout] 27 | | client.send(query).await [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/udp.rs:43:60 [INFO] [stdout] | [INFO] [stdout] 43 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | let (response_tx, response_rx) = oneshot::channel(); [INFO] [stdout] 45 | | self.responses [INFO] [stdout] 46 | | .send(Request { [INFO] [stdout] ... | [INFO] [stdout] 51 | | response_rx.await.expect("Should always receive response") [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|blacklist| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / parsed_response [INFO] [stdout] 55 | | .domains() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|blacklist| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .any(move |domain| is_blacklisted(&domain, &blacklist, &manual_dns_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:70:60 [INFO] [stdout] | [INFO] [stdout] 70 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | | let dns_response = self.client.send(query).await?; [INFO] [stdout] 72 | | let parsed_response = dns_response.parse()?; [INFO] [stdout] 73 | | let blocked = self.get_blocked(&parsed_response); [INFO] [stdout] ... | [INFO] [stdout] 85 | | Ok(dns_response) [INFO] [stdout] 86 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | let parse_header = tuple((be_u16, parse_flags, be_u16, be_u16, be_u16, be_u16)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / map( [INFO] [stdout] 45 | | parse_header, [INFO] [stdout] 46 | | |( [INFO] [stdout] 47 | | id, [INFO] [stdout] ... | [INFO] [stdout] 60 | | }, [INFO] [stdout] 61 | | )(packet) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 90 | let parse_ttl = map(be_u32, |ttl| Duration::from_secs(ttl as u64)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let parse_r_data = flat_map(be_u16, take); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let resource_record = tuple(( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / map_opt(resource_record, |(name, type_, class, ttl, r_data)| { [INFO] [stdout] 100 | | ResourceRecord::from_raw(name, type_, class, ttl, r_data) [INFO] [stdout] 101 | | })(records) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 123 | let parse_question = tuple((parse_name, be_u16, be_u16)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | / map(parse_question, |(name, type_, class)| Question { [INFO] [stdout] 125 | | name, [INFO] [stdout] 126 | | type_, [INFO] [stdout] 127 | | class, [INFO] [stdout] 128 | | })(questions) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 136 | let parser = tuple(( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | map(bits(parser), |(_, pointer)| pointer)(label_part) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 148 | let qr_flag = bits(nom::bits::complete::take::<_, u8, _, nom::error::Error<_>>( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / map(tuple((qr_flag, be_u8)), |(qr_flag, _)| { [INFO] [stdout] 152 | | if qr_flag == 0 { [INFO] [stdout] 153 | | Flags { [INFO] [stdout] 154 | | message_type: MessageType::Query, [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] 161 | | })(flags) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains_filter.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 52 | let (allow, block) = rules [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let allow_matcher = RulesMatcher::new(allow); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let block_matcher = RulesMatcher::new(block); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | allow_matcher, [INFO] [stdout] 64 | | block_matcher, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files_stream.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | let http = Client::builder().gzip(true).build()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(stream::unfold( [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | (http, None, file_url, true), [INFO] [stdout] 17 | | move |(http, etag, url, first_request)| async move { [INFO] [stdout] 18 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 39 | | }, [INFO] [stdout] 40 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unblock` (bin "unblock") due to 31 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|addr| tokio::spawn(start_metrics_server(addr))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:52 [INFO] [stdout] | [INFO] [stdout] 35 | let metrics_service = config [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | metrics = async { metrics_service.unwrap().await }, if metrics_service.is_some() => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:64:47 [INFO] [stdout] | [INFO] [stdout] 62 | let request_handler = move |query| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let dns_pipeline = dns_pipeline.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | async move { dns_pipeline.send(query).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 177 | .map(|c| Ok(Box::new(c?) as Box)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn with_get_time(time: GT) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | cache: PriorityQueue::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 12 | socket: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | futures_util::stream::unfold((socket, buf), |(socket, mut buf)| async move { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 15 | futures_util::stream::unfold((socket, buf), |(socket, mut buf)| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let recv = async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Some((recv.await, (socket, buf))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/mod.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | Ok((sender, Bytes::copy_from_slice(&buf[0..read]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/ads_block.rs:31:60 [INFO] [stdout] | [INFO] [stdout] 31 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | | let parsed_query = query.parse()?; [INFO] [stdout] 33 | | let domains_filter = self.domains_filter.item(); [INFO] [stdout] 34 | | let match_result = parsed_query.domains().find_map(|domain| { [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(dns_client: C) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | cache: RwLock::new(Cache::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 32 | let cache = self.cache.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cached_response = cache.get(&query.bytes().slice(2..))?; [INFO] [stdout] 34 | let mut response = BytesMut::from(cached_response.as_ref()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | response[0..2].copy_from_slice(&query.bytes()[0..2]); [INFO] [stdout] 36 | Some(Response::from_bytes(response.freeze()).expect("Must be valid response")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:55:60 [INFO] [stdout] | [INFO] [stdout] 55 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | match self.get_from_cache(&query) { [INFO] [stdout] 57 | | Some(response) => { [INFO] [stdout] 58 | | METRICS.cache_hits.inc(); [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/cache.rs:104:75 [INFO] [stdout] | [INFO] [stdout] 104 | async fn send(&self, _request: Query) -> anyhow::Result { [INFO] [stdout] | ______________________________---------------______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | | if self [INFO] [stdout] 106 | | .is_called [INFO] [stdout] 107 | | .fetch_and(true, std::sync::atomic::Ordering::Relaxed) [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/choice.rs:35:60 [INFO] [stdout] | [INFO] [stdout] 35 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | let through_first = query [INFO] [stdout] 37 | | .parse()? [INFO] [stdout] 38 | | .domains() [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/doh.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 16 | let mut headers = HeaderMap::with_capacity(2); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let http_client = Client::builder() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | http_client, [INFO] [stdout] 32 | | server_url, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/doh.rs:39:60 [INFO] [stdout] | [INFO] [stdout] 39 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | let response = self [INFO] [stdout] 41 | | .http_client [INFO] [stdout] 42 | | .post(self.server_url.clone()) [INFO] [stdout] ... | [INFO] [stdout] 48 | | Response::from_bytes(response) [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/either.rs:14:60 [INFO] [stdout] | [INFO] [stdout] 14 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | | match self { [INFO] [stdout] 16 | | Either::Left(l) => l.send(query).await, [INFO] [stdout] 17 | | Either::Right(r) => r.send(query).await, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/retry.rs:27:60 [INFO] [stdout] | [INFO] [stdout] 27 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | | fure::retry( [INFO] [stdout] 29 | | || self.client.send(query.clone()), [INFO] [stdout] 30 | | attempts(interval(self.next_attempt_delay), self.attempts_count), [INFO] [stdout] 31 | | ) [INFO] [stdout] 32 | | .await [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/retry.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | || self.client.send(query.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/round_robin.rs:24:60 [INFO] [stdout] | [INFO] [stdout] 24 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | | let client_idx = self.counter.fetch_add(1, Ordering::SeqCst) % self.clients.len(); [INFO] [stdout] 26 | | let client = &self.clients[client_idx]; [INFO] [stdout] 27 | | client.send(query).await [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/udp.rs:43:60 [INFO] [stdout] | [INFO] [stdout] 43 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | let (response_tx, response_rx) = oneshot::channel(); [INFO] [stdout] 45 | | self.responses [INFO] [stdout] 46 | | .send(Request { [INFO] [stdout] ... | [INFO] [stdout] 51 | | response_rx.await.expect("Should always receive response") [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|blacklist| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / parsed_response [INFO] [stdout] 55 | | .domains() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|blacklist| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .any(move |domain| is_blacklisted(&domain, &blacklist, &manual_dns_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/client/unblock.rs:70:60 [INFO] [stdout] | [INFO] [stdout] 70 | async fn send(&self, query: Query) -> Result { [INFO] [stdout] | __________________________------------______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | | let dns_response = self.client.send(query).await?; [INFO] [stdout] 72 | | let parsed_response = dns_response.parse()?; [INFO] [stdout] 73 | | let blocked = self.get_blocked(&parsed_response); [INFO] [stdout] ... | [INFO] [stdout] 85 | | Ok(dns_response) [INFO] [stdout] 86 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | let parse_header = tuple((be_u16, parse_flags, be_u16, be_u16, be_u16, be_u16)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | / map( [INFO] [stdout] 45 | | parse_header, [INFO] [stdout] 46 | | |( [INFO] [stdout] 47 | | id, [INFO] [stdout] ... | [INFO] [stdout] 60 | | }, [INFO] [stdout] 61 | | )(packet) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 90 | let parse_ttl = map(be_u32, |ttl| Duration::from_secs(ttl as u64)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let parse_r_data = flat_map(be_u16, take); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let resource_record = tuple(( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / map_opt(resource_record, |(name, type_, class, ttl, r_data)| { [INFO] [stdout] 100 | | ResourceRecord::from_raw(name, type_, class, ttl, r_data) [INFO] [stdout] 101 | | })(records) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 123 | let parse_question = tuple((parse_name, be_u16, be_u16)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | / map(parse_question, |(name, type_, class)| Question { [INFO] [stdout] 125 | | name, [INFO] [stdout] 126 | | type_, [INFO] [stdout] 127 | | class, [INFO] [stdout] 128 | | })(questions) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 136 | let parser = tuple(( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | map(bits(parser), |(_, pointer)| pointer)(label_part) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/message/parsers.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 148 | let qr_flag = bits(nom::bits::complete::take::<_, u8, _, nom::error::Error<_>>( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / map(tuple((qr_flag, be_u8)), |(qr_flag, _)| { [INFO] [stdout] 152 | | if qr_flag == 0 { [INFO] [stdout] 153 | | Flags { [INFO] [stdout] 154 | | message_type: MessageType::Query, [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] 161 | | })(flags) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains_filter.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 52 | let (allow, block) = rules [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let allow_matcher = RulesMatcher::new(allow); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let block_matcher = RulesMatcher::new(block); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | allow_matcher, [INFO] [stdout] 64 | | block_matcher, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files_stream.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | let http = Client::builder().gzip(true).build()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(stream::unfold( [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | (http, None, file_url, true), [INFO] [stdout] 17 | | move |(http, etag, url, first_request)| async move { [INFO] [stdout] 18 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 39 | | }, [INFO] [stdout] 40 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unblock.rs:302:26 [INFO] [stdout] | [INFO] [stdout] 301 | let unblocker = unblocker.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | async move { unblocker.unblock(vec![blacklisted_ip], "").await.unwrap() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unblock.rs:307:26 [INFO] [stdout] | [INFO] [stdout] 306 | let unblocker = unblocker.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | async move { unblocker.unblock(vec![blacklisted_ip], "").await.unwrap() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:270:24 [INFO] [stdout] | [INFO] [stdout] 270 | .map(|request| Query::from_bytes(Bytes::from_static(request)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 34 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unblock` (bin "unblock" test) due to 35 previous errors [INFO] running `Command { std: "docker" "inspect" "0c1f135cdd5f5ba30ed31569925826117d9b24e77382767dd89507fcb68544f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c1f135cdd5f5ba30ed31569925826117d9b24e77382767dd89507fcb68544f9", kill_on_drop: false }` [INFO] [stdout] 0c1f135cdd5f5ba30ed31569925826117d9b24e77382767dd89507fcb68544f9