[INFO] cloning repository https://github.com/LawnGnome/git2cvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LawnGnome/git2cvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLawnGnome%2Fgit2cvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLawnGnome%2Fgit2cvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cd5be24bd082cd05fe2d6887c65ff39310236934 [INFO] checking LawnGnome/git2cvs/cd5be24bd082cd05fe2d6887c65ff39310236934 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLawnGnome%2Fgit2cvs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LawnGnome/git2cvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LawnGnome/git2cvs [INFO] finished tweaking git repo https://github.com/LawnGnome/git2cvs [INFO] tweaked toml for git repo https://github.com/LawnGnome/git2cvs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LawnGnome/git2cvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b065bbc9c260340b0442c0447ec44b43aedb9b064be3ec8a62d7e43342fbff75 [INFO] running `Command { std: "docker" "start" "-a" "b065bbc9c260340b0442c0447ec44b43aedb9b064be3ec8a62d7e43342fbff75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b065bbc9c260340b0442c0447ec44b43aedb9b064be3ec8a62d7e43342fbff75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b065bbc9c260340b0442c0447ec44b43aedb9b064be3ec8a62d7e43342fbff75", kill_on_drop: false }` [INFO] [stdout] b065bbc9c260340b0442c0447ec44b43aedb9b064be3ec8a62d7e43342fbff75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5202968066c27d09f5be4fc0551452aeaad5d974f252a8c52e2b7eacba4a3788 [INFO] running `Command { std: "docker" "start" "-a" "5202968066c27d09f5be4fc0551452aeaad5d974f252a8c52e2b7eacba4a3788", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling libsqlite3-sys v0.22.2 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling tinyvec_macros v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling once_cell v1.8.0 [INFO] [stderr] Compiling matches v0.1.8 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Compiling unicode-bidi v0.3.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Compiling form_urlencoded v1.0.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling smallvec v1.6.1 [INFO] [stderr] Compiling fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling fallible-iterator v0.2.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling jobserver v0.1.23 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ahash v0.7.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling siphasher v0.3.6 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking hashlink v0.7.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking errno v0.2.7 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking sysconf v0.3.4 [INFO] [stderr] Checking subprocess v0.2.7 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling rusqlite v0.25.3 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Compiling openssl-sys v0.9.65 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libssh2-sys v0.2.21 [INFO] [stderr] Compiling libgit2-sys v0.12.21+1.1.0 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Compiling thiserror v1.0.26 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Checking git2 v0.13.20 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking refinery-core v0.6.0 [INFO] [stderr] Compiling refinery-macros v0.6.0 [INFO] [stderr] Checking refinery v0.6.0 [INFO] [stderr] Checking git2cvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `remove` is never used [INFO] [stdout] --> src/cvs.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Repository { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn remove(&self, path: &OsStr) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/git.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl Branch<'_> { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn name(&self) -> anyhow::Result<&str> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `remove` is never used [INFO] [stdout] --> src/cvs.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Repository { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn remove(&self, path: &OsStr) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/git.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl Branch<'_> { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn name(&self) -> anyhow::Result<&str> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | |path, entry| match walk_tree_entry( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 103 | | path, [INFO] [stdout] 104 | | entry, [INFO] [stdout] 105 | | &commit, [INFO] [stdout] ... | [INFO] [stdout] 108 | | &repo, [INFO] [stdout] 109 | | ) { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut conn = Connection::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Self { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 12 | | repo: git2::Repository::open(path)?, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | |path, entry| match walk_tree_entry( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 103 | | path, [INFO] [stdout] 104 | | entry, [INFO] [stdout] 105 | | &commit, [INFO] [stdout] ... | [INFO] [stdout] 108 | | &repo, [INFO] [stdout] 109 | | ) { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut conn = Connection::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Self { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 12 | | repo: git2::Repository::open(path)?, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git2cvs` (bin "git2cvs" test) due to 4 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `git2cvs` (bin "git2cvs") due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5202968066c27d09f5be4fc0551452aeaad5d974f252a8c52e2b7eacba4a3788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5202968066c27d09f5be4fc0551452aeaad5d974f252a8c52e2b7eacba4a3788", kill_on_drop: false }` [INFO] [stdout] 5202968066c27d09f5be4fc0551452aeaad5d974f252a8c52e2b7eacba4a3788