[INFO] cloning repository https://github.com/Lauriethefish/FactorioComputer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lauriethefish/FactorioComputer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauriethefish%2FFactorioComputer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauriethefish%2FFactorioComputer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 055291ec32e81f0f90cd789a1bfacac9f6c267ec [INFO] checking Lauriethefish/FactorioComputer/055291ec32e81f0f90cd789a1bfacac9f6c267ec against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauriethefish%2FFactorioComputer" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Lauriethefish/FactorioComputer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Lauriethefish/FactorioComputer [INFO] finished tweaking git repo https://github.com/Lauriethefish/FactorioComputer [INFO] tweaked toml for git repo https://github.com/Lauriethefish/FactorioComputer written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Lauriethefish/FactorioComputer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67bd957a2d9dc47a772b1b0330873ebbff4c45f5c681a4ff2c2851e4f0d835c9 [INFO] running `Command { std: "docker" "start" "-a" "67bd957a2d9dc47a772b1b0330873ebbff4c45f5c681a4ff2c2851e4f0d835c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67bd957a2d9dc47a772b1b0330873ebbff4c45f5c681a4ff2c2851e4f0d835c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67bd957a2d9dc47a772b1b0330873ebbff4c45f5c681a4ff2c2851e4f0d835c9", kill_on_drop: false }` [INFO] [stdout] 67bd957a2d9dc47a772b1b0330873ebbff4c45f5c681a4ff2c2851e4f0d835c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2480a91d43b1082c34eaf2ee59669e2b1a377489c279e77161e5d694d30883b [INFO] running `Command { std: "docker" "start" "-a" "a2480a91d43b1082c34eaf2ee59669e2b1a377489c279e77161e5d694d30883b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking lflc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 94 | let start_token = self.tokens[from].1.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let end_token = self.tokens[to].1.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | file: start_token.file.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:332:8 [INFO] [stdout] | [INFO] [stdout] 307 | let name_ref = iter.prev_token_ref(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let block = parse_block(iter)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | Ok(Function { [INFO] [stdout] | ________^ [INFO] [stdout] 333 | | name, [INFO] [stdout] 334 | | argument_names, [INFO] [stdout] 335 | | block, [INFO] [stdout] 336 | | returns_value, [INFO] [stdout] 337 | | name_ref [INFO] [stdout] 338 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:557:8 [INFO] [stdout] | [INFO] [stdout] 506 | let mut expressions = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Ok(expressions.into_iter().next().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_handling.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | Err($crate::error_handling::CompileErrors(vec![$crate::error_handling::FileTaggedError { [INFO] [stdout] | _____________^ [INFO] [stdout] 101 | | position: Some($position), [INFO] [stdout] 102 | | msg: format!($($arg)*) [INFO] [stdout] 103 | | }])) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] ::: src/compiler.rs:119:46 [INFO] [stdout] | [INFO] [stdout] 119 | fn get_variable_pos(&self, name: String, name_ref: FileRef) -> CompileResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | error!(name_ref, "No variable exists with this name") [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_handling.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | Err($crate::error_handling::CompileErrors(vec![$crate::error_handling::FileTaggedError { [INFO] [stdout] | _____________^ [INFO] [stdout] 101 | | position: Some($position), [INFO] [stdout] 102 | | msg: format!($($arg)*) [INFO] [stdout] 103 | | }])) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] ::: src/compiler.rs:422:50 [INFO] [stdout] | [INFO] [stdout] 422 | fn try_emit_loop_control_flow(is_continue: bool, keyword_ref: FileRef, ctx: &mut CompileCtx) -> CompileResult<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | error!(keyword_ref, "Not in a loop scope - cannot use break or continue keywords") [INFO] [stdout] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lflc` (bin "lflc") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 94 | let start_token = self.tokens[from].1.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let end_token = self.tokens[to].1.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | file: start_token.file.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:332:8 [INFO] [stdout] | [INFO] [stdout] 307 | let name_ref = iter.prev_token_ref(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let block = parse_block(iter)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | Ok(Function { [INFO] [stdout] | ________^ [INFO] [stdout] 333 | | name, [INFO] [stdout] 334 | | argument_names, [INFO] [stdout] 335 | | block, [INFO] [stdout] 336 | | returns_value, [INFO] [stdout] 337 | | name_ref [INFO] [stdout] 338 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:557:8 [INFO] [stdout] | [INFO] [stdout] 506 | let mut expressions = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Ok(expressions.into_iter().next().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_handling.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | Err($crate::error_handling::CompileErrors(vec![$crate::error_handling::FileTaggedError { [INFO] [stdout] | _____________^ [INFO] [stdout] 101 | | position: Some($position), [INFO] [stdout] 102 | | msg: format!($($arg)*) [INFO] [stdout] 103 | | }])) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] ::: src/compiler.rs:119:46 [INFO] [stdout] | [INFO] [stdout] 119 | fn get_variable_pos(&self, name: String, name_ref: FileRef) -> CompileResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | error!(name_ref, "No variable exists with this name") [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_handling.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | Err($crate::error_handling::CompileErrors(vec![$crate::error_handling::FileTaggedError { [INFO] [stdout] | _____________^ [INFO] [stdout] 101 | | position: Some($position), [INFO] [stdout] 102 | | msg: format!($($arg)*) [INFO] [stdout] 103 | | }])) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] ::: src/compiler.rs:422:50 [INFO] [stdout] | [INFO] [stdout] 422 | fn try_emit_loop_control_flow(is_continue: bool, keyword_ref: FileRef, ctx: &mut CompileCtx) -> CompileResult<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | error!(keyword_ref, "Not in a loop scope - cannot use break or continue keywords") [INFO] [stdout] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lflc` (bin "lflc" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "a2480a91d43b1082c34eaf2ee59669e2b1a377489c279e77161e5d694d30883b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2480a91d43b1082c34eaf2ee59669e2b1a377489c279e77161e5d694d30883b", kill_on_drop: false }` [INFO] [stdout] a2480a91d43b1082c34eaf2ee59669e2b1a377489c279e77161e5d694d30883b