[INFO] cloning repository https://github.com/Lauchmelder23/rusty-nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Lauchmelder23/rusty-nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d40fc7588bce1793781a9768759d8ad8b7bbf4b6 [INFO] checking Lauchmelder23/rusty-nes/d40fc7588bce1793781a9768759d8ad8b7bbf4b6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLauchmelder23%2Frusty-nes" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Lauchmelder23/rusty-nes on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Lauchmelder23/rusty-nes [INFO] finished tweaking git repo https://github.com/Lauchmelder23/rusty-nes [INFO] tweaked toml for git repo https://github.com/Lauchmelder23/rusty-nes written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Lauchmelder23/rusty-nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b75ab43c7b8be6a80b3c1f1a4a7af8bb6ae93706129f702d3df3a80bbb9f5a8 [INFO] running `Command { std: "docker" "start" "-a" "0b75ab43c7b8be6a80b3c1f1a4a7af8bb6ae93706129f702d3df3a80bbb9f5a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b75ab43c7b8be6a80b3c1f1a4a7af8bb6ae93706129f702d3df3a80bbb9f5a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b75ab43c7b8be6a80b3c1f1a4a7af8bb6ae93706129f702d3df3a80bbb9f5a8", kill_on_drop: false }` [INFO] [stdout] 0b75ab43c7b8be6a80b3c1f1a4a7af8bb6ae93706129f702d3df3a80bbb9f5a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6ec58bd67f5f05d5d1310a5361d5b5f12b799c7f22e06bdef2fb37b81eb38b1 [INFO] running `Command { std: "docker" "start" "-a" "e6ec58bd67f5f05d5d1310a5361d5b5f12b799c7f22e06bdef2fb37b81eb38b1", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Compiling cmake v0.1.48 [INFO] [stderr] Compiling glfw-sys v4.0.0+3.3.5 [INFO] [stderr] Compiling rusty-nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking glfw v0.45.0 [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/nes.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct NES [INFO] [stdout] | --- field in this struct [INFO] [stdout] 8 | { [INFO] [stdout] 9 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clock` and `single_step` are never used [INFO] [stdout] --> src/nes/nes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 31 | impl NES [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn clock(&self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn single_step(&self) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sync` is never used [INFO] [stdout] --> src/nes/cpu.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 33 | impl CPU [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn sync(&self) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/ppu.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct PPU [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Weak> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cli` and `brk` are never used [INFO] [stdout] --> src/nes/instructions.rs:357:15 [INFO] [stdout] | [INFO] [stdout] 313 | impl CPU [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 357 | set_flag_fn!(cli, Bit::Interrupt, false); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 544 | fn brk(&mut self) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_flag_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | |glfw, name| (&mut *(glfw as *mut glfw::Glfw)).get_proc_address_raw(CStr::from_ptr(name).to_str().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-nes` (bin "rusty-nes") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/ppu.rs:27:44 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn set_regsiter(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bus` [INFO] [stdout] --> src/nes/instructions.rs:546:7 [INFO] [stdout] | [INFO] [stdout] 546 | let bus = self.bus.upgrade().unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_bus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes/cartridge.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/nes/cartridge.rs:56:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn write_prg(&mut self, addr: u16, val: u8) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/nes.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct NES [INFO] [stdout] | --- field in this struct [INFO] [stdout] 8 | { [INFO] [stdout] 9 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clock` and `single_step` are never used [INFO] [stdout] --> src/nes/nes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 31 | impl NES [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn clock(&self) [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn single_step(&self) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sync` is never used [INFO] [stdout] --> src/nes/cpu.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 33 | impl CPU [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn sync(&self) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/nes/ppu.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct PPU [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Weak> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cli` and `brk` are never used [INFO] [stdout] --> src/nes/instructions.rs:357:15 [INFO] [stdout] | [INFO] [stdout] 313 | impl CPU [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 357 | set_flag_fn!(cli, Bit::Interrupt, false); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 544 | fn brk(&mut self) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_flag_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | |glfw, name| (&mut *(glfw as *mut glfw::Glfw)).get_proc_address_raw(CStr::from_ptr(name).to_str().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-nes` (bin "rusty-nes" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e6ec58bd67f5f05d5d1310a5361d5b5f12b799c7f22e06bdef2fb37b81eb38b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6ec58bd67f5f05d5d1310a5361d5b5f12b799c7f22e06bdef2fb37b81eb38b1", kill_on_drop: false }` [INFO] [stdout] e6ec58bd67f5f05d5d1310a5361d5b5f12b799c7f22e06bdef2fb37b81eb38b1