[INFO] cloning repository https://github.com/LaCumbancha/gold-miner [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LaCumbancha/gold-miner" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLaCumbancha%2Fgold-miner", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLaCumbancha%2Fgold-miner'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c6efcdce112a00e79fac67de17ffdc2f3119509f [INFO] checking LaCumbancha/gold-miner/c6efcdce112a00e79fac67de17ffdc2f3119509f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLaCumbancha%2Fgold-miner" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LaCumbancha/gold-miner on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LaCumbancha/gold-miner [INFO] finished tweaking git repo https://github.com/LaCumbancha/gold-miner [INFO] tweaked toml for git repo https://github.com/LaCumbancha/gold-miner written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LaCumbancha/gold-miner already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34696a9aa9e856d15ee44daf1bafad7803026ac419524141138333774068f36e [INFO] running `Command { std: "docker" "start" "-a" "34696a9aa9e856d15ee44daf1bafad7803026ac419524141138333774068f36e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34696a9aa9e856d15ee44daf1bafad7803026ac419524141138333774068f36e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34696a9aa9e856d15ee44daf1bafad7803026ac419524141138333774068f36e", kill_on_drop: false }` [INFO] [stdout] 34696a9aa9e856d15ee44daf1bafad7803026ac419524141138333774068f36e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69c67debfe4526f54781341b13fecfba8da4e73f50243fa69f5e13fb8e370f59 [INFO] running `Command { std: "docker" "start" "-a" "69c67debfe4526f54781341b13fecfba8da4e73f50243fa69f5e13fb8e370f59", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking termion v1.5.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking TP2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `gold_total` [INFO] [stdout] --> src/model/miner.rs:98:45 [INFO] [stdout] | [INFO] [stdout] 98 | fn save_result(&mut self, (id, gold_dug,gold_total): RoundResults) -> bool { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gold_total` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/foreman.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(sections: i32, logger: Logger) -> Foreman { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let (channel_in_foreman, channel_out_foreman): (Sender, Receiver) = channel(); [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | miners_channels: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gold_total` [INFO] [stdout] --> src/model/miner.rs:98:45 [INFO] [stdout] | [INFO] [stdout] 98 | fn save_result(&mut self, (id, gold_dug,gold_total): RoundResults) -> bool { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gold_total` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(id: MinerId, channel_out: Receiver, miners: HashMap>, logger: Logger) -> Min... [INFO] [stdout] | ------------------------------------ ----------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | round: RoundStats { [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | results_received: HashMap::new(), [INFO] [stdout] 47 | | gold_dug: Arc::new(Mutex::new(0 as Gold)), [INFO] [stdout] 48 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 38 | ...(id: MinerId, channel_out: Receiver, miners: HashMap>, logger: Logger) -> Miner { [INFO] [stdout] | ------------------------------------ ----------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ...ep_mining: Arc::new(Mutex::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | Miner::send_callback(*id, self.logger.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `TP2` (bin "TP2") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/foreman.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(sections: i32, logger: Logger) -> Foreman { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let (channel_in_foreman, channel_out_foreman): (Sender, Receiver) = channel(); [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | miners_channels: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(id: MinerId, channel_out: Receiver, miners: HashMap>, logger: Logger) -> Min... [INFO] [stdout] | ------------------------------------ ----------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | round: RoundStats { [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | results_received: HashMap::new(), [INFO] [stdout] 47 | | gold_dug: Arc::new(Mutex::new(0 as Gold)), [INFO] [stdout] 48 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 38 | ...(id: MinerId, channel_out: Receiver, miners: HashMap>, logger: Logger) -> Miner { [INFO] [stdout] | ------------------------------------ ----------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ...ep_mining: Arc::new(Mutex::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/miner.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | Miner::send_callback(*id, self.logger.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `TP2` (bin "TP2" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "69c67debfe4526f54781341b13fecfba8da4e73f50243fa69f5e13fb8e370f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69c67debfe4526f54781341b13fecfba8da4e73f50243fa69f5e13fb8e370f59", kill_on_drop: false }` [INFO] [stdout] 69c67debfe4526f54781341b13fecfba8da4e73f50243fa69f5e13fb8e370f59