[INFO] cloning repository https://github.com/LUK3ARK/sqwit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LUK3ARK/sqwit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLUK3ARK%2Fsqwit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLUK3ARK%2Fsqwit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce3bb9c87d63b429d26bc0523ecd17d6bd2eb433 [INFO] checking LUK3ARK/sqwit/ce3bb9c87d63b429d26bc0523ecd17d6bd2eb433 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLUK3ARK%2Fsqwit" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LUK3ARK/sqwit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LUK3ARK/sqwit [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/LUK3ARK/sqwit [INFO] tweaked toml for git repo https://github.com/LUK3ARK/sqwit written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LUK3ARK/sqwit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb0442db8a66b946dc295180804f029cb77eb7b4fae04e3c6a9b4ebd55dc4622 [INFO] running `Command { std: "docker" "start" "-a" "cb0442db8a66b946dc295180804f029cb77eb7b4fae04e3c6a9b4ebd55dc4622", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb0442db8a66b946dc295180804f029cb77eb7b4fae04e3c6a9b4ebd55dc4622", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb0442db8a66b946dc295180804f029cb77eb7b4fae04e3c6a9b4ebd55dc4622", kill_on_drop: false }` [INFO] [stdout] cb0442db8a66b946dc295180804f029cb77eb7b4fae04e3c6a9b4ebd55dc4622 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f89b7a1b674e231677234daeddb498869abf0fb9dfd281080b837ed0054f0faf [INFO] running `Command { std: "docker" "start" "-a" "f89b7a1b674e231677234daeddb498869abf0fb9dfd281080b837ed0054f0faf", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling id-arena v2.2.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling wit-bindgen-rust v0.29.0 [INFO] [stderr] Compiling wit-bindgen-rt v0.29.0 [INFO] [stderr] Compiling wit-bindgen-rust-macro v0.29.0 [INFO] [stderr] Checking sqlparser v0.49.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling spdx v0.10.6 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling indexmap v2.3.0 [INFO] [stderr] Compiling wasmparser v0.215.0 [INFO] [stderr] Checking wit-encoder v0.215.0 [INFO] [stderr] Compiling wasm-encoder v0.215.0 [INFO] [stderr] Compiling wit-parser v0.215.0 [INFO] [stderr] Compiling wasm-metadata v0.215.0 [INFO] [stderr] Compiling wit-component v0.215.0 [INFO] [stderr] Compiling wit-bindgen-core v0.29.0 [INFO] [stderr] Checking wit-bindgen v0.29.0 [INFO] [stderr] Checking sqwit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(namespace: impl Into, name: impl Into, version: Option) -> Self { [INFO] [stdout] | ---------------------------- ----------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let package_name_full = PackageName::new(Cow::Owned(package_namespace.clone()), package_name_ident, version); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let package = Package::new(package_name_full); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let sql_types_interface = Interface::new(Ident::new("sql-types")); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | tables: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | fn convert_fields_to_hstore(fields: Vec) -> Vec<(String, Option)> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | / fields [INFO] [stdout] 277 | | .into_iter() [INFO] [stdout] 278 | | .map(|field| { [INFO] [stdout] 279 | | let name = field [INFO] [stdout] ... | [INFO] [stdout] 284 | | (name, value) [INFO] [stdout] 285 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 289 | fn convert_nested_to_json_array(columns: Vec) -> Vec { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | / columns [INFO] [stdout] 291 | | .into_iter() [INFO] [stdout] 292 | | .map(|col| { [INFO] [stdout] 293 | | let column_json = json!({ [INFO] [stdout] ... | [INFO] [stdout] 299 | | serde_json::to_string(&column_json).unwrap_or_default() [INFO] [stdout] 300 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 292 | .map(|col| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | serde_json::to_string(&column_json).unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(namespace: impl Into, name: impl Into, version: Option) -> Self { [INFO] [stdout] | ---------------------------- ----------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let package_name_full = PackageName::new(Cow::Owned(package_namespace.clone()), package_name_ident, version); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let package = Package::new(package_name_full); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let sql_types_interface = Interface::new(Ident::new("sql-types")); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | tables: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 356 | fn try_from(table: SqlTable) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let fields = table [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Record::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:369:20 [INFO] [stdout] | [INFO] [stdout] 362 | let mut wit_type = Type::try_from(pg_value)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Field::new(Ident::new(column.name.clone()), wit_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqwit` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | fn convert_fields_to_hstore(fields: Vec) -> Vec<(String, Option)> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | / fields [INFO] [stdout] 277 | | .into_iter() [INFO] [stdout] 278 | | .map(|field| { [INFO] [stdout] 279 | | let name = field [INFO] [stdout] ... | [INFO] [stdout] 284 | | (name, value) [INFO] [stdout] 285 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 289 | fn convert_nested_to_json_array(columns: Vec) -> Vec { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | / columns [INFO] [stdout] 291 | | .into_iter() [INFO] [stdout] 292 | | .map(|col| { [INFO] [stdout] 293 | | let column_json = json!({ [INFO] [stdout] ... | [INFO] [stdout] 299 | | serde_json::to_string(&column_json).unwrap_or_default() [INFO] [stdout] 300 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 292 | .map(|col| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | serde_json::to_string(&column_json).unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 356 | fn try_from(table: SqlTable) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let fields = table [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Record::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:369:20 [INFO] [stdout] | [INFO] [stdout] 362 | let mut wit_type = Type::try_from(pg_value)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Field::new(Ident::new(column.name.clone()), wit_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqwit` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f89b7a1b674e231677234daeddb498869abf0fb9dfd281080b837ed0054f0faf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f89b7a1b674e231677234daeddb498869abf0fb9dfd281080b837ed0054f0faf", kill_on_drop: false }` [INFO] [stdout] f89b7a1b674e231677234daeddb498869abf0fb9dfd281080b837ed0054f0faf