[INFO] cloning repository https://github.com/LDeakin/zarrs_tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LDeakin/zarrs_tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLDeakin%2Fzarrs_tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLDeakin%2Fzarrs_tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cf4bdc6f4810e620002e4f601af7a2be38b30ae8 [INFO] checking LDeakin/zarrs_tools/cf4bdc6f4810e620002e4f601af7a2be38b30ae8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLDeakin%2Fzarrs_tools" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LDeakin/zarrs_tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LDeakin/zarrs_tools [INFO] finished tweaking git repo https://github.com/LDeakin/zarrs_tools [INFO] tweaked toml for git repo https://github.com/LDeakin/zarrs_tools written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LDeakin/zarrs_tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f6a7699d86050391245d5a74e6f4add88df53e6e25ceb761ce5c3367b3a764e [INFO] running `Command { std: "docker" "start" "-a" "8f6a7699d86050391245d5a74e6f4add88df53e6e25ceb761ce5c3367b3a764e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f6a7699d86050391245d5a74e6f4add88df53e6e25ceb761ce5c3367b3a764e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f6a7699d86050391245d5a74e6f4add88df53e6e25ceb761ce5c3367b3a764e", kill_on_drop: false }` [INFO] [stdout] 8f6a7699d86050391245d5a74e6f4add88df53e6e25ceb761ce5c3367b3a764e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 522a443894a7fbca146d8ba8a3d3231940d84026372c9b2a36109da5b57c4efa [INFO] running `Command { std: "docker" "start" "-a" "522a443894a7fbca146d8ba8a3d3231940d84026372c9b2a36109da5b57c4efa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling cc v1.1.14 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling moka v0.12.8 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking flagset v0.4.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking sysinfo v0.31.3 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Compiling snappy_src v0.2.3+snappy.1.2.1 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling lz4-sys v1.10.0 [INFO] [stderr] Compiling blosc-src v0.3.4 [INFO] [stderr] Checking rayon_iter_concurrent_limit v0.2.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling monostate-impl v0.1.13 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking bytemuck v1.17.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking ndarray v0.16.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking backon v0.4.4 [INFO] [stderr] Checking async-scoped v0.9.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking monostate v0.1.13 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking opendal v0.49.1 [INFO] [stderr] Checking zarrs v0.17.0-dev (https://github.com/LDeakin/zarrs.git#0c08caef) [INFO] [stderr] Checking zarrs_tools v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 171 | let metadata = Metadata::try_from(array_codec.as_str()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | match Codec::from_metadata(&metadata).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 488 | let metadata = Metadata::try_from(array_codec.as_str()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | match Codec::from_metadata(&metadata).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/path_or_identifier.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 18 | fn deserialize>(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let path_or_id = String::deserialize(d)?; [INFO] [stdout] 20 | parse_path_or_identifier(&path_or_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/downsample.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 86 | ndarray::Zip::from(input.exact_chunks(chunk_size)).par_map_collect(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | (chunk [INFO] [stdout] | __________________^ [INFO] [stdout] 88 | | .iter() [INFO] [stdout] 89 | | .map(|v| AsPrimitive::::as_(*v)) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gaussian.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 92 | let input_array = input_array.mapv(|x| x.as_()); // par? [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let output_array = self.apply_ndarray(input_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let output_array = subset_overlap.extract_subset(&output_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok::<_, FilterError>(output_array.mapv(|x| x.as_())) // par? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gaussian.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 91 | let output_array = progress.process(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / output [INFO] [stdout] 101 | | .store_array_subset_ndarray::(subset_output.start(), output_array) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gradient_magnitude.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 72 | let gradient_magnitude = progress.process(|| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / output [INFO] [stdout] 82 | | .store_array_subset_ndarray::(subset_output.start(), gradient_magnitude) [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 96 | let input_array = input_array.mapv(|x| x.as_()); // par? [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let output_array = self.apply_ndarray(input_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let output_array = subset_overlap.extract_subset(&output_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok::<_, FilterError>(output_array.mapv(|x| x.as_())) // par? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 95 | let output_array = progress.process(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / output [INFO] [stdout] 105 | | .store_array_subset_ndarray::(subset_output.start(), output_array) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn apply_ndarray(&self, v_i: ndarray::ArrayD) -> ndarray::ArrayD { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let mut sat = ndarray::ArrayD::::zeros(v_i.shape()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let mut u_k = self.sat_to_mean(&sat); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let mut vi_minus_uk_2 = ndarray::Zip::from(&v_i) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let a_k = u_k; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let b_k = vi_minus_uk_2; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | ndarray::ArrayD::from_shape_vec(sat.shape(), v_i).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 104 | t_min: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | t_max: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let (min, max) = iter_min_max [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok((min, max)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:118:29 [INFO] [stdout] | [INFO] [stdout] 112 | let elements = array.retrieve_chunk_elements::(&chunk_indices)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let (mut min, mut max) = (t_min.clone(), t_max.clone()); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok::<_, ArrayError>((min, max)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 124 | .try_reduce_with(|(amin, amax), (bmin, bmax)| { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Ok({ [INFO] [stdout] | ________________^ [INFO] [stdout] 126 | | let min = if amin < bmin { amin } else { bmin }; [INFO] [stdout] 127 | | let max = if amax < bmax { amax } else { bmax }; [INFO] [stdout] 128 | | (min, max) [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarrs_tools` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 171 | let metadata = Metadata::try_from(array_codec.as_str()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | match Codec::from_metadata(&metadata).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 488 | let metadata = Metadata::try_from(array_codec.as_str()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | match Codec::from_metadata(&metadata).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/path_or_identifier.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 18 | fn deserialize>(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let path_or_id = String::deserialize(d)?; [INFO] [stdout] 20 | parse_path_or_identifier(&path_or_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/downsample.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 86 | ndarray::Zip::from(input.exact_chunks(chunk_size)).par_map_collect(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | (chunk [INFO] [stdout] | __________________^ [INFO] [stdout] 88 | | .iter() [INFO] [stdout] 89 | | .map(|v| AsPrimitive::::as_(*v)) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gaussian.rs:95:34 [INFO] [stdout] | [INFO] [stdout] 92 | let input_array = input_array.mapv(|x| x.as_()); // par? [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let output_array = self.apply_ndarray(input_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let output_array = subset_overlap.extract_subset(&output_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok::<_, FilterError>(output_array.mapv(|x| x.as_())) // par? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gaussian.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 91 | let output_array = progress.process(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / output [INFO] [stdout] 101 | | .store_array_subset_ndarray::(subset_output.start(), output_array) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/gradient_magnitude.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 72 | let gradient_magnitude = progress.process(|| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / output [INFO] [stdout] 82 | | .store_array_subset_ndarray::(subset_output.start(), gradient_magnitude) [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:99:34 [INFO] [stdout] | [INFO] [stdout] 96 | let input_array = input_array.mapv(|x| x.as_()); // par? [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let output_array = self.apply_ndarray(input_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let output_array = subset_overlap.extract_subset(&output_array); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok::<_, FilterError>(output_array.mapv(|x| x.as_())) // par? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 95 | let output_array = progress.process(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / output [INFO] [stdout] 105 | | .store_array_subset_ndarray::(subset_output.start(), output_array) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters/guided_filter.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn apply_ndarray(&self, v_i: ndarray::ArrayD) -> ndarray::ArrayD { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let mut sat = ndarray::ArrayD::::zeros(v_i.shape()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let mut u_k = self.sat_to_mean(&sat); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let mut vi_minus_uk_2 = ndarray::Zip::from(&v_i) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let a_k = u_k; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let b_k = vi_minus_uk_2; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | ndarray::ArrayD::from_shape_vec(sat.shape(), v_i).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 104 | t_min: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | t_max: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let (min, max) = iter_min_max [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok((min, max)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:118:29 [INFO] [stdout] | [INFO] [stdout] 112 | let elements = array.retrieve_chunk_elements::(&chunk_indices)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let (mut min, mut max) = (t_min.clone(), t_max.clone()); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok::<_, ArrayError>((min, max)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info/range.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 124 | .try_reduce_with(|(amin, amax), (bmin, bmax)| { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Ok({ [INFO] [stdout] | ________________^ [INFO] [stdout] 126 | | let min = if amin < bmin { amin } else { bmin }; [INFO] [stdout] 127 | | let max = if amax < bmax { amax } else { bmax }; [INFO] [stdout] 128 | | (min, max) [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarrs_tools` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "522a443894a7fbca146d8ba8a3d3231940d84026372c9b2a36109da5b57c4efa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "522a443894a7fbca146d8ba8a3d3231940d84026372c9b2a36109da5b57c4efa", kill_on_drop: false }` [INFO] [stdout] 522a443894a7fbca146d8ba8a3d3231940d84026372c9b2a36109da5b57c4efa