[INFO] cloning repository https://github.com/Kreedzt/rwr-profile-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kreedzt/rwr-profile-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKreedzt%2Frwr-profile-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKreedzt%2Frwr-profile-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 78deb9ae34250a322c949ba975d600cca1b0ff9d [INFO] checking Kreedzt/rwr-profile-server/78deb9ae34250a322c949ba975d600cca1b0ff9d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKreedzt%2Frwr-profile-server" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Kreedzt/rwr-profile-server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Kreedzt/rwr-profile-server [INFO] finished tweaking git repo https://github.com/Kreedzt/rwr-profile-server [INFO] tweaked toml for git repo https://github.com/Kreedzt/rwr-profile-server written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Kreedzt/rwr-profile-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6f456049c204e6427da9d44eeae3e1499d78d76b7ec329759a8ff3171de6a7f [INFO] running `Command { std: "docker" "start" "-a" "b6f456049c204e6427da9d44eeae3e1499d78d76b7ec329759a8ff3171de6a7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6f456049c204e6427da9d44eeae3e1499d78d76b7ec329759a8ff3171de6a7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6f456049c204e6427da9d44eeae3e1499d78d76b7ec329759a8ff3171de6a7f", kill_on_drop: false }` [INFO] [stdout] b6f456049c204e6427da9d44eeae3e1499d78d76b7ec329759a8ff3171de6a7f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f12cbf27abbc0aad8f394250d782ea98ea3fa4dd767cab583783a322dd785728 [INFO] running `Command { std: "docker" "start" "-a" "f12cbf27abbc0aad8f394250d782ea98ea3fa4dd767cab583783a322dd785728", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.6 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking alloc-no-stdlib v2.0.3 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Checking local-waker v0.1.2 [INFO] [stderr] Checking alloc-stdlib v0.2.1 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling paste v1.0.6 [INFO] [stderr] Checking num_threads v0.1.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling itoa v1.0.1 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling bytestring v1.0.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking brotli-decompressor v2.3.2 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Checking actix-utils v3.0.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling cookie v0.16.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling serde_json v1.0.75 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Compiling firestorm v0.5.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking time v0.3.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking brotli v3.3.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling parse-size v1.0.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking tracing-subscriber v0.3.7 [INFO] [stderr] Compiling actix-router v0.5.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling actix-macros v0.2.3 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking tracing-appender v0.2.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling actix-web-codegen v4.2.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling actix-multipart-derive v0.6.1 [INFO] [stderr] Checking local-channel v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking actix-rt v2.6.0 [INFO] [stderr] Checking actix-server v2.0.0 [INFO] [stderr] Checking actix-codec v0.5.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-http v3.6.0 [INFO] [stderr] Checking actix-web v4.5.1 [INFO] [stderr] Checking actix-multipart v0.6.1 [INFO] [stderr] Checking actix-files v0.6.5 [INFO] [stderr] Checking rwr-profile-server v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/person/async_extract.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ItemTag`, `OrderTag`, and `StashItemTag` [INFO] [stdout] --> src/person/async_extract.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SinkExt` [INFO] [stdout] --> src/person/async_extract.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `info` [INFO] [stdout] --> src/person/async_extract.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | use tracing::{error, info}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MAX_DEFAULT_STASH_LEN` and `StashItemTag` [INFO] [stdout] --> src/person/extract.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | constant::{MAX_DEFAULT_STASH_LEN, MAX_PERSON_FILE_VERSION}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 4 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/person/extract.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | use std::{collections::HashMap, fs, io, str}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::info` [INFO] [stdout] --> src/person/extract.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tracing::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `profile::model::Profile` [INFO] [stdout] --> src/person/model.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | profile::model::Profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `extract::extract_person` and `model::StashItemTag` [INFO] [stdout] --> src/person/save.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::person::{extract::extract_person, model::StashItemTag}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BytesText` [INFO] [stdout] --> src/person/save.rs:6:47 [INFO] [stdout] | [INFO] [stdout] 6 | use quick_xml::events::{BytesEnd, BytesStart, BytesText, Event}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warn` [INFO] [stdout] --> src/person/save.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use tracing::{error, warn}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::info` [INFO] [stdout] --> src/profile/extract.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use tracing::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/system/extract.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/system/save.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/version_update/preupdate.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ItemTag`, `OrderTag`, `Person`, `StashItemTag`, and `model::Profile` [INFO] [stdout] --> src/version_update/preupdate.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] 7 | profile::{extract::extract_profile, model::Profile}, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/version_update/preupdate.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SinkExt` [INFO] [stdout] --> src/version_update/preupdate.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/version_update/preupdate.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | if (p.version < 154) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - if (p.version < 154) { [INFO] [stdout] 45 + if p.version < 154 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/version_update/update_to_154.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntoParallelIterator` [INFO] [stdout] --> src/version_update/update_to_154.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | use rayon::iter::{IntoParallelIterator, ParallelIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `fs` and `io` [INFO] [stdout] --> src/version_update/update_to_154.rs:9:33 [INFO] [stdout] | [INFO] [stdout] 9 | use std::{collections::HashMap, fs, io, str}; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Person_V153` should have an upper camel case name [INFO] [stdout] --> src/version_update/update_to_154.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct Person_V153 { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `PersonV153` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/person/async_extract.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ItemTag`, `OrderTag`, and `StashItemTag` [INFO] [stdout] --> src/person/async_extract.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SinkExt` [INFO] [stdout] --> src/person/async_extract.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `info` [INFO] [stdout] --> src/person/async_extract.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | use tracing::{error, info}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MAX_DEFAULT_STASH_LEN` and `StashItemTag` [INFO] [stdout] --> src/person/extract.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | constant::{MAX_DEFAULT_STASH_LEN, MAX_PERSON_FILE_VERSION}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 4 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/person/extract.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | use std::{collections::HashMap, fs, io, str}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::info` [INFO] [stdout] --> src/person/extract.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tracing::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `profile::model::Profile` [INFO] [stdout] --> src/person/model.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | profile::model::Profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `extract::extract_person` and `model::StashItemTag` [INFO] [stdout] --> src/person/save.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::person::{extract::extract_person, model::StashItemTag}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BytesText` [INFO] [stdout] --> src/person/save.rs:6:47 [INFO] [stdout] | [INFO] [stdout] 6 | use quick_xml::events::{BytesEnd, BytesStart, BytesText, Event}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `warn` [INFO] [stdout] --> src/person/save.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use tracing::{error, warn}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tracing::info` [INFO] [stdout] --> src/profile/extract.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use tracing::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/system/extract.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/system/save.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/version_update/preupdate.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ItemTag`, `OrderTag`, `Person`, `StashItemTag`, and `model::Profile` [INFO] [stdout] --> src/version_update/preupdate.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | person::model::{ItemTag, OrderTag, Person, StashItemTag}, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] 7 | profile::{extract::extract_profile, model::Profile}, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/version_update/preupdate.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SinkExt` [INFO] [stdout] --> src/version_update/preupdate.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/version_update/preupdate.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | if (p.version < 154) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - if (p.version < 154) { [INFO] [stdout] 45 + if p.version < 154 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/version_update/update_to_154.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntoParallelIterator` [INFO] [stdout] --> src/version_update/update_to_154.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | use rayon::iter::{IntoParallelIterator, ParallelIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `fs` and `io` [INFO] [stdout] --> src/version_update/update_to_154.rs:9:33 [INFO] [stdout] | [INFO] [stdout] 9 | use std::{collections::HashMap, fs, io, str}; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Person_V153` should have an upper camel case name [INFO] [stdout] --> src/version_update/update_to_154.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct Person_V153 { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `PersonV153` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/service.rs:618:9 [INFO] [stdout] | [INFO] [stdout] 618 | let mut temp_file_name = Arc::new(Mutex::new(String::new())); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/service.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | let mut outer_file_name = Arc::clone(&temp_file_name); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/save.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let cloned_folder_path = folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/profile/save.rs:28:60 [INFO] [stdout] | [INFO] [stdout] 28 | let future_vec = new_all_profile_list.into_iter().map(|info| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/save.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut err_profile_id_vec = vec![]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/service.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | let cloned_folder_path = config.rwr_profile_folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/service.rs:618:9 [INFO] [stdout] | [INFO] [stdout] 618 | let mut temp_file_name = Arc::new(Mutex::new(String::new())); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/service.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | let mut outer_file_name = Arc::clone(&temp_file_name); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/service.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let cloned_folder_path = config.rwr_profile_folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/save.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let cloned_folder_path = folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/profile/save.rs:28:60 [INFO] [stdout] | [INFO] [stdout] 28 | let future_vec = new_all_profile_list.into_iter().map(|info| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/save.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut err_profile_id_vec = vec![]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/service.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | let cloned_folder_path = config.rwr_profile_folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cloned_folder_path` [INFO] [stdout] --> src/profile/service.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let cloned_folder_path = config.rwr_profile_folder_path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloned_folder_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/service.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | let mut temp_file_name = Arc::new(Mutex::new(String::new())); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/service.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let mut outer_file_name = Arc::clone(&temp_file_name); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/service.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | let mut temp_file_name = Arc::new(Mutex::new(String::new())); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/profile/service.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let mut outer_file_name = Arc::clone(&temp_file_name); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `person_vec` [INFO] [stdout] --> src/version_update/preupdate.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let person_vec = futures::future::try_join_all(person_future_vec).await?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_person_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `profile_vec` [INFO] [stdout] --> src/version_update/preupdate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let profile_vec = futures::future::try_join_all(profile_future_vec).await?; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_in_person` is assigned to, but never used [INFO] [stdout] --> src/version_update/update_to_154.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let mut is_in_person = false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_is_in_person` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_in_person` is never read [INFO] [stdout] --> src/version_update/update_to_154.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | is_in_person = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_item` [INFO] [stdout] --> src/version_update/update_to_154.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/version_update/update_to_154.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version_update/update_to_154.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `person_vec` [INFO] [stdout] --> src/version_update/preupdate.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let person_vec = futures::future::try_join_all(person_future_vec).await?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_person_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `profile_vec` [INFO] [stdout] --> src/version_update/preupdate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let profile_vec = futures::future::try_join_all(profile_future_vec).await?; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_in_person` is assigned to, but never used [INFO] [stdout] --> src/version_update/update_to_154.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let mut is_in_person = false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_is_in_person` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_in_person` is never read [INFO] [stdout] --> src/version_update/update_to_154.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | is_in_person = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_item` [INFO] [stdout] --> src/version_update/update_to_154.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/version_update/update_to_154.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/version_update/update_to_154.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FutureExt` [INFO] [stdout] --> src/person/async_extract.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFutureExt` [INFO] [stdout] --> src/profile/service.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use futures_util::{TryFutureExt, TryStreamExt as _}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::prelude` [INFO] [stdout] --> src/version_update/preupdate.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use rayon::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FutureExt` [INFO] [stdout] --> src/version_update/preupdate.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParallelIterator` [INFO] [stdout] --> src/version_update/update_to_154.rs:8:41 [INFO] [stdout] | [INFO] [stdout] 8 | use rayon::iter::{IntoParallelIterator, ParallelIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_in_person` is assigned to, but never used [INFO] [stdout] --> src/person/extract.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut is_in_person = false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_is_in_person` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_in_person` is never read [INFO] [stdout] --> src/person/extract.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | is_in_person = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_item` [INFO] [stdout] --> src/person/extract.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/person/extract.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 226 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/extract.rs:79:41 [INFO] [stdout] | [INFO] [stdout] 79 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FutureExt` [INFO] [stdout] --> src/person/async_extract.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryFutureExt` [INFO] [stdout] --> src/profile/service.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use futures_util::{TryFutureExt, TryStreamExt as _}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::prelude` [INFO] [stdout] --> src/version_update/preupdate.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use rayon::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FutureExt` [INFO] [stdout] --> src/version_update/preupdate.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use futures::{self, FutureExt, SinkExt}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParallelIterator` [INFO] [stdout] --> src/version_update/update_to_154.rs:8:41 [INFO] [stdout] | [INFO] [stdout] 8 | use rayon::iter::{IntoParallelIterator, ParallelIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_in_person` is assigned to, but never used [INFO] [stdout] --> src/person/extract.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut is_in_person = false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_is_in_person` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `is_in_person` is never read [INFO] [stdout] --> src/person/extract.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | is_in_person = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_item` [INFO] [stdout] --> src/person/extract.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/person/extract.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 226 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/person/extract.rs:79:41 [INFO] [stdout] | [INFO] [stdout] 79 | ... let mut order_item = OrderTag::default(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/profile/extract.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(Event::Empty(e)) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/profile/extract.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/profile/extract.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(Event::Empty(e)) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/profile/extract.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | Ok(Event::End(e)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user` [INFO] [stdout] --> src/user/utils.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | if let Some(user) = res { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_user` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/user/utils.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let path = format!("{}/{}.profile", profile_path, username); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `password` [INFO] [stdout] --> src/user/utils.rs:95:38 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn register_user(username: &str, password: &str, config: &AppData) -> Result { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_password` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user` [INFO] [stdout] --> src/user/utils.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | if let Some(user) = res { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_user` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/user/utils.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let path = format!("{}/{}.profile", profile_path, username); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `password` [INFO] [stdout] --> src/user/utils.rs:95:38 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn register_user(username: &str, password: &str, config: &AppData) -> Result { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_password` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `MAX_PROFILE_FILE_VERSION` is never used [INFO] [stdout] --> src/constant.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub static MAX_PROFILE_FILE_VERSION: u16 = 154; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `server_log_folder_path` is never read [INFO] [stdout] --> src/model.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct AppData { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub server_log_folder_path: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/model.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | impl ResponseJson { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 53 | pub fn new(msg: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_all_person` is never used [INFO] [stdout] --> src/person/extract.rs:248:8 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn extract_all_person(folder_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_all_person_and_profiles` is never used [INFO] [stdout] --> src/person/extract.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn extract_all_person_and_profiles(folder_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_profile_list_squad_tag_to_file` is never used [INFO] [stdout] --> src/profile/save.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | pub async fn update_profile_list_squad_tag_to_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_profile_list` is never used [INFO] [stdout] --> src/user/extract.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn extract_profile_list() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_user_id_in_profiles` is never used [INFO] [stdout] --> src/user/utils.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_user_id_in_profiles(username: &str, profile_path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 36 | let app_data = web::Data::new(AppData { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let app_data_c = app_data.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / HttpServer::new(move || { [INFO] [stdout] 119 | | App::new() [INFO] [stdout] 120 | | .app_data(web::Data::clone(&app_data)) [INFO] [stdout] 121 | | .configure(user_config) [INFO] [stdout] ... | [INFO] [stdout] 128 | | .run() [INFO] [stdout] 129 | | .await [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 36 | let app_data = web::Data::new(AppData { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / App::new() [INFO] [stdout] 120 | | .app_data(web::Data::clone(&app_data)) [INFO] [stdout] 121 | | .configure(user_config) [INFO] [stdout] 122 | | .configure(profile_config) [INFO] [stdout] 123 | | .configure(person_config) [INFO] [stdout] 124 | | .configure(system_config) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 592 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | HttpResponse::BadRequest().json(custom_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:602:13 [INFO] [stdout] | [INFO] [stdout] 600 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | error!("download {} person file error: {:?}", id, e); [INFO] [stdout] 602 | HttpResponse::BadRequest() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:641:36 [INFO] [stdout] | [INFO] [stdout] 636 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 640 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 641 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:641:60 [INFO] [stdout] | [INFO] [stdout] 636 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 640 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 641 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 111 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | HttpResponse::BadRequest().json(custom_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:155:36 [INFO] [stdout] | [INFO] [stdout] 150 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 155 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 150 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 155 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::MutexGuard` that must be used [INFO] [stdout] --> src/user/service.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | config.user_json_lock.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = config.user_json_lock.lock().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::MutexGuard` that must be used [INFO] [stdout] --> src/user/service.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | config.user_json_lock.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 79 | let _ = config.user_json_lock.lock().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `MAX_PROFILE_FILE_VERSION` is never used [INFO] [stdout] --> src/constant.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub static MAX_PROFILE_FILE_VERSION: u16 = 154; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `server_log_folder_path` is never read [INFO] [stdout] --> src/model.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct AppData { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub server_log_folder_path: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/model.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | impl ResponseJson { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 53 | pub fn new(msg: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_all_person` is never used [INFO] [stdout] --> src/person/extract.rs:248:8 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn extract_all_person(folder_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_all_person_and_profiles` is never used [INFO] [stdout] --> src/person/extract.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn extract_all_person_and_profiles(folder_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_profile_list_squad_tag_to_file` is never used [INFO] [stdout] --> src/profile/save.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | pub async fn update_profile_list_squad_tag_to_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_profile_list` is never used [INFO] [stdout] --> src/user/extract.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn extract_profile_list() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_user_id_in_profiles` is never used [INFO] [stdout] --> src/user/utils.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_user_id_in_profiles(username: &str, profile_path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 36 | let app_data = web::Data::new(AppData { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let app_data_c = app_data.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / HttpServer::new(move || { [INFO] [stdout] 119 | | App::new() [INFO] [stdout] 120 | | .app_data(web::Data::clone(&app_data)) [INFO] [stdout] 121 | | .configure(user_config) [INFO] [stdout] ... | [INFO] [stdout] 128 | | .run() [INFO] [stdout] 129 | | .await [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 36 | let app_data = web::Data::new(AppData { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / App::new() [INFO] [stdout] 120 | | .app_data(web::Data::clone(&app_data)) [INFO] [stdout] 121 | | .configure(user_config) [INFO] [stdout] 122 | | .configure(profile_config) [INFO] [stdout] 123 | | .configure(person_config) [INFO] [stdout] 124 | | .configure(system_config) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:598:13 [INFO] [stdout] | [INFO] [stdout] 592 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | HttpResponse::BadRequest().json(custom_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:602:13 [INFO] [stdout] | [INFO] [stdout] 600 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | error!("download {} person file error: {:?}", id, e); [INFO] [stdout] 602 | HttpResponse::BadRequest() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:641:36 [INFO] [stdout] | [INFO] [stdout] 636 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 640 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 641 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/person/service.rs:641:60 [INFO] [stdout] | [INFO] [stdout] 636 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 640 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 641 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 111 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | HttpResponse::BadRequest().json(custom_err) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:155:36 [INFO] [stdout] | [INFO] [stdout] 150 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 155 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile/service.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 150 | let mut f = web::block(|| std::fs::File::create(filepath)).await??; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | while let Some(chunk) = field.try_next().await? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | // filesystem operations are blocking, we have to use threadpool [INFO] [stdout] 155 | f = web::block(move || f.write_all(&chunk).map(|_| f)).await??; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::MutexGuard` that must be used [INFO] [stdout] --> src/user/service.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | config.user_json_lock.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = config.user_json_lock.lock().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::MutexGuard` that must be used [INFO] [stdout] --> src/user/service.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | config.user_json_lock.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 79 | let _ = config.user_json_lock.lock().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 64 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 64 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rwr-profile-server` (bin "rwr-profile-server" test) due to 10 previous errors; 64 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rwr-profile-server` (bin "rwr-profile-server") due to 10 previous errors; 64 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f12cbf27abbc0aad8f394250d782ea98ea3fa4dd767cab583783a322dd785728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f12cbf27abbc0aad8f394250d782ea98ea3fa4dd767cab583783a322dd785728", kill_on_drop: false }` [INFO] [stdout] f12cbf27abbc0aad8f394250d782ea98ea3fa4dd767cab583783a322dd785728