[INFO] cloning repository https://github.com/Kourin1996/rbtc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kourin1996/rbtc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKourin1996%2Frbtc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKourin1996%2Frbtc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 937cd365cf0eca0d1ebd4b4ea75be3f0b1eec0dc [INFO] checking Kourin1996/rbtc/937cd365cf0eca0d1ebd4b4ea75be3f0b1eec0dc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKourin1996%2Frbtc" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Kourin1996/rbtc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Kourin1996/rbtc [INFO] finished tweaking git repo https://github.com/Kourin1996/rbtc [INFO] tweaked toml for git repo https://github.com/Kourin1996/rbtc written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Kourin1996/rbtc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3286290d7192b53e416a61a1183c1b0540498530f4b7deb904be86c643fc65f1 [INFO] running `Command { std: "docker" "start" "-a" "3286290d7192b53e416a61a1183c1b0540498530f4b7deb904be86c643fc65f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3286290d7192b53e416a61a1183c1b0540498530f4b7deb904be86c643fc65f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3286290d7192b53e416a61a1183c1b0540498530f4b7deb904be86c643fc65f1", kill_on_drop: false }` [INFO] [stdout] 3286290d7192b53e416a61a1183c1b0540498530f4b7deb904be86c643fc65f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb6dce5da5239490ac512d2900baaac903e7436c018beb4014995f1934a6d9a7 [INFO] running `Command { std: "docker" "start" "-a" "fb6dce5da5239490ac512d2900baaac903e7436c018beb4014995f1934a6d9a7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking rbtc-wire v0.1.0 (/opt/rustwide/workdir/crates/wire) [INFO] [stdout] warning: unused variable: `encoding` [INFO] [stdout] --> crates/wire/src/msg/version.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | encoding: BtcMessageEncodingType, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encoding` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reader` [INFO] [stdout] --> crates/wire/src/msg/version.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | reader: &mut impl BufRead, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `protocol_version` [INFO] [stdout] --> crates/wire/src/msg/version.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | protocol_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_protocol_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encoding` [INFO] [stdout] --> crates/wire/src/msg/version.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | encoding: BtcMessageEncodingType, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encoding` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 99 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 101 | | "MsgVersion".to_string(), [INFO] [stdout] 102 | | e, [INFO] [stdout] 103 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 134 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 136 | | "MsgVersion".to_string(), [INFO] [stdout] 137 | | e, [INFO] [stdout] 138 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 146 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _____________________^ [INFO] [stdout] 148 | | "MsgVersion".to_string(), [INFO] [stdout] 149 | | e, [INFO] [stdout] 150 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 38 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Err(NetAddressEncodeError::EncodingError( [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | "last_seen_timestamp".to_string(), [INFO] [stdout] 41 | | e, [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 48 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(NetAddressEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 50 | | "services".to_string(), [INFO] [stdout] 51 | | e, [INFO] [stdout] 52 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | .or_else(|e| Err(NetAddressEncodeError::EncodingError("ip".to_string(), e)))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | .or_else(|e| Err(NetAddressEncodeError::EncodingError("port".to_string(), e)))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rbtc-wire` (lib) due to 8 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `encoding` [INFO] [stdout] --> crates/wire/src/msg/version.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | encoding: BtcMessageEncodingType, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encoding` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reader` [INFO] [stdout] --> crates/wire/src/msg/version.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | reader: &mut impl BufRead, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `protocol_version` [INFO] [stdout] --> crates/wire/src/msg/version.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | protocol_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_protocol_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encoding` [INFO] [stdout] --> crates/wire/src/msg/version.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | encoding: BtcMessageEncodingType, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encoding` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 99 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 101 | | "MsgVersion".to_string(), [INFO] [stdout] 102 | | e, [INFO] [stdout] 103 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 134 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 136 | | "MsgVersion".to_string(), [INFO] [stdout] 137 | | e, [INFO] [stdout] 138 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/msg/version.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 146 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Err(BtcMessageEncodeError::EncodingError( [INFO] [stdout] | _____________________^ [INFO] [stdout] 148 | | "MsgVersion".to_string(), [INFO] [stdout] 149 | | e, [INFO] [stdout] 150 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 38 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Err(NetAddressEncodeError::EncodingError( [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | "last_seen_timestamp".to_string(), [INFO] [stdout] 41 | | e, [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 48 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(NetAddressEncodeError::EncodingError( [INFO] [stdout] | _________________^ [INFO] [stdout] 50 | | "services".to_string(), [INFO] [stdout] 51 | | e, [INFO] [stdout] 52 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | .or_else(|e| Err(NetAddressEncodeError::EncodingError("ip".to_string(), e)))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/wire/src/encoding/net_address.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | .or_else(|e| Err(NetAddressEncodeError::EncodingError("port".to_string(), e)))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rbtc-wire` (lib test) due to 8 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fb6dce5da5239490ac512d2900baaac903e7436c018beb4014995f1934a6d9a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb6dce5da5239490ac512d2900baaac903e7436c018beb4014995f1934a6d9a7", kill_on_drop: false }` [INFO] [stdout] fb6dce5da5239490ac512d2900baaac903e7436c018beb4014995f1934a6d9a7