[INFO] cloning repository https://github.com/Knight-Ops/tftp-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Knight-Ops/tftp-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKnight-Ops%2Ftftp-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKnight-Ops%2Ftftp-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 64117b7c7264eba95f755e3b99d0e5f911cc1c63 [INFO] checking Knight-Ops/tftp-rs/64117b7c7264eba95f755e3b99d0e5f911cc1c63 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKnight-Ops%2Ftftp-rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Knight-Ops/tftp-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Knight-Ops/tftp-rs [INFO] finished tweaking git repo https://github.com/Knight-Ops/tftp-rs [INFO] tweaked toml for git repo https://github.com/Knight-Ops/tftp-rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Knight-Ops/tftp-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5e408fbf826a2ac3fa7e23e99d4dbe202e50e94fea79847e6e6c4c3cfd8101d [INFO] running `Command { std: "docker" "start" "-a" "a5e408fbf826a2ac3fa7e23e99d4dbe202e50e94fea79847e6e6c4c3cfd8101d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5e408fbf826a2ac3fa7e23e99d4dbe202e50e94fea79847e6e6c4c3cfd8101d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5e408fbf826a2ac3fa7e23e99d4dbe202e50e94fea79847e6e6c4c3cfd8101d", kill_on_drop: false }` [INFO] [stdout] a5e408fbf826a2ac3fa7e23e99d4dbe202e50e94fea79847e6e6c4c3cfd8101d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0094ab0685078cf8f01c725fa0ede5b0d984877906acad810f58adc317c33e03 [INFO] running `Command { std: "docker" "start" "-a" "0094ab0685078cf8f01c725fa0ede5b0d984877906acad810f58adc317c33e03", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking logging-allocator v0.1.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Checking tftp-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `unreachable` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | unreachable, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `unreachable` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | unreachable, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/lib.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 43 | / match opcode { [INFO] [stdout] 44 | | OpCode::ReadRequest => { [INFO] [stdout] 45 | | run_guarded(|| info!("Opcode : {:?}", opcode)); [INFO] [stdout] 46 | | return Ok(Self::ReadRequest(ReadRequestPacket::try_from(&input[2..])?)); [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________- any code following this `match` expression is unreachable, as all arms diverge [INFO] [stdout] 67 | [INFO] [stdout] 68 | Err(ParsingError::NotEnoughData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/lib.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 43 | / match opcode { [INFO] [stdout] 44 | | OpCode::ReadRequest => { [INFO] [stdout] 45 | | run_guarded(|| info!("Opcode : {:?}", opcode)); [INFO] [stdout] 46 | | return Ok(Self::ReadRequest(ReadRequestPacket::try_from(&input[2..])?)); [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________- any code following this `match` expression is unreachable, as all arms diverge [INFO] [stdout] 67 | [INFO] [stdout] 68 | Err(ParsingError::NotEnoughData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tmp_socket` [INFO] [stdout] --> src/lib.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | let tmp_socket = UdpSocket::bind("localhost:0").map_err(|_| ParsingError::SocketError)?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tmp_socket` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/lib.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 499 | dst: SocketAddr, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `wrq` [INFO] [stdout] --> src/lib.rs:500:9 [INFO] [stdout] | [INFO] [stdout] 500 | wrq: WriteRequestPacket, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_wrq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/lib.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct ReadRequestPacket { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 74 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadRequestPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | impl ReadRequestPacket { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 109 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `opcode`, `filename`, and `mode` are never read [INFO] [stdout] --> src/lib.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct WriteRequestPacket { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 131 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 132 | filename: CString, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | mode: CString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WriteRequestPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 165 | impl WriteRequestPacket { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] 166 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/lib.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct AckPacket { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 240 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AckPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 263 | impl AckPacket { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 264 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 91 | let filename = CString::new(&input[..end_filename]).expect("Error creating CString"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mode = CString::new(&input[end_filename + 1..end_filename + end_mode]) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | opcode, [INFO] [stdout] 102 | | filename, [INFO] [stdout] 103 | | mode, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 148 | let filename = CString::new(&input[..end_filename]).expect("Error creating CString"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mode = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 158 | | opcode, [INFO] [stdout] 159 | | filename, [INFO] [stdout] 160 | | mode, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | let error_msg = CString::new(&input[2..end_error_msg]).expect("Error creating CString"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | [INFO] [stdout] 303 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | opcode, [INFO] [stdout] 305 | | error_code, [INFO] [stdout] 306 | | error_msg, [INFO] [stdout] 307 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:429:13 [INFO] [stdout] | [INFO] [stdout] 429 | self.send_error(&tmp_socket, &dst, ErrorCode::FileNotFound); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 429 | let _ = self.send_error(&tmp_socket, &dst, ErrorCode::FileNotFound); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:524:9 [INFO] [stdout] | [INFO] [stdout] 524 | s.send_to(&buf[0..size], dst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 524 | let _ = s.send_to(&buf[0..size], dst); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tftp-rs` (lib test) due to 4 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `tmp_socket` [INFO] [stdout] --> src/lib.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | let tmp_socket = UdpSocket::bind("localhost:0").map_err(|_| ParsingError::SocketError)?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tmp_socket` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/lib.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 499 | dst: SocketAddr, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `wrq` [INFO] [stdout] --> src/lib.rs:500:9 [INFO] [stdout] | [INFO] [stdout] 500 | wrq: WriteRequestPacket, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_wrq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/lib.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct ReadRequestPacket { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 74 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadRequestPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | impl ReadRequestPacket { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 109 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `opcode`, `filename`, and `mode` are never read [INFO] [stdout] --> src/lib.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct WriteRequestPacket { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 131 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 132 | filename: CString, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | mode: CString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WriteRequestPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 165 | impl WriteRequestPacket { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] 166 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/lib.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct AckPacket { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 240 | opcode: OpCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AckPacket` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize` is never used [INFO] [stdout] --> src/lib.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 263 | impl AckPacket { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 264 | fn serialize(&self) -> (usize, [u8; BUFFER_SIZE]) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 91 | let filename = CString::new(&input[..end_filename]).expect("Error creating CString"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mode = CString::new(&input[end_filename + 1..end_filename + end_mode]) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | opcode, [INFO] [stdout] 102 | | filename, [INFO] [stdout] 103 | | mode, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 148 | let filename = CString::new(&input[..end_filename]).expect("Error creating CString"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mode = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 158 | | opcode, [INFO] [stdout] 159 | | filename, [INFO] [stdout] 160 | | mode, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | let error_msg = CString::new(&input[2..end_error_msg]).expect("Error creating CString"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | [INFO] [stdout] 303 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | opcode, [INFO] [stdout] 305 | | error_code, [INFO] [stdout] 306 | | error_msg, [INFO] [stdout] 307 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:429:13 [INFO] [stdout] | [INFO] [stdout] 429 | self.send_error(&tmp_socket, &dst, ErrorCode::FileNotFound); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 429 | let _ = self.send_error(&tmp_socket, &dst, ErrorCode::FileNotFound); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:524:9 [INFO] [stdout] | [INFO] [stdout] 524 | s.send_to(&buf[0..size], dst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 524 | let _ = s.send_to(&buf[0..size], dst); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tftp-rs` (lib) due to 4 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0094ab0685078cf8f01c725fa0ede5b0d984877906acad810f58adc317c33e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0094ab0685078cf8f01c725fa0ede5b0d984877906acad810f58adc317c33e03", kill_on_drop: false }` [INFO] [stdout] 0094ab0685078cf8f01c725fa0ede5b0d984877906acad810f58adc317c33e03