[INFO] cloning repository https://github.com/KisaragiEffective/rust-generic-dp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KisaragiEffective/rust-generic-dp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKisaragiEffective%2Frust-generic-dp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKisaragiEffective%2Frust-generic-dp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1363d18d723211ebec4cf647303e644e72f04e41 [INFO] checking KisaragiEffective/rust-generic-dp/1363d18d723211ebec4cf647303e644e72f04e41 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKisaragiEffective%2Frust-generic-dp" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KisaragiEffective/rust-generic-dp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/KisaragiEffective/rust-generic-dp [INFO] finished tweaking git repo https://github.com/KisaragiEffective/rust-generic-dp [INFO] tweaked toml for git repo https://github.com/KisaragiEffective/rust-generic-dp written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KisaragiEffective/rust-generic-dp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6128ea4fdebb71913ce6aa38837a7e0b5e6405f0b12fa3b7bbc0a63e78c6354 [INFO] running `Command { std: "docker" "start" "-a" "d6128ea4fdebb71913ce6aa38837a7e0b5e6405f0b12fa3b7bbc0a63e78c6354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6128ea4fdebb71913ce6aa38837a7e0b5e6405f0b12fa3b7bbc0a63e78c6354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6128ea4fdebb71913ce6aa38837a7e0b5e6405f0b12fa3b7bbc0a63e78c6354", kill_on_drop: false }` [INFO] [stdout] d6128ea4fdebb71913ce6aa38837a7e0b5e6405f0b12fa3b7bbc0a63e78c6354 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 176fcfb01cb0882cf1ba04fdade4828d802124da62977523cc1a4381e74e077c [INFO] running `Command { std: "docker" "start" "-a" "176fcfb01cb0882cf1ba04fdade4828d802124da62977523cc1a4381e74e077c", kill_on_drop: false }` [INFO] [stderr] Checking non-empty-vec v0.2.3 [INFO] [stderr] Checking untitled12345 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `NonEmpty` and `ne_vec` [INFO] [stdout] --> src/test/fib_perf.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | use non_empty_vec::{ne_vec, NonEmpty}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CacheAll`, `CacheArray`, and `CacheVec` [INFO] [stdout] --> src/test/fib_perf.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::cache::{CacheAll, CacheArray, CacheVec}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::collecting::Sum` [INFO] [stdout] --> src/test/fib_perf.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::collecting::Sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::dp::complex::ComplexDP` [INFO] [stdout] --> src/test/fib_perf.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::dp::complex::ComplexDP; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::dp::get_state::SolverFactory` [INFO] [stdout] --> src/test/fib_perf.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::dp::get_state::SolverFactory; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::dp::simple_dp` [INFO] [stdout] --> src/test/fib_perf.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::dp::simple_dp; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::dp::traits::DP` [INFO] [stdout] --> src/test/fib_perf.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::dp::traits::DP; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `run_dp` and `run_print_time` [INFO] [stdout] --> src/test/fib_perf.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::test::{run_dp, run_print_time}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `simple_dp` is never used [INFO] [stdout] --> src/dp.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn simple_dp<'dp, I: Copy, R: Copy, M: Copy + Magma, Solver: ProblemProxy, PartialAnswer>, PartialAnswer>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Intermediate` and `Base` are never constructed [INFO] [stdout] --> src/dp/complex.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub enum State { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 26 | Intermediate { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | Base { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/dp/complex.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 44 | / impl< [INFO] [stdout] 45 | | I, [INFO] [stdout] 46 | | ProbAnswer, [INFO] [stdout] 47 | | SRI, [INFO] [stdout] 48 | | PartialProblemAnswerCombiner, [INFO] [stdout] 49 | | Solver [INFO] [stdout] 50 | | > ComplexDP { [INFO] [stdout] | |_____________________________________________________________________- associated function in this implementation [INFO] [stdout] 51 | pub(crate) fn new(solver: Solver) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Base` and `Intermediate` are never constructed [INFO] [stdout] --> src/dp/simple.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub enum State { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 62 | Base { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | Intermediate { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SolverFactory` is never constructed [INFO] [stdout] --> src/dp/get_state.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct SolverFactory; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `function` and `function_with_cache` are never used [INFO] [stdout] --> src/dp/get_state.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl SolverFactory { [INFO] [stdout] | ------------------ associated functions in this implementation [INFO] [stdout] 29 | pub fn function, PartialAnswer>(f: impl Fn(Input) -> State) -> impl ProblemProxy src/dp/get_state.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | struct Function State, Input, State: StateExtractor, PA>(F, PhantomData<(Input, State, PA)>); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FunctionWithCache` is never constructed [INFO] [stdout] --> src/dp/get_state.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | struct FunctionWithCache State, CP: ArbitraryScopeCachePolicy, Input, State, PartialAnswer> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Commutative` is never used [INFO] [stdout] --> src/collecting.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub trait Commutative {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Monoid` is never used [INFO] [stdout] --> src/collecting.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub trait Monoid: Magma { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/collecting.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 30 | impl Sum { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 31 | pub(crate) fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get` and `set` are never used [INFO] [stdout] --> src/cache.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub trait ScopedCachePolicy<'a, K, V> { [INFO] [stdout] | ----------------- methods in this trait [INFO] [stdout] 22 | fn get(&'a self, k: &K) -> Option<&'a V>; [INFO] [stdout] | ^^^ [INFO] [stdout] 23 | fn set(&'a mut self, k: K, v: V); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/cache.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 30 | impl CacheAll { [INFO] [stdout] | ------------------------- associated function in this implementation [INFO] [stdout] 31 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `new_with_capacity` are never used [INFO] [stdout] --> src/cache.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl CacheVec { [INFO] [stdout] | -------------------- associated functions in this implementation [INFO] [stdout] 63 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new_with_capacity(initial_capacity: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_print_time` is never used [INFO] [stdout] --> src/test.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn run_print_time<'a, F: 'a + FnOnce() -> T, T>(message: &'a (impl Display + ?Sized), f: F) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_dp` is never used [INFO] [stdout] --> src/test.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn run_dp<'a, Index, Output: 'a + Display>(index: Index, dp: &'a (impl DP<'a, Index, Output> + 'a)) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `inner_test` is never used [INFO] [stdout] --> src/test/yukicoder/p44.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn inner_test(index: usize) -> u64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dp/get_state.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 37 | >(f: impl Fn(Input) -> State, cache: impl ArbitraryScopeCachePolicy) -> impl ProblemProxy [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Commutative` is never used [INFO] [stdout] --> src/collecting.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub trait Commutative {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Monoid` is never used [INFO] [stdout] --> src/collecting.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub trait Monoid: Magma { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_with_capacity` is never used [INFO] [stdout] --> src/cache.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl CacheVec { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new_with_capacity(initial_capacity: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/dp/get_state.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / v.get_value().map_or((), |pa| { [INFO] [stdout] 80 | | self.update_cache(input, pa); [INFO] [stdout] 81 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 79 | let _ = v.get_value().map_or((), |pa| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dp/get_state.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | fn get(&self, input: I) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | self.cache_repo.borrow().get(&input).cloned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dp/state.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | self.deref().deref().get_value() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `State` does not implement `Deref`, so calling `deref` on `&State` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 48 | fn combine(&self, lhs: T, rhs: T) -> T { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.base.combine(lhs, rhs) % self.modulo.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 48 | fn combine(&self, lhs: T, rhs: T) -> T { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.base.combine(lhs, rhs) % self.modulo.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:82:11 [INFO] [stdout] | [INFO] [stdout] 81 | fn reduce(&self, reduce_source: NonEmpty) -> T { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | (&self(reduce_source)).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap_unsafe/maybe_garbage_vec.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn tap_non_empty_uninit_vec(len: usize, tap: impl FnOnce(&mut NonEmpty>)) -> NonEmpty { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | temp.into_iter().map(|a| unsafe { a.assume_init() }).collect::>().try_into().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dp/get_state.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 37 | >(f: impl Fn(Input) -> State, cache: impl ArbitraryScopeCachePolicy) -> impl ProblemProxy [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/dp/get_state.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / v.get_value().map_or((), |pa| { [INFO] [stdout] 80 | | self.update_cache(input, pa); [INFO] [stdout] 81 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 79 | let _ = v.get_value().map_or((), |pa| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dp/get_state.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | fn get(&self, input: I) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | self.cache_repo.borrow().get(&input).cloned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dp/state.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | self.deref().deref().get_value() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `State` does not implement `Deref`, so calling `deref` on `&State` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 48 | fn combine(&self, lhs: T, rhs: T) -> T { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.base.combine(lhs, rhs) % self.modulo.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:49:39 [INFO] [stdout] | [INFO] [stdout] 48 | fn combine(&self, lhs: T, rhs: T) -> T { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.base.combine(lhs, rhs) % self.modulo.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collecting.rs:82:11 [INFO] [stdout] | [INFO] [stdout] 81 | fn reduce(&self, reduce_source: NonEmpty) -> T { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | (&self(reduce_source)).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `untitled12345` (bin "untitled12345") due to 7 previous errors; 27 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap_unsafe/maybe_garbage_vec.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn tap_non_empty_uninit_vec(len: usize, tap: impl FnOnce(&mut NonEmpty>)) -> NonEmpty { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | temp.into_iter().map(|a| unsafe { a.assume_init() }).collect::>().try_into().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `untitled12345` (bin "untitled12345" test) due to 7 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "176fcfb01cb0882cf1ba04fdade4828d802124da62977523cc1a4381e74e077c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "176fcfb01cb0882cf1ba04fdade4828d802124da62977523cc1a4381e74e077c", kill_on_drop: false }` [INFO] [stdout] 176fcfb01cb0882cf1ba04fdade4828d802124da62977523cc1a4381e74e077c