[INFO] cloning repository https://github.com/Kelerchian/expr-bcrypt-qthreaded [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kelerchian/expr-bcrypt-qthreaded" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKelerchian%2Fexpr-bcrypt-qthreaded", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKelerchian%2Fexpr-bcrypt-qthreaded'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f52b332ca4dc317df2f202fbe9fb52f7cc0ec058 [INFO] checking Kelerchian/expr-bcrypt-qthreaded/f52b332ca4dc317df2f202fbe9fb52f7cc0ec058 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKelerchian%2Fexpr-bcrypt-qthreaded" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Kelerchian/expr-bcrypt-qthreaded on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Kelerchian/expr-bcrypt-qthreaded [INFO] finished tweaking git repo https://github.com/Kelerchian/expr-bcrypt-qthreaded [INFO] tweaked toml for git repo https://github.com/Kelerchian/expr-bcrypt-qthreaded written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Kelerchian/expr-bcrypt-qthreaded already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ee4d9fad9a3c2f394218e66d3bd764a4e59f52fa4f402c9a1003939c3ff9607 [INFO] running `Command { std: "docker" "start" "-a" "4ee4d9fad9a3c2f394218e66d3bd764a4e59f52fa4f402c9a1003939c3ff9607", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ee4d9fad9a3c2f394218e66d3bd764a4e59f52fa4f402c9a1003939c3ff9607", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ee4d9fad9a3c2f394218e66d3bd764a4e59f52fa4f402c9a1003939c3ff9607", kill_on_drop: false }` [INFO] [stdout] 4ee4d9fad9a3c2f394218e66d3bd764a4e59f52fa4f402c9a1003939c3ff9607 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87dcff50a42a329338514a6e80d3ebdf3b1419b0f5413ab4baaaab9cf8f1cc17 [INFO] running `Command { std: "docker" "start" "-a" "87dcff50a42a329338514a6e80d3ebdf3b1419b0f5413ab4baaaab9cf8f1cc17", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking base64 v0.12.0 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Checking blowfish v0.4.0 [INFO] [stderr] Checking random-integer v1.1.1 [INFO] [stderr] Checking bcrypt v0.6.2 [INFO] [stderr] Checking random-pick v1.2.8 [INFO] [stderr] Checking passwords v3.0.0 [INFO] [stderr] Checking expr-bcrypt-qthreaded v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Receiver` [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{Receiver, Sender}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Receiver` [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{Receiver, Sender}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..*worker_num { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut lines_iter = BufReader::new(&in_file).lines(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `results` [INFO] [stdout] --> src/bcrypt_example/batched.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let results = join_handles [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_results` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/bcrypt_example/batched.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 56 | Err(e) => String::from("hash-failed"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..*worker_num { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 45 | fn exec(&self, func: Box () + Send>) { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let strong = Arc::clone(&self.active_arc); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / self.tx [INFO] [stdout] 48 | | .send(Some(Box::new(move || { [INFO] [stdout] 49 | | let weak = Arc::downgrade(&strong); [INFO] [stdout] 50 | | func(); [INFO] [stdout] 51 | | drop(weak); [INFO] [stdout] 52 | | }))) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | self.tx.send(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.tx.send(None); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:140:35 [INFO] [stdout] | [INFO] [stdout] 134 | let out_file_mutex_clone = Arc::clone(&out_file_mutex); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match hash_and_write(&pass_u8, &out_file_mutex_clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut lines_iter = BufReader::new(&in_file).lines(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bcrypt_example/batched.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | out_file.write(res.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = out_file.write(res.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `results` [INFO] [stdout] --> src/bcrypt_example/batched.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let results = join_handles [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_results` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/bcrypt_example/batched.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 56 | Err(e) => String::from("hash-failed"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 45 | fn exec(&self, func: Box () + Send>) { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let strong = Arc::clone(&self.active_arc); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / self.tx [INFO] [stdout] 48 | | .send(Some(Box::new(move || { [INFO] [stdout] 49 | | let weak = Arc::downgrade(&strong); [INFO] [stdout] 50 | | func(); [INFO] [stdout] 51 | | drop(weak); [INFO] [stdout] 52 | | }))) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `expr-bcrypt-qthreaded` (bin "expr-bcrypt-qthreaded" test) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | self.tx.send(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.tx.send(None); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcrypt_example/qthreaded.rs:140:35 [INFO] [stdout] | [INFO] [stdout] 134 | let out_file_mutex_clone = Arc::clone(&out_file_mutex); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match hash_and_write(&pass_u8, &out_file_mutex_clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bcrypt_example/batched.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | out_file.write(res.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = out_file.write(res.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `expr-bcrypt-qthreaded` (bin "expr-bcrypt-qthreaded") due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "87dcff50a42a329338514a6e80d3ebdf3b1419b0f5413ab4baaaab9cf8f1cc17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87dcff50a42a329338514a6e80d3ebdf3b1419b0f5413ab4baaaab9cf8f1cc17", kill_on_drop: false }` [INFO] [stdout] 87dcff50a42a329338514a6e80d3ebdf3b1419b0f5413ab4baaaab9cf8f1cc17