[INFO] cloning repository https://github.com/Kartoffelsaft/rust-threaded-game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kartoffelsaft/rust-threaded-game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartoffelsaft%2Frust-threaded-game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartoffelsaft%2Frust-threaded-game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d45724fad905a4ac03d79bdeebc68ace0321881 [INFO] checking Kartoffelsaft/rust-threaded-game/7d45724fad905a4ac03d79bdeebc68ace0321881 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartoffelsaft%2Frust-threaded-game" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Kartoffelsaft/rust-threaded-game on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Kartoffelsaft/rust-threaded-game [INFO] finished tweaking git repo https://github.com/Kartoffelsaft/rust-threaded-game [INFO] tweaked toml for git repo https://github.com/Kartoffelsaft/rust-threaded-game written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Kartoffelsaft/rust-threaded-game already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e896cae4ad394061c069e3044a374db1ce29caeafaa0e0f5dbd5cf8eb134a93 [INFO] running `Command { std: "docker" "start" "-a" "7e896cae4ad394061c069e3044a374db1ce29caeafaa0e0f5dbd5cf8eb134a93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e896cae4ad394061c069e3044a374db1ce29caeafaa0e0f5dbd5cf8eb134a93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e896cae4ad394061c069e3044a374db1ce29caeafaa0e0f5dbd5cf8eb134a93", kill_on_drop: false }` [INFO] [stdout] 7e896cae4ad394061c069e3044a374db1ce29caeafaa0e0f5dbd5cf8eb134a93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94620799b366c715b76f9837e55869b17e5f8e5d9fdd0c8efb60134c19e0bb69 [INFO] running `Command { std: "docker" "start" "-a" "94620799b366c715b76f9837e55869b17e5f8e5d9fdd0c8efb60134c19e0bb69", kill_on_drop: false }` [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking console_app_game v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `channel` [INFO] [stdout] --> src/threading/entities/mod.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | channel, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | pub entity_inst: Arc>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | pub entity_inst: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `channel` [INFO] [stdout] --> src/threading/entities/mod.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | channel, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:60:80 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn routine(commands: Receiver, mut entity_inst: Arc>) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | pub fn routine(commands: Receiver, mut entity_inst: Arc>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:73:85 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_commands(commands: &Receiver, entity_inst: &mut Arc>) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_commands(commands: &Receiver, entity_inst: &mut Arc>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | pub entity_inst: Arc>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | pub entity_inst: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:60:80 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn routine(commands: Receiver, mut entity_inst: Arc>) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | pub fn routine(commands: Receiver, mut entity_inst: Arc>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/entities/entity.rs:73:85 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_commands(commands: &Receiver, entity_inst: &mut Arc>) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_commands(commands: &Receiver, entity_inst: &mut Arc>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/threading/collision_handler/movement.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut loc = self.get_loc_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/threading/entities/entity.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct EntityCommunicator [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 33 | { [INFO] [stdout] 34 | thread: JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading/entities/entity.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 45 | let (communicator_teller, entity_receiver) = channel(); [INFO] [stdout] | ------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let new_entity_inst = Arc::new(Mutex::new(cow::Cow::new(ptr))); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let new_entity_inst_cpy = new_entity_inst.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | thread: std::thread::spawn(move || [INFO] [stdout] | _____________________^ [INFO] [stdout] 51 | | { [INFO] [stdout] 52 | | routine(entity_receiver, new_entity_inst_cpy) [INFO] [stdout] 53 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/threading/collision_handler/movement.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut loc = self.get_loc_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/threading/entities/entity.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct EntityCommunicator [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 33 | { [INFO] [stdout] 34 | thread: JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/threading/general.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | reciever.send(ThreadMessage::BroadCast(message.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = reciever.send(ThreadMessage::BroadCast(message.clone())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading/entities/entity.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 45 | let (communicator_teller, entity_receiver) = channel(); [INFO] [stdout] | ------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let new_entity_inst = Arc::new(Mutex::new(cow::Cow::new(ptr))); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let new_entity_inst_cpy = new_entity_inst.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | thread: std::thread::spawn(move || [INFO] [stdout] | _____________________^ [INFO] [stdout] 51 | | { [INFO] [stdout] 52 | | routine(entity_receiver, new_entity_inst_cpy) [INFO] [stdout] 53 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/threading/general.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | reciever.send(ThreadMessage::BroadCast(message.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = reciever.send(ThreadMessage::BroadCast(message.clone())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `console_app_game` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `console_app_game` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "94620799b366c715b76f9837e55869b17e5f8e5d9fdd0c8efb60134c19e0bb69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94620799b366c715b76f9837e55869b17e5f8e5d9fdd0c8efb60134c19e0bb69", kill_on_drop: false }` [INFO] [stdout] 94620799b366c715b76f9837e55869b17e5f8e5d9fdd0c8efb60134c19e0bb69