[INFO] cloning repository https://github.com/KartikAiyer/media_atoms [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KartikAiyer/media_atoms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartikAiyer%2Fmedia_atoms", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartikAiyer%2Fmedia_atoms'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 47f25ad44e6813e899a0a4fd90bdba6f60df961b [INFO] checking KartikAiyer/media_atoms/47f25ad44e6813e899a0a4fd90bdba6f60df961b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKartikAiyer%2Fmedia_atoms" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KartikAiyer/media_atoms on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/KartikAiyer/media_atoms [INFO] finished tweaking git repo https://github.com/KartikAiyer/media_atoms [INFO] tweaked toml for git repo https://github.com/KartikAiyer/media_atoms written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KartikAiyer/media_atoms already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eede4b19c46182bc8f98ac563b29367c7ccf60cab377efc5f55c01f373223559 [INFO] running `Command { std: "docker" "start" "-a" "eede4b19c46182bc8f98ac563b29367c7ccf60cab377efc5f55c01f373223559", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eede4b19c46182bc8f98ac563b29367c7ccf60cab377efc5f55c01f373223559", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eede4b19c46182bc8f98ac563b29367c7ccf60cab377efc5f55c01f373223559", kill_on_drop: false }` [INFO] [stdout] eede4b19c46182bc8f98ac563b29367c7ccf60cab377efc5f55c01f373223559 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b776b4b5c7e2577bdcea20b869fbdc190f125d20c4f7bacbf50adafd96d46db [INFO] running `Command { std: "docker" "start" "-a" "4b776b4b5c7e2577bdcea20b869fbdc190f125d20c4f7bacbf50adafd96d46db", kill_on_drop: false }` [INFO] [stderr] Checking media_atoms v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `containers::ContainerAtoms` [INFO] [stdout] --> src/parse_state.rs:4:53 [INFO] [stdout] | [INFO] [stdout] 4 | use super::atoms::{AtomLike, AtomHeader, AtomNodes, containers::ContainerAtoms}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/parse_state.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{Read, SeekFrom, Seek}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BorrowMut` and `Borrow` [INFO] [stdout] --> src/parse_state.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use std::borrow::{BorrowMut, Borrow}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parse_state.rs:81:52 [INFO] [stdout] | [INFO] [stdout] 81 | retval = print_tree(f, child, depth+1, (stuff == size)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 81 - retval = print_tree(f, child, depth+1, (stuff == size)); [INFO] [stdout] 81 + retval = print_tree(f, child, depth+1, stuff == size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/atoms.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `containers::ContainerAtoms` [INFO] [stdout] --> src/parse_state.rs:4:53 [INFO] [stdout] | [INFO] [stdout] 4 | use super::atoms::{AtomLike, AtomHeader, AtomNodes, containers::ContainerAtoms}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/parse_state.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{Read, SeekFrom, Seek}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BorrowMut` and `Borrow` [INFO] [stdout] --> src/parse_state.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use std::borrow::{BorrowMut, Borrow}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parse_state.rs:81:52 [INFO] [stdout] | [INFO] [stdout] 81 | retval = print_tree(f, child, depth+1, (stuff == size)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 81 - retval = print_tree(f, child, depth+1, (stuff == size)); [INFO] [stdout] 81 + retval = print_tree(f, child, depth+1, stuff == size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:72:15 [INFO] [stdout] | [INFO] [stdout] 72 | let mut retval = Ok(()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:75:11 [INFO] [stdout] | [INFO] [stdout] 75 | retval = write!(f, "{:width$}", "", width = (2*depth)); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:86:11 [INFO] [stdout] | [INFO] [stdout] 86 | retval = write!(f, "{:width$}", "", width = (2*depth)); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `atom` [INFO] [stdout] --> src/atoms.rs:292:30 [INFO] [stdout] | [INFO] [stdout] 292 | ContainerAtoms::Root(atom) => writeln!(f, "/" ), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_atom` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:393:11 [INFO] [stdout] | [INFO] [stdout] 393 | let mut location = atom_header.atom_location() + atom_header.header_size() as u64; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:592:11 [INFO] [stdout] | [INFO] [stdout] 592 | let mut buf = atom_header.read_atom(file)?; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:72:15 [INFO] [stdout] | [INFO] [stdout] 72 | let mut retval = Ok(()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/atoms.rs:746:11 [INFO] [stdout] | [INFO] [stdout] 746 | for i in 0..result.num_features { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:75:11 [INFO] [stdout] | [INFO] [stdout] 75 | retval = write!(f, "{:width$}", "", width = (2*depth)); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `retval` is never read [INFO] [stdout] --> src/parse_state.rs:86:11 [INFO] [stdout] | [INFO] [stdout] 86 | retval = write!(f, "{:width$}", "", width = (2*depth)); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:739:11 [INFO] [stdout] | [INFO] [stdout] 739 | let mut bytes = header.read_atom(file)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `filename` is never read [INFO] [stdout] --> src/parse_state.rs:147:3 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 147 | filename: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TkhdAtom` is never constructed [INFO] [stdout] --> src/atoms.rs:928:10 [INFO] [stdout] | [INFO] [stdout] 928 | struct TkhdAtom { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TkhdAtom` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `atom` [INFO] [stdout] --> src/atoms.rs:292:30 [INFO] [stdout] | [INFO] [stdout] 292 | ContainerAtoms::Root(atom) => writeln!(f, "/" ), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_atom` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/parse_state.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | self.file.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 171 | let _ = self.file.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:291:7 [INFO] [stdout] | [INFO] [stdout] 291 | / match self { [INFO] [stdout] 292 | | ContainerAtoms::Root(atom) => writeln!(f, "/" ), [INFO] [stdout] 293 | | ContainerAtoms::Moov(atom) => writeln!(f, "{}", atom), [INFO] [stdout] 294 | | ContainerAtoms::Trak(atom) => writeln!(f, "{}", atom), [INFO] [stdout] 295 | | }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 291 | let _ = match self { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | file.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 335 | let _ = file.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:393:11 [INFO] [stdout] | [INFO] [stdout] 393 | let mut location = atom_header.atom_location() + atom_header.header_size() as u64; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:554:11 [INFO] [stdout] | [INFO] [stdout] 554 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:558:11 [INFO] [stdout] | [INFO] [stdout] 558 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:562:11 [INFO] [stdout] | [INFO] [stdout] 562 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:566:11 [INFO] [stdout] | [INFO] [stdout] 566 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:570:11 [INFO] [stdout] | [INFO] [stdout] 570 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:670:7 [INFO] [stdout] | [INFO] [stdout] 670 | write!(f, "Wide: {}", self.atom_header); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:743:7 [INFO] [stdout] | [INFO] [stdout] 743 | bytes.read(&mut tmp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 743 | let _ = bytes.read(&mut tmp); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:852:7 [INFO] [stdout] | [INFO] [stdout] 852 | file.read(&mut result.matrix); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 852 | let _ = file.read(&mut result.matrix); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:592:11 [INFO] [stdout] | [INFO] [stdout] 592 | let mut buf = atom_header.read_atom(file)?; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/atoms.rs:746:11 [INFO] [stdout] | [INFO] [stdout] 746 | for i in 0..result.num_features { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/atoms.rs:739:11 [INFO] [stdout] | [INFO] [stdout] 739 | let mut bytes = header.read_atom(file)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 26 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `filename` is never read [INFO] [stdout] --> src/parse_state.rs:147:3 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 147 | filename: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TkhdAtom` is never constructed [INFO] [stdout] --> src/atoms.rs:928:10 [INFO] [stdout] | [INFO] [stdout] 928 | struct TkhdAtom { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TkhdAtom` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/parse_state.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | self.file.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 171 | let _ = self.file.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_state.rs:208:11 [INFO] [stdout] | [INFO] [stdout] 206 | let res = Parser::new("resources/test/Nonsense.mp4"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | assert!(res.is_err()); [INFO] [stdout] 208 | match res.err().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_state.rs:223:11 [INFO] [stdout] | [INFO] [stdout] 221 | let res = Parser::new("resources/tests/empty_file.mp4"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | assert!(res.is_err()); [INFO] [stdout] 223 | match res.err().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:291:7 [INFO] [stdout] | [INFO] [stdout] 291 | / match self { [INFO] [stdout] 292 | | ContainerAtoms::Root(atom) => writeln!(f, "/" ), [INFO] [stdout] 293 | | ContainerAtoms::Moov(atom) => writeln!(f, "{}", atom), [INFO] [stdout] 294 | | ContainerAtoms::Trak(atom) => writeln!(f, "{}", atom), [INFO] [stdout] 295 | | }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 291 | let _ = match self { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:335:7 [INFO] [stdout] | [INFO] [stdout] 335 | file.seek(SeekFrom::Start(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 335 | let _ = file.seek(SeekFrom::Start(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:554:11 [INFO] [stdout] | [INFO] [stdout] 554 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:558:11 [INFO] [stdout] | [INFO] [stdout] 558 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:562:11 [INFO] [stdout] | [INFO] [stdout] 562 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:566:11 [INFO] [stdout] | [INFO] [stdout] 566 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:570:11 [INFO] [stdout] | [INFO] [stdout] 570 | write!(f, "{}", atom); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:670:7 [INFO] [stdout] | [INFO] [stdout] 670 | write!(f, "Wide: {}", self.atom_header); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:743:7 [INFO] [stdout] | [INFO] [stdout] 743 | bytes.read(&mut tmp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 743 | let _ = bytes.read(&mut tmp); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/atoms.rs:852:7 [INFO] [stdout] | [INFO] [stdout] 852 | file.read(&mut result.matrix); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 852 | let _ = file.read(&mut result.matrix); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 25 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | if( args.len() != 2) { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 9 - if( args.len() != 2) { [INFO] [stdout] 9 + if args.len() != 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | if( args.len() != 2) { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 9 - if( args.len() != 2) { [INFO] [stdout] 9 + if args.len() != 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `media_atoms` (lib test) due to 3 previous errors; 25 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4b776b4b5c7e2577bdcea20b869fbdc190f125d20c4f7bacbf50adafd96d46db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b776b4b5c7e2577bdcea20b869fbdc190f125d20c4f7bacbf50adafd96d46db", kill_on_drop: false }` [INFO] [stdout] 4b776b4b5c7e2577bdcea20b869fbdc190f125d20c4f7bacbf50adafd96d46db