[INFO] cloning repository https://github.com/KSXGitHub/sane-fmt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KSXGitHub/sane-fmt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKSXGitHub%2Fsane-fmt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKSXGitHub%2Fsane-fmt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6f6c6d326dcaa314578b2b4c112ea9a32b01b3ea [INFO] checking KSXGitHub/sane-fmt/6f6c6d326dcaa314578b2b4c112ea9a32b01b3ea against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKSXGitHub%2Fsane-fmt" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KSXGitHub/sane-fmt on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/KSXGitHub/sane-fmt [INFO] finished tweaking git repo https://github.com/KSXGitHub/sane-fmt [INFO] tweaked toml for git repo https://github.com/KSXGitHub/sane-fmt written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KSXGitHub/sane-fmt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d3a4b071cb781a9e78ad5263fbebaec7f6f6b303f891df253b79895e9717946 [INFO] running `Command { std: "docker" "start" "-a" "8d3a4b071cb781a9e78ad5263fbebaec7f6f6b303f891df253b79895e9717946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d3a4b071cb781a9e78ad5263fbebaec7f6f6b303f891df253b79895e9717946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d3a4b071cb781a9e78ad5263fbebaec7f6f6b303f891df253b79895e9717946", kill_on_drop: false }` [INFO] [stdout] 8d3a4b071cb781a9e78ad5263fbebaec7f6f6b303f891df253b79895e9717946 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3e083c2890a5d07368e7ff14ee9e99da2e0bef50050f59979175b2a650667be [INFO] running `Command { std: "docker" "start" "-a" "c3e083c2890a5d07368e7ff14ee9e99da2e0bef50050f59979175b2a650667be", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling cc v1.0.87 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling ahash v0.8.9 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking better_scoped_tls v0.1.1 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking unicode-id v0.3.4 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking data-url v0.3.1 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking bumpalo v3.15.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking pipe-trait v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking deno_terminal v0.1.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking relative-path v1.9.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking winnow v0.6.2 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking text-block-macros v0.1.1 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling swc_macros_common v0.3.9 [INFO] [stderr] Compiling pmutil v0.6.1 [INFO] [stderr] Compiling dprint-core-macros v0.1.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling swc_visit_macros v0.5.10 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling swc_eq_ignore_macros v0.1.3 [INFO] [stderr] Compiling from_variant v0.1.7 [INFO] [stderr] Compiling ast_node v0.9.6 [INFO] [stderr] Compiling string_enum v0.4.2 [INFO] [stderr] Compiling is-macro v0.3.5 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking hstr v0.2.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking clap_complete v4.5.1 [INFO] [stderr] Checking clap-utilities v0.2.0 [INFO] [stderr] Checking swc_visit v0.5.9 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking swc_atoms v0.6.5 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking text_lines v0.6.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking deno_media_type v0.1.2 [INFO] [stderr] Checking dprint-core v0.66.1 [INFO] [stderr] Checking toml_edit v0.22.6 [INFO] [stderr] Checking swc_common v0.33.17 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking swc_ecma_ast v0.112.2 [INFO] [stderr] Checking swc_ecma_parser v0.143.3 [INFO] [stderr] Checking dprint-swc-ext v0.15.1 [INFO] [stderr] Checking deno_ast v0.34.0 [INFO] [stderr] Checking dprint-plugin-typescript v0.89.3 [INFO] [stderr] Checking sane-fmt v0.18.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `file_type` is never read [INFO] [stdout] --> src/file_list.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Item { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 13 | pub path: PathBuf, [INFO] [stdout] 14 | pub file_type: FileType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `scan` is never used [INFO] [stdout] --> src/term/color.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait ColorScheme { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 7 | fn scan(&self) -> Style; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cross_platform_path.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn convert_string>(text: Text, separator: char) -> String { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | convert_chars(text.as_ref().chars(), separator).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_list/read_dir.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|entry| -> Result<_, _> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let entry = entry.map_err(|error| Error::new(dirname.to_path_buf(), error))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok((entry, path, file_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_list/read_list.rs:20:23 [INFO] [stdout] | [INFO] [stdout] 20 | .pipe(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file_type` is never read [INFO] [stdout] --> src/file_list.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Item { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 13 | pub path: PathBuf, [INFO] [stdout] 14 | pub file_type: FileType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `scan` is never used [INFO] [stdout] --> src/term/color.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait ColorScheme { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 7 | fn scan(&self) -> Style; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cross_platform_path.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn convert_string>(text: Text, separator: char) -> String { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | convert_chars(text.as_ref().chars(), separator).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_list/read_dir.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|entry| -> Result<_, _> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let entry = entry.map_err(|error| Error::new(dirname.to_path_buf(), error))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok((entry, path, file_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_list/read_list.rs:20:23 [INFO] [stdout] | [INFO] [stdout] 20 | .pipe(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sane-fmt` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sane-fmt` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c3e083c2890a5d07368e7ff14ee9e99da2e0bef50050f59979175b2a650667be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3e083c2890a5d07368e7ff14ee9e99da2e0bef50050f59979175b2a650667be", kill_on_drop: false }` [INFO] [stdout] c3e083c2890a5d07368e7ff14ee9e99da2e0bef50050f59979175b2a650667be