[INFO] updating cached repository https://github.com/KSXGitHub/parallel-disk-usage [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5e48cff65acbe2c49ece7ab93a281beb2afb3a9 [INFO] checking KSXGitHub/parallel-disk-usage/e5e48cff65acbe2c49ece7ab93a281beb2afb3a9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKSXGitHub%2Fparallel-disk-usage" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KSXGitHub/parallel-disk-usage on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/KSXGitHub/parallel-disk-usage [INFO] finished tweaking git repo https://github.com/KSXGitHub/parallel-disk-usage [INFO] tweaked toml for git repo https://github.com/KSXGitHub/parallel-disk-usage written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KSXGitHub/parallel-disk-usage already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96b25e79a4ab6066f016ba92c6a9a8d245c9ad473af34e3b494af3d05e750e21 [INFO] running `Command { std: "docker" "start" "-a" "96b25e79a4ab6066f016ba92c6a9a8d245c9ad473af34e3b494af3d05e750e21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96b25e79a4ab6066f016ba92c6a9a8d245c9ad473af34e3b494af3d05e750e21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96b25e79a4ab6066f016ba92c6a9a8d245c9ad473af34e3b494af3d05e750e21", kill_on_drop: false }` [INFO] [stdout] 96b25e79a4ab6066f016ba92c6a9a8d245c9ad473af34e3b494af3d05e750e21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41c2c21da8487cb885f546834c3941789317244be5d00b60853ed6c6fb14ba83 [INFO] running `Command { std: "docker" "start" "-a" "41c2c21da8487cb885f546834c3941789317244be5d00b60853ed6c6fb14ba83", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking pipe-trait v0.4.0 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking text-block-macros v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking assert-cmp v0.2.1 [INFO] [stderr] Checking rounded-div v0.1.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking command-extra v1.0.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking indexmap v2.2.2 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling_core v0.12.4 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling smart-default v0.7.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling darling_macro v0.12.4 [INFO] [stderr] Compiling darling v0.12.4 [INFO] [stderr] Compiling derive_builder_core v0.10.2 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking clap_complete v4.5.0 [INFO] [stderr] Checking clap-utilities v0.2.0 [INFO] [stderr] Checking fmt-iter v0.2.1 [INFO] [stderr] Compiling derive_builder_macro v0.10.2 [INFO] [stderr] Checking derive_builder v0.10.2 [INFO] [stderr] Checking zero-copy-pads v0.2.0 [INFO] [stderr] Checking serde_yaml v0.9.31 [INFO] [stderr] Checking parallel-disk-usage v0.9.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking build-fs-tree v0.6.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/reflection/par_methods.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn par_try_into_tree(self) -> Result, ConversionError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let Reflection { [INFO] [stdout] 14 | name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | data, [INFO] [stdout] 16 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let children: Result, _> = children [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let children = match children { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(children) => children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Err(ConversionError::ExcessiveChildren { [INFO] [stdout] 34 | mut path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | data, [INFO] [stdout] 36 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(DataTree { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | name, [INFO] [stdout] 50 | | data, [INFO] [stdout] 51 | | children, [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/reflection/par_methods.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 57 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | data, [INFO] [stdout] 69 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | } = self; [INFO] [stdout] 71 | let children = children [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let (name, data) = transform(name, data)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(Reflection { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | name, [INFO] [stdout] 78 | | data, [INFO] [stdout] 79 | | children, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/constructors.rs:20:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn file(name: Name, data: Data) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | children: Vec::with_capacity(0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|name| TreeBuilder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | path: join_path(&path, &name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parallel-disk-usage` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/reflection/par_methods.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn par_try_into_tree(self) -> Result, ConversionError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let Reflection { [INFO] [stdout] 14 | name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | data, [INFO] [stdout] 16 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let children: Result, _> = children [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let children = match children { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(children) => children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Err(ConversionError::ExcessiveChildren { [INFO] [stdout] 34 | mut path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | data, [INFO] [stdout] 36 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(DataTree { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | name, [INFO] [stdout] 50 | | data, [INFO] [stdout] 51 | | children, [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/reflection/par_methods.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 57 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | data, [INFO] [stdout] 69 | children, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | } = self; [INFO] [stdout] 71 | let children = children [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let (name, data) = transform(name, data)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(Reflection { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | name, [INFO] [stdout] 78 | | data, [INFO] [stdout] 79 | | children, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_tree/constructors.rs:20:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn file(name: Name, data: Data) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | children: Vec::with_capacity(0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|name| TreeBuilder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | path: join_path(&path, &name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parallel-disk-usage` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "41c2c21da8487cb885f546834c3941789317244be5d00b60853ed6c6fb14ba83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41c2c21da8487cb885f546834c3941789317244be5d00b60853ed6c6fb14ba83", kill_on_drop: false }` [INFO] [stdout] 41c2c21da8487cb885f546834c3941789317244be5d00b60853ed6c6fb14ba83