[INFO] cloning repository https://github.com/Juuxel/architectury-versions [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Juuxel/architectury-versions" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJuuxel%2Farchitectury-versions", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJuuxel%2Farchitectury-versions'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a0b804d59879f199be94505f6e43c9270ff59162 [INFO] checking Juuxel/architectury-versions/a0b804d59879f199be94505f6e43c9270ff59162 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJuuxel%2Farchitectury-versions" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Juuxel/architectury-versions on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Juuxel/architectury-versions [INFO] finished tweaking git repo https://github.com/Juuxel/architectury-versions [INFO] tweaked toml for git repo https://github.com/Juuxel/architectury-versions written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Juuxel/architectury-versions already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79ccbde7ea454e815a86c44b9fb618cfcf107d2a27f3b2f4151fb62f18ab1ead [INFO] running `Command { std: "docker" "start" "-a" "79ccbde7ea454e815a86c44b9fb618cfcf107d2a27f3b2f4151fb62f18ab1ead", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79ccbde7ea454e815a86c44b9fb618cfcf107d2a27f3b2f4151fb62f18ab1ead", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79ccbde7ea454e815a86c44b9fb618cfcf107d2a27f3b2f4151fb62f18ab1ead", kill_on_drop: false }` [INFO] [stdout] 79ccbde7ea454e815a86c44b9fb618cfcf107d2a27f3b2f4151fb62f18ab1ead [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9184af1e35e70a0bc9818e7e527b1840c9f8d895880b59f166482d6febff0d4 [INFO] running `Command { std: "docker" "start" "-a" "f9184af1e35e70a0bc9818e7e527b1840c9f8d895880b59f166482d6febff0d4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling httparse v1.7.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling substring v1.4.5 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking xmlparser v0.13.3 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking comfy-table v6.0.0-rc.1 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking architectury_versions v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 37 | let filter = Regex::new(json.get("filter")?.as_str()?).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let pom = String::from(json.get("pom")?.as_str()?); [INFO] [stdout] 39 | Some(VersionDefinition { filter, pom }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 79 | let api: VersionReference = json.convert_get("api")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let plugin: VersionReference = json.convert_get("plugin")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let loom: VersionReference = json.convert_get("loom")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let injectables: VersionReference = json.convert_get("injectables")?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(GameVersionData { [INFO] [stdout] | ______________^ [INFO] [stdout] 84 | | stable, [INFO] [stdout] 85 | | api, [INFO] [stdout] 86 | | plugin, [INFO] [stdout] 87 | | loom, [INFO] [stdout] 88 | | injectables, [INFO] [stdout] 89 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 131 | let definitions = map_from_json::(definitions_json)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let versions_json = json.get("versions")?.as_object()?; [INFO] [stdout] 133 | let versions = map_from_json::(versions_json)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(ArchitecturyJson { [INFO] [stdout] | ______________^ [INFO] [stdout] 135 | | definitions, [INFO] [stdout] 136 | | versions, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 37 | let filter = Regex::new(json.get("filter")?.as_str()?).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let pom = String::from(json.get("pom")?.as_str()?); [INFO] [stdout] 39 | Some(VersionDefinition { filter, pom }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `architectury_versions` (lib) due to 4 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 79 | let api: VersionReference = json.convert_get("api")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let plugin: VersionReference = json.convert_get("plugin")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let loom: VersionReference = json.convert_get("loom")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let injectables: VersionReference = json.convert_get("injectables")?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(GameVersionData { [INFO] [stdout] | ______________^ [INFO] [stdout] 84 | | stable, [INFO] [stdout] 85 | | api, [INFO] [stdout] 86 | | plugin, [INFO] [stdout] 87 | | loom, [INFO] [stdout] 88 | | injectables, [INFO] [stdout] 89 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/architectury.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 131 | let definitions = map_from_json::(definitions_json)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let versions_json = json.get("versions")?.as_object()?; [INFO] [stdout] 133 | let versions = map_from_json::(versions_json)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Some(ArchitecturyJson { [INFO] [stdout] | ______________^ [INFO] [stdout] 135 | | definitions, [INFO] [stdout] 136 | | versions, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `architectury_versions` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f9184af1e35e70a0bc9818e7e527b1840c9f8d895880b59f166482d6febff0d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9184af1e35e70a0bc9818e7e527b1840c9f8d895880b59f166482d6febff0d4", kill_on_drop: false }` [INFO] [stdout] f9184af1e35e70a0bc9818e7e527b1840c9f8d895880b59f166482d6febff0d4