[INFO] cloning repository https://github.com/Jumballaya/rust-wasm-minesweeper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jumballaya/rust-wasm-minesweeper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJumballaya%2Frust-wasm-minesweeper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJumballaya%2Frust-wasm-minesweeper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 612127836c022a0c25bbb6c339a9b2896ec24be4 [INFO] checking Jumballaya/rust-wasm-minesweeper/612127836c022a0c25bbb6c339a9b2896ec24be4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJumballaya%2Frust-wasm-minesweeper" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jumballaya/rust-wasm-minesweeper on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jumballaya/rust-wasm-minesweeper [INFO] finished tweaking git repo https://github.com/Jumballaya/rust-wasm-minesweeper [INFO] tweaked toml for git repo https://github.com/Jumballaya/rust-wasm-minesweeper written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jumballaya/rust-wasm-minesweeper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47cc10ed0076e695ea1352ab0f1bc1cfef5bce3a610c1f077dccd97fdc45fdfb [INFO] running `Command { std: "docker" "start" "-a" "47cc10ed0076e695ea1352ab0f1bc1cfef5bce3a610c1f077dccd97fdc45fdfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47cc10ed0076e695ea1352ab0f1bc1cfef5bce3a610c1f077dccd97fdc45fdfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47cc10ed0076e695ea1352ab0f1bc1cfef5bce3a610c1f077dccd97fdc45fdfb", kill_on_drop: false }` [INFO] [stdout] 47cc10ed0076e695ea1352ab0f1bc1cfef5bce3a610c1f077dccd97fdc45fdfb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 284de9ff05c932b1116a66ba1310a6fc87c4f510948fca170d703f9b9e8baa03 [INFO] running `Command { std: "docker" "start" "-a" "284de9ff05c932b1116a66ba1310a6fc87c4f510948fca170d703f9b9e8baa03", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.80 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling bumpalo v3.9.1 [INFO] [stderr] Compiling wasm-bindgen v0.2.80 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.80 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.80 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.80 [INFO] [stderr] Checking minesweeper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/minesweeper.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | if (!self.mines.contains(&pos)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - if (!self.mines.contains(&pos)) { [INFO] [stdout] 145 + if !self.mines.contains(&pos) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/minesweeper.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | if (!self.mines.contains(&pos)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - if (!self.mines.contains(&pos)) { [INFO] [stdout] 145 + if !self.mines.contains(&pos) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::Borrow` [INFO] [stdout] --> src/lib.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{borrow::Borrow, cell::RefCell}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::Borrow` [INFO] [stdout] --> src/lib.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{borrow::Borrow, cell::RefCell}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ms` [INFO] [stdout] --> src/lib.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | ms.replace_with(|ms| Minesweeper::new(w, h, mc)); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ms` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/minesweeper.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | NoMine(u8), [INFO] [stdout] | ------ ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | NoMine(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | MINESWEEPER.with(|ms| ms.borrow().to_string()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | MINESWEEPER.with(|ms| ms.borrow().won) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | MINESWEEPER.with(|ms| ms.borrow().lost) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ms` [INFO] [stdout] --> src/lib.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | ms.replace_with(|ms| Minesweeper::new(w, h, mc)); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ms` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/minesweeper.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | NoMine(u8), [INFO] [stdout] | ------ ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | NoMine(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | MINESWEEPER.with(|ms| ms.borrow().to_string()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | MINESWEEPER.with(|ms| ms.borrow().won) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | MINESWEEPER.with(|ms| ms.borrow().lost) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minesweeper` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `minesweeper` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "284de9ff05c932b1116a66ba1310a6fc87c4f510948fca170d703f9b9e8baa03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "284de9ff05c932b1116a66ba1310a6fc87c4f510948fca170d703f9b9e8baa03", kill_on_drop: false }` [INFO] [stdout] 284de9ff05c932b1116a66ba1310a6fc87c4f510948fca170d703f9b9e8baa03