[INFO] cloning repository https://github.com/JosephSullivan256/implicit-manifold [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JosephSullivan256/implicit-manifold" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephSullivan256%2Fimplicit-manifold", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephSullivan256%2Fimplicit-manifold'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9dcb698c4816f7001faaeebb87e8896d61b4dec0 [INFO] checking JosephSullivan256/implicit-manifold/9dcb698c4816f7001faaeebb87e8896d61b4dec0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephSullivan256%2Fimplicit-manifold" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JosephSullivan256/implicit-manifold on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JosephSullivan256/implicit-manifold [INFO] finished tweaking git repo https://github.com/JosephSullivan256/implicit-manifold [INFO] tweaked toml for git repo https://github.com/JosephSullivan256/implicit-manifold written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JosephSullivan256/implicit-manifold already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acaff73218e82fb644960113acbf9dfd29230ba41b1e751ca8784c56ba38356f [INFO] running `Command { std: "docker" "start" "-a" "acaff73218e82fb644960113acbf9dfd29230ba41b1e751ca8784c56ba38356f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acaff73218e82fb644960113acbf9dfd29230ba41b1e751ca8784c56ba38356f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acaff73218e82fb644960113acbf9dfd29230ba41b1e751ca8784c56ba38356f", kill_on_drop: false }` [INFO] [stdout] acaff73218e82fb644960113acbf9dfd29230ba41b1e751ca8784c56ba38356f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e967e50d80e15d1c27fa6b7883a84e45818e2c42ba27a9136f5ee33606ed50a0 [INFO] running `Command { std: "docker" "start" "-a" "e967e50d80e15d1c27fa6b7883a84e45818e2c42ba27a9136f5ee33606ed50a0", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling xml-rs v0.8.14 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling log v0.4.19 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.8.0 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Checking simd-adler32 v0.3.5 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking ttf-parser v0.19.1 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling glutin v0.30.9 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking glow v0.12.2 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.0 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling glutin_egl_sys v0.5.0 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking owned_ttf_parser v0.19.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling winit v0.28.6 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking ab_glyph v0.2.21 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking implicit-manifold-compute v0.1.0 (/opt/rustwide/workdir/implicit-manifold-compute) [INFO] [stdout] warning: unused import: `Zero` [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use super::ring_traits::{Zero, One, AddGroup}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:5:32 [INFO] [stdout] | [INFO] [stdout] 5 | use super::ring_traits::{Zero, One, AddGroup}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `zero` and `one` are never used [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 98 | / impl Mat [INFO] [stdout] 99 | | where [INFO] [stdout] 100 | | T: Ring, [INFO] [stdout] | |____________- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 108 | fn zero(n: usize) -> Mat { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | fn one(n: usize) -> Mat { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 170 | fn sub(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | self + (-rhs) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|i| self[(row, i)].clone() * rhs[(i, col)].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:216:55 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|i| self[(row, i)].clone() * rhs[(i, col)].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `implicit-manifold-compute` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `Zero` [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use super::ring_traits::{Zero, One, AddGroup}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:5:32 [INFO] [stdout] | [INFO] [stdout] 5 | use super::ring_traits::{Zero, One, AddGroup}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `abc` [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let abc = triangle.add(vec![bc,ac,ab]); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_abc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `U` [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let U = torus.add(vec![a,c,b]); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_U` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `L` [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | let L = torus.add(vec![a,c,b]); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_L` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `edge` [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | let edge = circle.add(vec![pt, pt]); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_edge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `zero` and `one` are never used [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 98 | / impl Mat [INFO] [stdout] 99 | | where [INFO] [stdout] 100 | | T: Ring, [INFO] [stdout] | |____________- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 108 | fn zero(n: usize) -> Mat { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | fn one(n: usize) -> Mat { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 170 | fn sub(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | self + (-rhs) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|i| self[(row, i)].clone() * rhs[(i, col)].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> implicit-manifold-compute/src/algebra/matrix.rs:216:55 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|i| self[(row, i)].clone() * rhs[(i, col)].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `U` should have a snake case name [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let U = torus.add(vec![a,c,b]); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `u` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `L` should have a snake case name [INFO] [stdout] --> implicit-manifold-compute/src/topology/delta_complex.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | let L = torus.add(vec![a,c,b]); [INFO] [stdout] | ^ help: convert the identifier to snake case: `l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `implicit-manifold-compute` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e967e50d80e15d1c27fa6b7883a84e45818e2c42ba27a9136f5ee33606ed50a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e967e50d80e15d1c27fa6b7883a84e45818e2c42ba27a9136f5ee33606ed50a0", kill_on_drop: false }` [INFO] [stdout] e967e50d80e15d1c27fa6b7883a84e45818e2c42ba27a9136f5ee33606ed50a0